Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/560301/?format=api
{ "id": 560301, "url": "http://patchwork.ozlabs.org/api/patches/560301/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1450823114-29514-7-git-send-email-deepthi.kavalur@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1450823114-29514-7-git-send-email-deepthi.kavalur@intel.com>", "list_archive_url": null, "date": "2015-12-22T22:25:08", "name": "[next,S24,06/12] i40e/i40evf: Use private workqueue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f05a1d35d7cb570da49e5e563bcd9e202f326383", "submitter": { "id": 67654, "url": "http://patchwork.ozlabs.org/api/people/67654/?format=api", "name": "Deepthi Kavalur", "email": "deepthi.kavalur@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1450823114-29514-7-git-send-email-deepthi.kavalur@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/560301/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/560301/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id CC3AF140320\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 23 Dec 2015 09:25:19 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1523095913;\n\tTue, 22 Dec 2015 22:25:19 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id cdXrG4b4bCf6; Tue, 22 Dec 2015 22:25:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0EB65958FC;\n\tTue, 22 Dec 2015 22:25:16 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 98BDC1C161D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 22:25:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 96FDC922F1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 22:25:14 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id goQ0cC3psoJ5 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 22:25:14 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BD0BD925BC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 22:25:13 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 22 Dec 2015 14:25:13 -0800", "from dkavalur-mobl.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.61])\n\tby orsmga002.jf.intel.com with ESMTP; 22 Dec 2015 14:25:13 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,466,1444719600\"; d=\"scan'208\";a=\"877072058\"", "From": "Deepthi Kavalur <deepthi.kavalur@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 22 Dec 2015 14:25:08 -0800", "Message-Id": "<1450823114-29514-7-git-send-email-deepthi.kavalur@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1450823114-29514-1-git-send-email-deepthi.kavalur@intel.com>", "References": "<1450823114-29514-1-git-send-email-deepthi.kavalur@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S24 06/12] i40e/i40evf: Use private\n\tworkqueue", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nAs done per ixgbe, use a private workqueue to avoid blocking the\nsystem workqueue. This avoids some strange side effects when\nsome other entity is depending on the system work queue.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nChange-ID: Ic8ba08f5b03696cf638b21afd25fbae7738d55ee\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 15 ++++++++++++++-\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 10 +++++++++-\n 2 files changed, 23 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex d7c3fd4..5bb1eae 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -109,6 +109,8 @@ MODULE_DESCRIPTION(\"Intel(R) Ethernet Connection XL710 Network Driver\");\n MODULE_LICENSE(\"GPL\");\n MODULE_VERSION(DRV_VERSION);\n \n+static struct workqueue_struct *i40e_wq;\n+\n /**\n * i40e_allocate_dma_mem_d - OS specific memory alloc for shared code\n * @hw: pointer to the HW structure\n@@ -294,7 +296,7 @@ static void i40e_service_event_schedule(struct i40e_pf *pf)\n \tif (!test_bit(__I40E_DOWN, &pf->state) &&\n \t !test_bit(__I40E_RESET_RECOVERY_PENDING, &pf->state) &&\n \t !test_and_set_bit(__I40E_SERVICE_SCHED, &pf->state))\n-\t\tschedule_work(&pf->service_task);\n+\t\tqueue_work(i40e_wq, &pf->service_task);\n }\n \n /**\n@@ -11362,6 +11364,16 @@ static int __init i40e_init_module(void)\n \t\ti40e_driver_string, i40e_driver_version_str);\n \tpr_info(\"%s: %s\\n\", i40e_driver_name, i40e_copyright);\n \n+\t/* we will see if single thread per module is enough for now,\n+\t * it can't be any worse than using the system workqueue which\n+\t * was already single threaded\n+\t */\n+\ti40e_wq = create_singlethread_workqueue(i40e_driver_name);\n+\tif (!i40e_wq) {\n+\t\tpr_err(\"%s: Failed to create workqueue\\n\", i40e_driver_name);\n+\t\treturn -ENOMEM;\n+\t}\n+\n \ti40e_dbg_init();\n \treturn pci_register_driver(&i40e_driver);\n }\n@@ -11376,6 +11388,7 @@ module_init(i40e_init_module);\n static void __exit i40e_exit_module(void)\n {\n \tpci_unregister_driver(&i40e_driver);\n+\tdestroy_workqueue(i40e_wq);\n \ti40e_dbg_exit();\n }\n module_exit(i40e_exit_module);\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex ab77e20..5b88123 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -69,6 +69,8 @@ MODULE_DESCRIPTION(\"Intel(R) XL710 X710 Virtual Function Network Driver\");\n MODULE_LICENSE(\"GPL\");\n MODULE_VERSION(DRV_VERSION);\n \n+static struct workqueue_struct *i40evf_wq;\n+\n /**\n * i40evf_allocate_dma_mem_d - OS specific memory alloc for shared code\n * @hw: pointer to the HW structure\n@@ -182,7 +184,7 @@ static void i40evf_tx_timeout(struct net_device *netdev)\n \tif (!(adapter->flags & (I40EVF_FLAG_RESET_PENDING |\n \t\t\t\tI40EVF_FLAG_RESET_NEEDED))) {\n \t\tadapter->flags |= I40EVF_FLAG_RESET_NEEDED;\n-\t\tschedule_work(&adapter->reset_task);\n+\t\tqueue_work(i40evf_wq, &adapter->reset_task);\n \t}\n }\n \n@@ -2885,6 +2887,11 @@ static int __init i40evf_init_module(void)\n \n \tpr_info(\"%s\\n\", i40evf_copyright);\n \n+\ti40evf_wq = create_singlethread_workqueue(i40evf_driver_name);\n+\tif (!i40evf_wq) {\n+\t\tpr_err(\"%s: Failed to create workqueue\\n\", i40evf_driver_name);\n+\t\treturn -ENOMEM;\n+\t}\n \tret = pci_register_driver(&i40evf_driver);\n \treturn ret;\n }\n@@ -2900,6 +2907,7 @@ module_init(i40evf_init_module);\n static void __exit i40evf_exit_module(void)\n {\n \tpci_unregister_driver(&i40evf_driver);\n+\tdestroy_workqueue(i40evf_wq);\n }\n \n module_exit(i40evf_exit_module);\n", "prefixes": [ "next", "S24", "06/12" ] }