Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/560287/?format=api
{ "id": 560287, "url": "http://patchwork.ozlabs.org/api/patches/560287/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20151222214344.42447.71576.stgit@bwallan-cwp1.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20151222214344.42447.71576.stgit@bwallan-cwp1.jf.intel.com>", "list_archive_url": null, "date": "2015-12-22T21:43:44", "name": "[next-queue,1/2] fm10k: Move constants to the right of binary operators", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "71078a735e8477dbda7949b9c6d6eb9e07537c9a", "submitter": { "id": 503, "url": "http://patchwork.ozlabs.org/api/people/503/?format=api", "name": "Allan, Bruce W", "email": "bruce.w.allan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20151222214344.42447.71576.stgit@bwallan-cwp1.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/560287/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/560287/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id BFDC71402C4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 23 Dec 2015 08:43:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5D02894E06;\n\tTue, 22 Dec 2015 21:43:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id sSLSaf61OXNb; Tue, 22 Dec 2015 21:43:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D9C2194ACE;\n\tTue, 22 Dec 2015 21:43:43 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E07691BFEE9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 21:43:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DAF0094C05\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 21:43:42 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Yen+egs-CEC0 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 21:43:41 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B00C294ACE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 21:43:41 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP; 22 Dec 2015 13:43:41 -0800", "from bwallan-cwp1.jf.intel.com ([10.166.136.47])\n\tby fmsmga004.fm.intel.com with ESMTP; 22 Dec 2015 13:43:41 -0800", "from bwallan-cwp1.jf.intel.com (localhost [127.0.0.1])\n\tby bwallan-cwp1.jf.intel.com (8.15.2/8.15.1) with ESMTP id\n\ttBMLhi4S042473 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 13:43:44 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,466,1444719600\"; d=\"scan'208\";a=\"17841436\"", "From": "Bruce Allan <bruce.w.allan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 22 Dec 2015 13:43:44 -0800", "Message-ID": "<20151222214344.42447.71576.stgit@bwallan-cwp1.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next-queue PATCH 1/2] fm10k: Move constants to\n\tthe right of binary operators", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The semantic patch that makes this change is available\nin scripts/coccinelle/misc/compare_const_fl.cocci.\n\nMore information about semantic patching is available at\nhttp://coccinelle.lip6.fr/\n\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +-\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 16 ++++++++--------\n drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 6 +++---\n 3 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\nindex 03607ec..d74d42a 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n@@ -420,7 +420,7 @@ static inline void fm10k_rx_hash(struct fm10k_ring *ring,\n \t\treturn;\n \n \tskb_set_hash(skb, le32_to_cpu(rx_desc->d.rss),\n-\t\t (FM10K_RSS_L4_TYPES_MASK & (1ul << rss_type)) ?\n+\t\t ((1ul << rss_type) & FM10K_RSS_L4_TYPES_MASK) ?\n \t\t PKT_HASH_TYPE_L4 : PKT_HASH_TYPE_L3);\n }\n \ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 4eb7a6f..86700a4 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -579,7 +579,7 @@ static void fm10k_configure_tx_ring(struct fm10k_intfc *interface,\n \tu64 tdba = ring->dma;\n \tu32 size = ring->count * sizeof(struct fm10k_tx_desc);\n \tu32 txint = FM10K_INT_MAP_DISABLE;\n-\tu32 txdctl = FM10K_TXDCTL_ENABLE | (1 << FM10K_TXDCTL_MAX_TIME_SHIFT);\n+\tu32 txdctl = (1 << FM10K_TXDCTL_MAX_TIME_SHIFT) | FM10K_TXDCTL_ENABLE;\n \tu8 reg_idx = ring->reg_idx;\n \n \t/* disable queue to avoid issues while updating state */\n@@ -903,8 +903,8 @@ static irqreturn_t fm10k_msix_mbx_vf(int __always_unused irq, void *data)\n \n \t/* re-enable mailbox interrupt and indicate 20us delay */\n \tfm10k_write_reg(hw, FM10K_VFITR(FM10K_MBX_VECTOR),\n-\t\t\tFM10K_ITR_ENABLE | (FM10K_MBX_INT_DELAY >>\n-\t\t\t\t\t hw->mac.itr_scale));\n+\t\t\t(FM10K_MBX_INT_DELAY >> hw->mac.itr_scale) |\n+\t\t\tFM10K_ITR_ENABLE);\n \n \t/* service upstream mailbox */\n \tif (fm10k_mbx_trylock(interface)) {\n@@ -1135,8 +1135,8 @@ static irqreturn_t fm10k_msix_mbx_pf(int __always_unused irq, void *data)\n \n \t/* re-enable mailbox interrupt and indicate 20us delay */\n \tfm10k_write_reg(hw, FM10K_ITR(FM10K_MBX_VECTOR),\n-\t\t\tFM10K_ITR_ENABLE | (FM10K_MBX_INT_DELAY >>\n-\t\t\t\t\t hw->mac.itr_scale));\n+\t\t\t(FM10K_MBX_INT_DELAY >> hw->mac.itr_scale) |\n+\t\t\tFM10K_ITR_ENABLE);\n \n \treturn IRQ_HANDLED;\n }\n@@ -1253,7 +1253,7 @@ static int fm10k_mbx_request_irq_vf(struct fm10k_intfc *interface)\n \tint err;\n \n \t/* Use timer0 for interrupt moderation on the mailbox */\n-\tu32 itr = FM10K_INT_MAP_TIMER0 | entry->entry;\n+\tu32 itr = entry->entry | FM10K_INT_MAP_TIMER0;\n \n \t/* register mailbox handlers */\n \terr = hw->mbx.ops.register_handlers(&hw->mbx, vf_mbx_data);\n@@ -1420,8 +1420,8 @@ static int fm10k_mbx_request_irq_pf(struct fm10k_intfc *interface)\n \tint err;\n \n \t/* Use timer0 for interrupt moderation on the mailbox */\n-\tu32 mbx_itr = FM10K_INT_MAP_TIMER0 | entry->entry;\n-\tu32 other_itr = FM10K_INT_MAP_IMMEDIATE | entry->entry;\n+\tu32 mbx_itr = entry->entry | FM10K_INT_MAP_TIMER0;\n+\tu32 other_itr = entry->entry | FM10K_INT_MAP_IMMEDIATE;\n \n \t/* register mailbox handlers */\n \terr = hw->mbx.ops.register_handlers(&hw->mbx, pf_mbx_data);\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\nindex 62ccebc..34a0b03 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n@@ -711,8 +711,8 @@ static s32 fm10k_iov_assign_resources_pf(struct fm10k_hw *hw, u16 num_vfs,\n \t\t\t\t\tFM10K_RXDCTL_WRITE_BACK_MIN_DELAY |\n \t\t\t\t\tFM10K_RXDCTL_DROP_ON_EMPTY);\n \t\t\tfm10k_write_reg(hw, FM10K_RXQCTL(vf_q_idx),\n-\t\t\t\t\tFM10K_RXQCTL_VF |\n-\t\t\t\t\t(i << FM10K_RXQCTL_VF_SHIFT));\n+\t\t\t\t\t(i << FM10K_RXQCTL_VF_SHIFT) |\n+\t\t\t\t\tFM10K_RXQCTL_VF);\n \n \t\t\t/* map queue pair to VF */\n \t\t\tfm10k_write_reg(hw, FM10K_TQMAP(qmap_idx), vf_q_idx);\n@@ -987,7 +987,7 @@ static s32 fm10k_iov_reset_resources_pf(struct fm10k_hw *hw,\n \ttxqctl = ((u32)vf_vid << FM10K_TXQCTL_VID_SHIFT) |\n \t\t (vf_idx << FM10K_TXQCTL_TC_SHIFT) |\n \t\t FM10K_TXQCTL_VF | vf_idx;\n-\trxqctl = FM10K_RXQCTL_VF | (vf_idx << FM10K_RXQCTL_VF_SHIFT);\n+\trxqctl = (vf_idx << FM10K_RXQCTL_VF_SHIFT) | FM10K_RXQCTL_VF;\n \n \t/* stop further DMA and reset queue ownership back to VF */\n \tfor (i = vf_q_idx; i < (queues_per_pool + vf_q_idx); i++) {\n", "prefixes": [ "next-queue", "1/2" ] }