Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/556534/?format=api
{ "id": 556534, "url": "http://patchwork.ozlabs.org/api/patches/556534/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/alpine.DEB.2.10.1512141558470.2591@hadrien/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<alpine.DEB.2.10.1512141558470.2591@hadrien>", "list_archive_url": null, "date": "2015-12-14T15:00:08", "name": "igb: fix compare_const_fl.cocci warnings", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5a547fdd3b95d8c0b116901c7b78396c1779112b", "submitter": { "id": 10041, "url": "http://patchwork.ozlabs.org/api/people/10041/?format=api", "name": "Julia Lawall", "email": "julia.lawall@lip6.fr" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/alpine.DEB.2.10.1512141558470.2591@hadrien/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/556534/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/556534/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 74ADF14030D\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 15 Dec 2015 02:00:24 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A277A32E4A;\n\tMon, 14 Dec 2015 15:00:23 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wfQ9eJlaeDVs; Mon, 14 Dec 2015 15:00:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 06F7432E4F;\n\tMon, 14 Dec 2015 15:00:20 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id DCB311C101F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Dec 2015 15:00:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D44AA93C62\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Dec 2015 15:00:18 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kn8Cizi0+yfK for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Dec 2015 15:00:17 +0000 (UTC)", "from mail2-relais-roc.national.inria.fr\n\t(mail2-relais-roc.national.inria.fr [192.134.164.83])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id CD380948B1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Dec 2015 15:00:16 +0000 (UTC)", "from vaio-julia.rsr.lip6.fr ([132.227.76.33])\n\tby mail2-relais-roc.national.inria.fr with\n\tESMTP/TLS/DHE-RSA-AES256-SHA; 14 Dec 2015 16:00:12 +0100" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-IronPort-AV": "E=Sophos;i=\"5.20,427,1444687200\"; d=\"scan'208\";a=\"192002132\"", "Date": "Mon, 14 Dec 2015 16:00:08 +0100 (CET)", "From": "Julia Lawall <julia.lawall@lip6.fr>", "X-X-Sender": "jll@hadrien", "To": "Gangfeng Huang <gangfeng.huang@ni.com>", "Message-ID": "<alpine.DEB.2.10.1512141558470.2591@hadrien>", "User-Agent": "Alpine 2.10 (DEB 1266 2009-07-14)", "MIME-Version": "1.0", "Cc": "intel-wired-lan@lists.osuosl.org, kbuild-all@01.org", "Subject": "[Intel-wired-lan] [PATCH] igb: fix compare_const_fl.cocci warnings", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "In both of these cases, it is more common to have the constant on the\nright, in kernel code.\n\nGenerated by: scripts/coccinelle/misc/compare_const_fl.cocci\n\nCC: Gangfeng Huang <gangfeng.huang@ni.com>\nSigned-off-by: Fengguang Wu <fengguang.wu@intel.com>\nSigned-off-by: Julia Lawall <julia.lawall@lip6.fr>\n\n---\n\n igb_main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -8209,7 +8209,7 @@ static int igb_change_mode(struct igb_ad\n \tint err = 0;\n \tint current_mode;\n\n-\tif (NULL == adapter) {\n+\tif (adapter == NULL) {\n \t\tdev_err(&adapter->pdev->dev, \"map to unbound device!\\n\");\n \t\treturn -ENOENT;\n \t}\n@@ -8272,7 +8272,7 @@ static ssize_t igb_set_qav_mode(struct d\n \tif (!capable(CAP_NET_ADMIN))\n \t\treturn -EPERM;\n\n-\tif (0 > kstrtoint(buf, 0, &request_mode))\n+\tif (kstrtoint(buf, 0, &request_mode) < 0)\n \t\treturn -EINVAL;\n\n \tif (request_mode != 0 && request_mode != 1)\n", "prefixes": [] }