Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/555929/?format=api
{ "id": 555929, "url": "http://patchwork.ozlabs.org/api/patches/555929/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449881138-19985-1-git-send-email-mitch.a.williams@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1449881138-19985-1-git-send-email-mitch.a.williams@intel.com>", "list_archive_url": null, "date": "2015-12-12T00:45:38", "name": "[next] igb/igbvf: don't give up", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "868ff9570a3fc5839e19cdc5cfcccf7f24b89864", "submitter": { "id": 967, "url": "http://patchwork.ozlabs.org/api/people/967/?format=api", "name": "Mitch Williams", "email": "mitch.a.williams@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449881138-19985-1-git-send-email-mitch.a.williams@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/555929/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/555929/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 518331402DE\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 12 Dec 2015 11:48:18 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 48CB8A6611;\n\tSat, 12 Dec 2015 00:48:17 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id COos3TrucoLM; Sat, 12 Dec 2015 00:48:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id AD0F6A660E;\n\tSat, 12 Dec 2015 00:48:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 274BA1C10EB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 12 Dec 2015 00:48:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1EEC495E9E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 12 Dec 2015 00:48:15 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mn7AhXukLe8f for <intel-wired-lan@lists.osuosl.org>;\n\tSat, 12 Dec 2015 00:48:14 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 51BA595E84\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 12 Dec 2015 00:48:14 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP; 11 Dec 2015 16:48:02 -0800", "from themachine.jf.intel.com ([10.166.12.154])\n\tby fmsmga004.fm.intel.com with ESMTP; 11 Dec 2015 16:48:02 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,416,1444719600\"; d=\"scan'208\";a=\"11828700\"", "From": "Mitch Williams <mitch.a.williams@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 11 Dec 2015 16:45:38 -0800", "Message-Id": "<1449881138-19985-1-git-send-email-mitch.a.williams@intel.com>", "X-Mailer": "git-send-email 2.5.0", "Subject": "[Intel-wired-lan] [next PATCH] igb/igbvf: don't give up", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The driver shouldn't just give up if it fails to get the hardware\nmailbox lock. This can happen in a situation where the PF-VF\ncommunication channel is heavily loaded and causes complete\ncommunications failure between the PF and VF drivers.\n\nAdd a counter and a delay. The driver will now retry ten times, waiting\none millsecond between retries.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\n---\n drivers/net/ethernet/intel/igb/e1000_mbx.c | 18 ++++++++++++------\n drivers/net/ethernet/intel/igbvf/mbx.c | 20 +++++++++++++-------\n 2 files changed, 25 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/e1000_mbx.c b/drivers/net/ethernet/intel/igb/e1000_mbx.c\nindex 162cc49..10f5c9e 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_mbx.c\n+++ b/drivers/net/ethernet/intel/igb/e1000_mbx.c\n@@ -322,14 +322,20 @@ static s32 igb_obtain_mbx_lock_pf(struct e1000_hw *hw, u16 vf_number)\n {\n \ts32 ret_val = -E1000_ERR_MBX;\n \tu32 p2v_mailbox;\n+\tint count = 10;\n \n-\t/* Take ownership of the buffer */\n-\twr32(E1000_P2VMAILBOX(vf_number), E1000_P2VMAILBOX_PFU);\n+\tdo {\n+\t\t/* Take ownership of the buffer */\n+\t\twr32(E1000_P2VMAILBOX(vf_number), E1000_P2VMAILBOX_PFU);\n \n-\t/* reserve mailbox for vf use */\n-\tp2v_mailbox = rd32(E1000_P2VMAILBOX(vf_number));\n-\tif (p2v_mailbox & E1000_P2VMAILBOX_PFU)\n-\t\tret_val = 0;\n+\t\t/* reserve mailbox for vf use */\n+\t\tp2v_mailbox = rd32(E1000_P2VMAILBOX(vf_number));\n+\t\tif (p2v_mailbox & E1000_P2VMAILBOX_PFU) {\n+\t\t\tret_val = 0;\n+\t\t\tbreak;\n+\t\t}\n+\t\tudelay(1000);\n+\t} while (count-- > 0);\n \n \treturn ret_val;\n }\ndiff --git a/drivers/net/ethernet/intel/igbvf/mbx.c b/drivers/net/ethernet/intel/igbvf/mbx.c\nindex 7b6cb4c..01752f4 100644\n--- a/drivers/net/ethernet/intel/igbvf/mbx.c\n+++ b/drivers/net/ethernet/intel/igbvf/mbx.c\n@@ -234,13 +234,19 @@ static s32 e1000_check_for_rst_vf(struct e1000_hw *hw)\n static s32 e1000_obtain_mbx_lock_vf(struct e1000_hw *hw)\n {\n \ts32 ret_val = -E1000_ERR_MBX;\n-\n-\t/* Take ownership of the buffer */\n-\tew32(V2PMAILBOX(0), E1000_V2PMAILBOX_VFU);\n-\n-\t/* reserve mailbox for VF use */\n-\tif (e1000_read_v2p_mailbox(hw) & E1000_V2PMAILBOX_VFU)\n-\t\tret_val = E1000_SUCCESS;\n+\tint count = 10;\n+\n+\tdo {\n+\t\t/* Take ownership of the buffer */\n+\t\tew32(V2PMAILBOX(0), E1000_V2PMAILBOX_VFU);\n+\n+\t\t/* reserve mailbox for VF use */\n+\t\tif (e1000_read_v2p_mailbox(hw) & E1000_V2PMAILBOX_VFU) {\n+\t\t\tret_val = 0;\n+\t\t\tbreak;\n+\t\t}\n+\t\tudelay(1000);\n+\t} while (count-- > 0);\n \n \treturn ret_val;\n }\n", "prefixes": [ "next" ] }