Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/555774/?format=api
{ "id": 555774, "url": "http://patchwork.ozlabs.org/api/patches/555774/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449842714-10284-1-git-send-email-ptikhomirov@virtuozzo.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1449842714-10284-1-git-send-email-ptikhomirov@virtuozzo.com>", "list_archive_url": null, "date": "2015-12-11T14:05:14", "name": "[v2] ixgbe: on recv increment rx.ring->stats.yields", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d37c3b4960c517d1832cd9f2d1b6bcdfe68eda01", "submitter": { "id": 67861, "url": "http://patchwork.ozlabs.org/api/people/67861/?format=api", "name": "Pavel Tikhomirov", "email": "ptikhomirov@virtuozzo.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449842714-10284-1-git-send-email-ptikhomirov@virtuozzo.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/555774/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/555774/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id EF1201401E7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 12 Dec 2015 01:05:52 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 186CB95BEB;\n\tFri, 11 Dec 2015 14:05:52 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mfvxU9xiRjuf; Fri, 11 Dec 2015 14:05:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6045F95BE4;\n\tFri, 11 Dec 2015 14:05:50 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id BFFFA1BFC09\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Dec 2015 14:05:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B9E83929A7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Dec 2015 14:05:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aMgZcm0FSMHs for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Dec 2015 14:05:48 +0000 (UTC)", "from relay.sw.ru (mailhub.sw.ru [195.214.232.25])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 1C5CE92883\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Dec 2015 14:05:47 +0000 (UTC)", "from dhcp-10-30-28-101.sw.ru ([10.30.16.121])\n\tby relay.sw.ru (8.13.4/8.13.4) with ESMTP id tBBE5evl003072;\n\tFri, 11 Dec 2015 17:05:41 +0300 (MSK)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Pavel Tikhomirov <ptikhomirov@virtuozzo.com>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Fri, 11 Dec 2015 17:05:14 +0300", "Message-Id": "<1449842714-10284-1-git-send-email-ptikhomirov@virtuozzo.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<566AD3F5.9050502@cogentembedded.com>", "References": "<566AD3F5.9050502@cogentembedded.com>", "Cc": "devel@openvz.org", "Subject": "[Intel-wired-lan] [PATCH v2] ixgbe: on recv increment\n\trx.ring->stats.yields", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "It seem to be non intentionaly changed to tx in\ncommit adc810900a70 (\"ixgbe: Refactor busy poll socket code to address\nmultiple issues\")\n\nLock is taken from ixgbe_low_latency_recv, and there under this\nlock we use ixgbe_clean_rx_irq so it looks wrong for me to increment\ntx counter.\n\nYield stats can be shown through ethtool:\nethtool -S enp129s0 | grep yield\n\nv2: follow commit citing style\n\nSigned-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\nindex 1d21745..7656d46 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n@@ -451,7 +451,7 @@ static inline bool ixgbe_qv_lock_poll(struct ixgbe_q_vector *q_vector)\n \t\t\t\tIXGBE_QV_STATE_POLL);\n #ifdef BP_EXTENDED_STATS\n \tif (rc != IXGBE_QV_STATE_IDLE)\n-\t\tq_vector->tx.ring->stats.yields++;\n+\t\tq_vector->rx.ring->stats.yields++;\n #endif\n \treturn rc == IXGBE_QV_STATE_IDLE;\n }\n", "prefixes": [ "v2" ] }