Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/554885/?format=api
{ "id": 554885, "url": "http://patchwork.ozlabs.org/api/patches/554885/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449705033-4968-12-git-send-email-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1449705033-4968-12-git-send-email-joshua.a.hay@intel.com>", "list_archive_url": null, "date": "2015-12-09T23:50:31", "name": "[next,S23,11/13] i40e: Cleanup the code with respect to restarting autoneg", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f872f4ec9fc82fc5fea5c94f5944ae693ca45427", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449705033-4968-12-git-send-email-joshua.a.hay@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/554885/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/554885/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 70122140E3C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 10 Dec 2015 10:50:56 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B676F33083;\n\tWed, 9 Dec 2015 23:50:55 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Fxuge08dyOdG; Wed, 9 Dec 2015 23:50:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0947133356;\n\tWed, 9 Dec 2015 23:50:51 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id E653E1C0F90\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E088492416\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:46 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5jPOzqxeBIXV for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:42 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2ED028D81A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:42 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 09 Dec 2015 15:50:34 -0800", "from jahay1-mobl2.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.79])\n\tby orsmga002.jf.intel.com with ESMTP; 09 Dec 2015 15:50:33 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,405,1444719600\"; d=\"scan'208\";a=\"868414323\"", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 9 Dec 2015 15:50:31 -0800", "Message-Id": "<1449705033-4968-12-git-send-email-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1449705033-4968-1-git-send-email-joshua.a.hay@intel.com>", "References": "<1449705033-4968-1-git-send-email-joshua.a.hay@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S23 11/13] i40e: Cleanup the code\n\twith respect to restarting autoneg", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Anjali Singhai Jain <anjali.singhai@intel.com>\n\nThe restart-autoneg work around does not apply to X722.\nAdded a flag to set it only for the right MAC and right FW version\nwhere the work around should be applied.\n\nSigned-off-by: Anjali Singhai Jain <anjali.singhai@intel.com>\nChange-ID: I942c3ff40cccd1e56f424b1da776b020fe3c9d2a\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 1 +\n drivers/net/ethernet/intel/i40e/i40e_main.c | 12 ++++++++----\n 2 files changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 4747219..bf3776f 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -336,6 +336,7 @@ struct i40e_pf {\n #define I40E_FLAG_VEB_MODE_ENABLED\t\tBIT_ULL(40)\n #define I40E_FLAG_NO_PCI_LINK_CHECK\t\tBIT_ULL(41)\n #define I40E_FLAG_100M_SGMII_CAPABLE\t\tBIT_ULL(42)\n+#define I40E_FLAG_RESTART_AUTONEG\t BIT_ULL(43)\n \n \t/* tracks features that get auto disabled by errors */\n \tu64 auto_disable_flags;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 44bbfd8..747387f 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -6882,8 +6882,7 @@ static void i40e_reset_and_rebuild(struct i40e_pf *pf, bool reinit)\n \t\twr32(hw, I40E_REG_MSS, val);\n \t}\n \n-\tif (((pf->hw.aq.fw_maj_ver == 4) && (pf->hw.aq.fw_min_ver < 33)) ||\n-\t (pf->hw.aq.fw_maj_ver < 4)) {\n+\tif (pf->flags & I40E_FLAG_RESTART_AUTONEG) {\n \t\tmsleep(75);\n \t\tret = i40e_aq_set_link_restart_an(&pf->hw, true, NULL);\n \t\tif (ret)\n@@ -8362,6 +8361,12 @@ static int i40e_sw_init(struct i40e_pf *pf)\n \t\t\t\t pf->hw.func_caps.fd_filters_best_effort;\n \t}\n \n+\tif (((pf->hw.mac.type == I40E_MAC_X710) ||\n+\t (pf->hw.mac.type == I40E_MAC_XL710)) &&\n+\t (((pf->hw.aq.fw_maj_ver == 4) && (pf->hw.aq.fw_min_ver < 33)) ||\n+\t (pf->hw.aq.fw_maj_ver < 4)))\n+\t\tpf->flags |= I40E_FLAG_RESTART_AUTONEG;\n+\n \tif (pf->hw.func_caps.vmdq) {\n \t\tpf->num_vmdq_vsis = I40E_DEFAULT_NUM_VMDQ_VSI;\n \t\tpf->flags |= I40E_FLAG_VMDQ_ENABLED;\n@@ -10791,8 +10796,7 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\twr32(hw, I40E_REG_MSS, val);\n \t}\n \n-\tif (((pf->hw.aq.fw_maj_ver == 4) && (pf->hw.aq.fw_min_ver < 33)) ||\n-\t (pf->hw.aq.fw_maj_ver < 4)) {\n+\tif (pf->flags & I40E_FLAG_RESTART_AUTONEG) {\n \t\tmsleep(75);\n \t\terr = i40e_aq_set_link_restart_an(&pf->hw, true, NULL);\n \t\tif (err)\n", "prefixes": [ "next", "S23", "11/13" ] }