Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/554881/?format=api
{ "id": 554881, "url": "http://patchwork.ozlabs.org/api/patches/554881/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449705033-4968-5-git-send-email-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1449705033-4968-5-git-send-email-joshua.a.hay@intel.com>", "list_archive_url": null, "date": "2015-12-09T23:50:24", "name": "[next,S23,04/13] i40e/i40evf: Fix RSS rx-flow-hash configuration through ethtool", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6a311f8ea8ce70a152b338347e150db8639d2991", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449705033-4968-5-git-send-email-joshua.a.hay@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/554881/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/554881/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 66FC2140E32\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 10 Dec 2015 10:50:52 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2C1C433542;\n\tWed, 9 Dec 2015 23:50:52 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id g1f6ZPsJOOh1; Wed, 9 Dec 2015 23:50:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 097C632A53;\n\tWed, 9 Dec 2015 23:50:50 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0DD021C0FE5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 090AF91BA9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:45 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id sOd6-ScWwky9 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:41 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3CCD98CA1C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:41 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 09 Dec 2015 15:50:33 -0800", "from jahay1-mobl2.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.79])\n\tby orsmga002.jf.intel.com with ESMTP; 09 Dec 2015 15:50:33 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,405,1444719600\"; d=\"scan'208\";a=\"868414313\"", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 9 Dec 2015 15:50:24 -0800", "Message-Id": "<1449705033-4968-5-git-send-email-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1449705033-4968-1-git-send-email-joshua.a.hay@intel.com>", "References": "<1449705033-4968-1-git-send-email-joshua.a.hay@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S23 04/13] i40e/i40evf: Fix RSS\n\trx-flow-hash configuration through ethtool", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Anjali Singhai Jain <anjali.singhai@intel.com>\n\nThis patch fixes the Hash PCTYPE enable for X722 since it supports\na broader selection of PCTYPES for TCP and UDP.\n\nThis patch also fixes a bug in XL710, X710, X722 support for RSS,\nas of now we cannot reduce the (4)tuple for RSS for TCP/IPv4/IPV6 or\nUDP/IPv4/IPv6 packets since this requires a product feature change\nthat comes in a later release.\n\nA VF should never be allowed to change the tuples for RSS for any\nPCTYPE since that's a global setting for the device in case of i40e\ndevices.\n\nSigned-off-by: Anjali Singhai Jain <anjali.singhai@intel.com>\nChange-ID: I0ee7203c9b24813260f58f3220798bc9d9ac4a12\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 14 +++-----\n drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c | 40 +++++-----------------\n 2 files changed, 12 insertions(+), 42 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 29d5833..c8b9dca 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -2166,8 +2166,7 @@ static int i40e_set_rss_hash_opt(struct i40e_pf *pf, struct ethtool_rxnfc *nfc)\n \tcase TCP_V4_FLOW:\n \t\tswitch (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3)) {\n \t\tcase 0:\n-\t\t\thena &= ~BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_TCP);\n-\t\t\tbreak;\n+\t\t\treturn -EINVAL;\n \t\tcase (RXH_L4_B_0_1 | RXH_L4_B_2_3):\n \t\t\thena |= BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_TCP);\n \t\t\tbreak;\n@@ -2178,8 +2177,7 @@ static int i40e_set_rss_hash_opt(struct i40e_pf *pf, struct ethtool_rxnfc *nfc)\n \tcase TCP_V6_FLOW:\n \t\tswitch (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3)) {\n \t\tcase 0:\n-\t\t\thena &= ~BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_TCP);\n-\t\t\tbreak;\n+\t\t\treturn -EINVAL;\n \t\tcase (RXH_L4_B_0_1 | RXH_L4_B_2_3):\n \t\t\thena |= BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_TCP);\n \t\t\tbreak;\n@@ -2190,9 +2188,7 @@ static int i40e_set_rss_hash_opt(struct i40e_pf *pf, struct ethtool_rxnfc *nfc)\n \tcase UDP_V4_FLOW:\n \t\tswitch (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3)) {\n \t\tcase 0:\n-\t\t\thena &= ~(BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_UDP) |\n-\t\t\t\t BIT_ULL(I40E_FILTER_PCTYPE_FRAG_IPV4));\n-\t\t\tbreak;\n+\t\t\treturn -EINVAL;\n \t\tcase (RXH_L4_B_0_1 | RXH_L4_B_2_3):\n \t\t\thena |= (BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_UDP) |\n \t\t\t\t BIT_ULL(I40E_FILTER_PCTYPE_FRAG_IPV4));\n@@ -2204,9 +2200,7 @@ static int i40e_set_rss_hash_opt(struct i40e_pf *pf, struct ethtool_rxnfc *nfc)\n \tcase UDP_V6_FLOW:\n \t\tswitch (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3)) {\n \t\tcase 0:\n-\t\t\thena &= ~(BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_UDP) |\n-\t\t\t\t BIT_ULL(I40E_FILTER_PCTYPE_FRAG_IPV6));\n-\t\t\tbreak;\n+\t\t\treturn -EINVAL;\n \t\tcase (RXH_L4_B_0_1 | RXH_L4_B_2_3):\n \t\t\thena |= (BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_UDP) |\n \t\t\t\t BIT_ULL(I40E_FILTER_PCTYPE_FRAG_IPV6));\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\nindex a4c9feb..8906785 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n@@ -477,54 +477,30 @@ static int i40evf_set_rss_hash_opt(struct i40evf_adapter *adapter,\n \n \tswitch (nfc->flow_type) {\n \tcase TCP_V4_FLOW:\n-\t\tswitch (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3)) {\n-\t\tcase 0:\n-\t\t\thena &= ~BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_TCP);\n-\t\t\tbreak;\n-\t\tcase (RXH_L4_B_0_1 | RXH_L4_B_2_3):\n+\t\tif (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3))\n \t\t\thena |= BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_TCP);\n-\t\t\tbreak;\n-\t\tdefault:\n+\t\telse\n \t\t\treturn -EINVAL;\n-\t\t}\n \t\tbreak;\n \tcase TCP_V6_FLOW:\n-\t\tswitch (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3)) {\n-\t\tcase 0:\n-\t\t\thena &= ~BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_TCP);\n-\t\t\tbreak;\n-\t\tcase (RXH_L4_B_0_1 | RXH_L4_B_2_3):\n+\t\tif (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3))\n \t\t\thena |= BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_TCP);\n-\t\t\tbreak;\n-\t\tdefault:\n+\t\telse\n \t\t\treturn -EINVAL;\n-\t\t}\n \t\tbreak;\n \tcase UDP_V4_FLOW:\n-\t\tswitch (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3)) {\n-\t\tcase 0:\n-\t\t\thena &= ~(BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_UDP) |\n-\t\t\t\t BIT_ULL(I40E_FILTER_PCTYPE_FRAG_IPV4));\n-\t\t\tbreak;\n-\t\tcase (RXH_L4_B_0_1 | RXH_L4_B_2_3):\n+\t\tif (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3)) {\n \t\t\thena |= (BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_UDP) |\n \t\t\t\t BIT_ULL(I40E_FILTER_PCTYPE_FRAG_IPV4));\n-\t\t\tbreak;\n-\t\tdefault:\n+\t\t} else {\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tbreak;\n \tcase UDP_V6_FLOW:\n-\t\tswitch (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3)) {\n-\t\tcase 0:\n-\t\t\thena &= ~(BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_UDP) |\n-\t\t\t\t BIT_ULL(I40E_FILTER_PCTYPE_FRAG_IPV6));\n-\t\t\tbreak;\n-\t\tcase (RXH_L4_B_0_1 | RXH_L4_B_2_3):\n+\t\tif (nfc->data & (RXH_L4_B_0_1 | RXH_L4_B_2_3)) {\n \t\t\thena |= (BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_UDP) |\n \t\t\t\t BIT_ULL(I40E_FILTER_PCTYPE_FRAG_IPV6));\n-\t\t\tbreak;\n-\t\tdefault:\n+\t\t} else {\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tbreak;\n", "prefixes": [ "next", "S23", "04/13" ] }