Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/554878/?format=api
{ "id": 554878, "url": "http://patchwork.ozlabs.org/api/patches/554878/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449705033-4968-8-git-send-email-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1449705033-4968-8-git-send-email-joshua.a.hay@intel.com>", "list_archive_url": null, "date": "2015-12-09T23:50:27", "name": "[next,S23,07/13] i40evf: allow channel bonding of VFs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d9840d70706c665ca5c02df855bb1f5c40d21961", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449705033-4968-8-git-send-email-joshua.a.hay@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/554878/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/554878/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id E06F4140E1E\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 10 Dec 2015 10:50:49 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1ED6D8CA1C;\n\tWed, 9 Dec 2015 23:50:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zZ+6GnTgOmOh; Wed, 9 Dec 2015 23:50:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3890691BA9;\n\tWed, 9 Dec 2015 23:50:45 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id A62871BFA5C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A4B9994CB0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id J6fd05RiAorq for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:42 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id F0E7894BEA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 23:50:41 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 09 Dec 2015 15:50:34 -0800", "from jahay1-mobl2.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.79])\n\tby orsmga002.jf.intel.com with ESMTP; 09 Dec 2015 15:50:33 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,405,1444719600\"; d=\"scan'208\";a=\"868414317\"", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 9 Dec 2015 15:50:27 -0800", "Message-Id": "<1449705033-4968-8-git-send-email-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1449705033-4968-1-git-send-email-joshua.a.hay@intel.com>", "References": "<1449705033-4968-1-git-send-email-joshua.a.hay@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S23 07/13] i40evf: allow channel\n\tbonding of VFs", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nIn some modes, bonding would not enslave VF interfaces. This is due to\nbonding calling change_mtu and the immediately calling open. Because of\nthe asynchronous nature of the admin queue mechanism, the VF returns\n-EBUSY to the open call, because it knows the previous operation hasn't\nfinished yet. This causes bonding to fail with a less-than-useful error\nmessage.\n\nTo fix this, remove the check for pending operations at the beginning of\nopen. But this introduces a new bug where the driver will panic on a\nquick close/open cycle. To fix that, we add a new driver state,\n__I40EVF_DOWN_PENDING, that the driver enters when down is called. The\ndriver finally transitions to a fully DOWN state when it receives\nconfirmation from the PF driver that all the queues are disabled. This\nallows open to complete even if there is a pending mtu change, and\nbonding is finally happy.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: I06f4c7e435d5bacbfceaa7c3f209e0ff04be21cc\n---\n drivers/net/ethernet/intel/i40evf/i40evf.h | 1 +\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 9 +++++----\n drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 2 ++\n 3 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf.h b/drivers/net/ethernet/intel/i40evf/i40evf.h\nindex be1b72b..9e15f68 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf.h\n@@ -173,6 +173,7 @@ enum i40evf_state_t {\n \t__I40EVF_RESETTING,\t\t/* in reset */\n \t/* Below here, watchdog is running */\n \t__I40EVF_DOWN,\t\t\t/* ready, can be opened */\n+\t__I40EVF_DOWN_PENDING,\t\t/* descending, waiting for watchdog */\n \t__I40EVF_TESTING,\t\t/* in ethtool self-test */\n \t__I40EVF_RUNNING,\t\t/* opened, working */\n };\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 455394c..d859045 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1032,7 +1032,7 @@ void i40evf_down(struct i40evf_adapter *adapter)\n \tstruct net_device *netdev = adapter->netdev;\n \tstruct i40evf_mac_filter *f;\n \n-\tif (adapter->state == __I40EVF_DOWN)\n+\tif (adapter->state <= __I40EVF_DOWN_PENDING)\n \t\treturn;\n \n \twhile (test_and_set_bit(__I40EVF_IN_CRITICAL_TASK,\n@@ -2142,7 +2142,8 @@ static int i40evf_open(struct net_device *netdev)\n \t\tdev_err(&adapter->pdev->dev, \"Unable to open device due to PF driver failure.\\n\");\n \t\treturn -EIO;\n \t}\n-\tif (adapter->state != __I40EVF_DOWN || adapter->aq_required)\n+\n+\tif (adapter->state != __I40EVF_DOWN)\n \t\treturn -EBUSY;\n \n \t/* allocate transmit descriptors */\n@@ -2197,14 +2198,14 @@ static int i40evf_close(struct net_device *netdev)\n {\n \tstruct i40evf_adapter *adapter = netdev_priv(netdev);\n \n-\tif (adapter->state <= __I40EVF_DOWN)\n+\tif (adapter->state <= __I40EVF_DOWN_PENDING)\n \t\treturn 0;\n \n \n \tset_bit(__I40E_DOWN, &adapter->vsi.state);\n \n \ti40evf_down(adapter);\n-\tadapter->state = __I40EVF_DOWN;\n+\tadapter->state = __I40EVF_DOWN_PENDING;\n \ti40evf_free_traffic_irqs(adapter);\n \n \treturn 0;\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\nindex c1c5262..d3739cc 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n@@ -804,6 +804,8 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,\n \tcase I40E_VIRTCHNL_OP_DISABLE_QUEUES:\n \t\ti40evf_free_all_tx_resources(adapter);\n \t\ti40evf_free_all_rx_resources(adapter);\n+\t\tif (adapter->state == __I40EVF_DOWN_PENDING)\n+\t\t\tadapter->state = __I40EVF_DOWN;\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_VERSION:\n \tcase I40E_VIRTCHNL_OP_CONFIG_IRQ_MAP:\n", "prefixes": [ "next", "S23", "07/13" ] }