Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/554181/?format=api
{ "id": 554181, "url": "http://patchwork.ozlabs.org/api/patches/554181/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20151209012049.134015.46680.stgit@bwallan-cwp1.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20151209012049.134015.46680.stgit@bwallan-cwp1.jf.intel.com>", "list_archive_url": null, "date": "2015-12-09T01:20:49", "name": "fm10k: IS_ENABLED() is not appropriate for boolean kconfig option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2b5815d491c202ba3d17cf9239ac5e24ca667a1b", "submitter": { "id": 503, "url": "http://patchwork.ozlabs.org/api/people/503/?format=api", "name": "Allan, Bruce W", "email": "bruce.w.allan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20151209012049.134015.46680.stgit@bwallan-cwp1.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/554181/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/554181/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 540F6140281\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 9 Dec 2015 12:20:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A2AD4329A3;\n\tWed, 9 Dec 2015 01:20:52 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VmbLY7K6Kd5y; Wed, 9 Dec 2015 01:20:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id B2B7932FA0;\n\tWed, 9 Dec 2015 01:20:50 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id D18001C0FB4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 01:20:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D4EEA93969\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 01:20:49 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OCPD7BHAhpm2 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 01:20:48 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6838C93934\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Dec 2015 01:20:48 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 08 Dec 2015 17:20:48 -0800", "from bwallan-cwp1.jf.intel.com (HELO bwallan-cwp1)\n\t([10.166.136.47])\n\tby orsmga003.jf.intel.com with ESMTP; 08 Dec 2015 17:20:49 -0800", "from bwallan-cwp1.jf.intel.com (localhost [127.0.0.1])\n\tby bwallan-cwp1 (8.15.2/8.15.1) with ESMTP id tB91KnQ7134050\n\tfor <intel-wired-lan@lists.osuosl.org>; Tue, 8 Dec 2015 17:20:49 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,401,1444719600\"; d=\"scan'208\";a=\"703010397\"", "From": "Bruce Allan <bruce.w.allan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 08 Dec 2015 17:20:49 -0800", "Message-ID": "<20151209012049.134015.46680.stgit@bwallan-cwp1.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] fm10k: IS_ENABLED() is not appropriate\n\tfor boolean kconfig option", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Tri-states need 'if IS_ENABLED()', booleans should use 'ifdef'.\n\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex 55b52bb..8a9bcab 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -20,7 +20,7 @@\n \n #include \"fm10k.h\"\n #include <linux/vmalloc.h>\n-#if IS_ENABLED(CONFIG_FM10K_VXLAN)\n+#ifdef CONFIG_FM10K_VXLAN\n #include <net/vxlan.h>\n #endif /* CONFIG_FM10K_VXLAN */\n \n@@ -556,11 +556,11 @@ int fm10k_open(struct net_device *netdev)\n \tif (err)\n \t\tgoto err_set_queues;\n \n-#if IS_ENABLED(CONFIG_FM10K_VXLAN)\n+#ifdef CONFIG_FM10K_VXLAN\n \t/* update VXLAN port configuration */\n \tvxlan_get_rx_port(netdev);\n-\n #endif\n+\n \tfm10k_up(interface);\n \n \treturn 0;\n", "prefixes": [] }