Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/552225/?format=api
{ "id": 552225, "url": "http://patchwork.ozlabs.org/api/patches/552225/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449145257-110262-1-git-send-email-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1449145257-110262-1-git-send-email-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2015-12-03T12:20:57", "name": "[net-next,v2] i40e: Fix i40e_print_features() VEB mode output", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "13e2effbf89b1d853bf08d441dbc922376f8d7bc", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1449145257-110262-1-git-send-email-jeffrey.t.kirsher@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/552225/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/552225/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 345281402EC\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 3 Dec 2015 23:21:07 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7AEC08AF7E;\n\tThu, 3 Dec 2015 12:21:06 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2IvbVqxKLxJm; Thu, 3 Dec 2015 12:21:05 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7A46E8AF85;\n\tThu, 3 Dec 2015 12:21:05 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id CA65E1C0ED0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 Dec 2015 12:21:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C49F932BFA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 Dec 2015 12:21:02 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DKwc1eA1mGs6 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 Dec 2015 12:21:01 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTP id C4DB132BE2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 Dec 2015 12:21:01 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 03 Dec 2015 04:21:00 -0800", "from jtkirshe-linux.jf.intel.com ([134.134.3.161])\n\tby fmsmga001.fm.intel.com with ESMTP; 03 Dec 2015 04:21:00 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,378,1444719600\"; d=\"scan'208\";a=\"853066774\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 3 Dec 2015 04:20:57 -0800", "Message-Id": "<1449145257-110262-1-git-send-email-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.5.0", "Cc": "Joe Perches <joe@perches.com>, netdev@vger.kernel.org,\n\tsergei.shtylyov@cogentembedded.com", "Subject": "[Intel-wired-lan] [net-next v2] i40e: Fix i40e_print_features() VEB\n\tmode output", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Joe Perches <joe@perches.com>\n\nCommit 7fd89545f337 (\"i40e: remove BUG_ON from feature string building\")\nadded defective output when I40E_FLAG_VEB_MODE_ENABLED was set in\nfunction i40e_print_features.\n\nFix it.\n\nMiscellanea:\n\n- Remove unnecessary string variable\n- Add space before not after fixed strings\n- Use kmalloc not kzalloc\n- Don't initialize i to 0, use result of first snprintf\n\nReported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>\nSigned-off-by: Joe Perches <joe@perches.com>\n---\nv2: fixed patch conflicts when trying to apply to my next-queue tree\n (dev-queue branch), also fixed \"Noticed-by\" to the more acceptable\n \"Reported-by\"\n\n drivers/net/ethernet/intel/i40e/i40e_main.c | 42 +++++++++++++----------------\n 1 file changed, 19 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 70a61bc..ad8cc14 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -10369,52 +10369,48 @@ static int i40e_setup_pf_filter_control(struct i40e_pf *pf)\n static void i40e_print_features(struct i40e_pf *pf)\n {\n \tstruct i40e_hw *hw = &pf->hw;\n-\tchar *buf, *string;\n-\tint i = 0;\n+\tchar *buf;\n+\tint i;\n \n-\tstring = kzalloc(INFO_STRING_LEN, GFP_KERNEL);\n-\tif (!string) {\n-\t\tdev_err(&pf->pdev->dev, \"Features string allocation failed\\n\");\n+\tbuf = kmalloc(INFO_STRING_LEN, GFP_KERNEL);\n+\tif (!buf)\n \t\treturn;\n-\t}\n-\n-\tbuf = string;\n \n-\ti += snprintf(&buf[i], REMAIN(i), \"Features: PF-id[%d] \", hw->pf_id);\n+\ti = snprintf(buf, INFO_STRING_LEN, \"Features: PF-id[%d]\", hw->pf_id);\n #ifdef CONFIG_PCI_IOV\n-\ti += snprintf(&buf[i], REMAIN(i), \"VFs: %d \", pf->num_req_vfs);\n+\ti += snprintf(&buf[i], REMAIN(i), \" VFs: %d\", pf->num_req_vfs);\n #endif\n-\ti += snprintf(&buf[i], REMAIN(i), \"VSIs: %d QP: %d RX: %s \",\n+\ti += snprintf(&buf[i], REMAIN(i), \" VSIs: %d QP: %d RX: %s\",\n \t\t pf->hw.func_caps.num_vsis,\n \t\t pf->vsi[pf->lan_vsi]->num_queue_pairs,\n \t\t pf->flags & I40E_FLAG_RX_PS_ENABLED ? \"PS\" : \"1BUF\");\n \n \tif (pf->flags & I40E_FLAG_RSS_ENABLED)\n-\t\ti += snprintf(&buf[i], REMAIN(i), \"RSS \");\n+\t\ti += snprintf(&buf[i], REMAIN(i), \" RSS\");\n \tif (pf->flags & I40E_FLAG_FD_ATR_ENABLED)\n-\t\ti += snprintf(&buf[i], REMAIN(i), \"FD_ATR \");\n+\t\ti += snprintf(&buf[i], REMAIN(i), \" FD_ATR\");\n \tif (pf->flags & I40E_FLAG_FD_SB_ENABLED) {\n-\t\ti += snprintf(&buf[i], REMAIN(i), \"FD_SB \");\n-\t\ti += snprintf(&buf[i], REMAIN(i), \"NTUPLE \");\n+\t\ti += snprintf(&buf[i], REMAIN(i), \" FD_SB\");\n+\t\ti += snprintf(&buf[i], REMAIN(i), \" NTUPLE\");\n \t}\n \tif (pf->flags & I40E_FLAG_DCB_CAPABLE)\n-\t\ti += snprintf(&buf[i], REMAIN(i), \"DCB \");\n+\t\ti += snprintf(&buf[i], REMAIN(i), \" DCB\");\n #if IS_ENABLED(CONFIG_VXLAN)\n-\ti += snprintf(&buf[i], REMAIN(i), \"VxLAN \");\n+\ti += snprintf(&buf[i], REMAIN(i), \" VxLAN\");\n #endif\n \tif (pf->flags & I40E_FLAG_PTP)\n-\t\ti += snprintf(&buf[i], REMAIN(i), \"PTP \");\n+\t\ti += snprintf(&buf[i], REMAIN(i), \" PTP\");\n #ifdef I40E_FCOE\n \tif (pf->flags & I40E_FLAG_FCOE_ENABLED)\n-\t\ti += snprintf(&buf[i], REMAIN(i), \"FCOE \");\n+\t\ti += snprintf(&buf[i], REMAIN(i), \" FCOE\");\n #endif\n \tif (pf->flags & I40E_FLAG_VEB_MODE_ENABLED)\n-\t\ti += snprintf(&buf[i], REMAIN(i), \"VEPA \");\n+\t\ti += snprintf(&buf[i], REMAIN(i), \" VEB\");\n \telse\n-\t\tbuf += sprintf(buf, \"VEPA \");\n+\t\ti += snprintf(&buf[i], REMAIN(i), \" VEPA\");\n \n-\tdev_info(&pf->pdev->dev, \"%s\\n\", string);\n-\tkfree(string);\n+\tdev_info(&pf->pdev->dev, \"%s\\n\", buf);\n+\tkfree(buf);\n \tWARN_ON(i > INFO_STRING_LEN);\n }\n \n", "prefixes": [ "net-next", "v2" ] }