Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/547/?format=api
{ "id": 547, "url": "http://patchwork.ozlabs.org/api/patches/547/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080918194419.GA2982@ami.dom.local/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20080918194419.GA2982@ami.dom.local>", "list_archive_url": null, "date": "2008-09-18T19:44:19", "name": "[RFC PATCH] sched: only dequeue if packet can be queued to hardware queue.", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "9c72ab674b578a2b23485c162f5d7888614b029f", "submitter": { "id": 277, "url": "http://patchwork.ozlabs.org/api/people/277/?format=api", "name": "Jarek Poplawski", "email": "jarkao2@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080918194419.GA2982@ami.dom.local/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/547/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/547/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 045E8DDE26\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 19 Sep 2008 05:43:17 +1000 (EST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755035AbYIRTnL (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 18 Sep 2008 15:43:11 -0400", "(majordomo@vger.kernel.org) by vger.kernel.org id S1754946AbYIRTnL\n\t(ORCPT <rfc822; netdev-outgoing>); Thu, 18 Sep 2008 15:43:11 -0400", "from fk-out-0910.google.com ([209.85.128.187]:36903 \"EHLO\n\tfk-out-0910.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754288AbYIRTnK (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 18 Sep 2008 15:43:10 -0400", "by fk-out-0910.google.com with SMTP id 18so54229fkq.5\n\tfor <netdev@vger.kernel.org>; Thu, 18 Sep 2008 12:43:08 -0700 (PDT)", "by 10.180.234.2 with SMTP id g2mr2206420bkh.54.1221766988039;\n\tThu, 18 Sep 2008 12:43:08 -0700 (PDT)", "from ami.dom.local ( [83.27.4.19]) by mx.google.com with ESMTPS id\n\tc28sm18996229fka.18.2008.09.18.12.43.04\n\t(version=SSLv3 cipher=RC4-MD5);\n\tThu, 18 Sep 2008 12:43:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\n\th=domainkey-signature:received:received:date:from:to:cc:subject\n\t:message-id:mime-version:content-type:content-disposition\n\t:in-reply-to:user-agent;\n\tbh=RleCE9xAxnpuoDTg6uwMwWfl9akp8ZYeYA3Csni+OZ4=;\n\tb=WQjRRQ45Wb0KwYqHWqcNjtdKoLAdZsjuNEJQdeK7NrVAv31oa90ae4bHeOExM5UI6S\n\t4f5h5yY/sR2M+9tmi5ihrxfioL0PDAVa6KquRjob5RhOx9yH1R76jcL761v5pkdlhHZ6\n\tu9Emk5X7JVbDrWGRVBciNgo/AszNIyUByFDjs=", "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\n\th=date:from:to:cc:subject:message-id:mime-version:content-type\n\t:content-disposition:in-reply-to:user-agent;\n\tb=IWwR+MvVr4kQH5a2Fhu26ATRFoO2gtkNuGu++xwA2s5SteZZNV/N2XIhFOGZxLu+P0\n\tjnBsjMbckiApz5K0wd8BQSWHc9pXi1g1QMvnN/Th+ENKWrbqGpHmoC5xMqd3Djrfz/Dl\n\tCwyTS1C/VvOARPMtvSL9GG4Xhjvw/m73H4sNY=", "Date": "Thu, 18 Sep 2008 21:44:19 +0200", "From": "Jarek Poplawski <jarkao2@gmail.com>", "To": "Alexander Duyck <alexander.h.duyck@intel.com>", "Cc": "netdev@vger.kernel.org, herbert@gondor.apana.org.au,\n\tdavem@davemloft.net, kaber@trash.net", "Subject": "Re: [RFC PATCH] sched: only dequeue if packet can be queued to\n\thardware queue.", "Message-ID": "<20080918194419.GA2982@ami.dom.local>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20080918063036.27934.91273.stgit@localhost.localdomain>", "User-Agent": "Mutt/1.5.18 (2008-05-17)", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Alexander Duyck wrote, On 09/18/2008 08:43 AM:\n...\n> ---\n> This patch changes the behavior of the sch->dequeue to only\n> dequeue a packet if the queue it is bound for is not currently\n> stopped. This functionality is provided via a new op called\n> smart_dequeue.\n> \n> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n> ---\n\nI think, these changes make sense only if they don't add more then give,\nand two dequeues (and still no way to kill requeue) is IMHO too much.\n(I mean the maintenance.) As far as I can see it's mainly for HFSC's\nqdisc_peek_len(), anyway this looks like main issue to me.\n\nBelow a few small doubts. (I need to find some time for details yet.)\nBTW, this patch needs a checkpatch run.", "diff": "diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h\nindex b786a5b..4082f39 100644\n--- a/include/net/pkt_sched.h\n+++ b/include/net/pkt_sched.h\n@@ -90,10 +90,7 @@ extern void __qdisc_run(struct Qdisc *q);\n \n static inline void qdisc_run(struct Qdisc *q)\n {\n-\tstruct netdev_queue *txq = q->dev_queue;\n-\n-\tif (!netif_tx_queue_stopped(txq) &&\n\nI think, there is no reason to do a full dequeue try each time instead\nof this check, even if we save on requeuing now. We could try to save\nthe result of the last dequeue, e.g. a number or some mask of a few\n", "prefixes": [ "RFC" ] }