Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/546650/?format=api
{ "id": 546650, "url": "http://patchwork.ozlabs.org/api/patches/546650/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1447961665-12344-11-git-send-email-deepthi.kavalur@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1447961665-12344-11-git-send-email-deepthi.kavalur@intel.com>", "list_archive_url": null, "date": "2015-11-19T19:34:23", "name": "[V3:,next,S22,10/12] i40e: clean whole mac filter list", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "18dfae8a2f977a80a3cf1c3dfcfed065a2308cdb", "submitter": { "id": 67654, "url": "http://patchwork.ozlabs.org/api/people/67654/?format=api", "name": "Deepthi Kavalur", "email": "deepthi.kavalur@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1447961665-12344-11-git-send-email-deepthi.kavalur@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/546650/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/546650/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 5601C1414C0\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 20 Nov 2015 06:34:37 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9B6CD88C80;\n\tThu, 19 Nov 2015 19:34:36 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 705uHh5Y9JUK; Thu, 19 Nov 2015 19:34:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 598D08C2AC;\n\tThu, 19 Nov 2015 19:34:29 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1ACDF1C1641\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:28 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 16337842D4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:28 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id C68Yq1oZzneA for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:27 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6EDBF82E12\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:27 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga101.jf.intel.com with ESMTP; 19 Nov 2015 11:34:27 -0800", "from dkavalur-mobl.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.88])\n\tby fmsmga001.fm.intel.com with ESMTP; 19 Nov 2015 11:34:26 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,318,1444719600\"; d=\"scan'208\";a=\"842678129\"", "From": "Deepthi Kavalur <deepthi.kavalur@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 19 Nov 2015 11:34:23 -0800", "Message-Id": "<1447961665-12344-11-git-send-email-deepthi.kavalur@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1447961665-12344-1-git-send-email-deepthi.kavalur@intel.com>", "References": "<1447961665-12344-1-git-send-email-deepthi.kavalur@intel.com>", "Subject": "[Intel-wired-lan] [V3: next PATCH S22 10/12] i40e: clean whole mac\n\tfilter list", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nClean the whole mac filter list when resetting after an intermediate\nadd or delete push to the firmware. The code had evolved from using\na list from the stack to a heap allocation, but the memset() didn't\nfollow the change correctly. This now cleans the whole list rather\nthat just part of the first element.\n\nReported-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nChange-ID: I4cd03d5a103b7407dd8556a3a231e800f2d6f2d5\n---\nTesting Hints :\nCompile and run the driver with basic ping tests. Also add and remove\nadditional address filters and make sure they work as expected.\n\n drivers/net/ethernet/intel/i40e/i40e_main.c | 18 ++++++++++--------\n 1 file changed, 10 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex c03bb72..c22167b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1917,11 +1917,12 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi, bool grab_rtnl)\n \n \t/* Now process 'del_list' outside the lock */\n \tif (!list_empty(&tmp_del_list)) {\n+\t\tint del_list_size;\n \t\tfilter_list_len = pf->hw.aq.asq_buf_size /\n \t\t\t sizeof(struct i40e_aqc_remove_macvlan_element_data);\n-\t\tdel_list = kcalloc(filter_list_len,\n-\t\t\t sizeof(struct i40e_aqc_remove_macvlan_element_data),\n-\t\t\t GFP_KERNEL);\n+\t\tdel_list_size = filter_list_len *\n+\t\t\t sizeof(struct i40e_aqc_remove_macvlan_element_data);\n+\t\tdel_list = kzalloc(del_list_size, GFP_KERNEL);\n \t\tif (!del_list) {\n \t\t\ti40e_cleanup_add_list(&tmp_add_list);\n \n@@ -1956,7 +1957,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi, bool grab_rtnl)\n \t\t\t\t\t\t\t\tNULL);\n \t\t\t\taq_err = pf->hw.aq.asq_last_status;\n \t\t\t\tnum_del = 0;\n-\t\t\t\tmemset(del_list, 0, sizeof(*del_list));\n+\t\t\t\tmemset(del_list, 0, del_list_size);\n \n \t\t\t\tif (aq_ret && aq_err != I40E_AQ_RC_ENOENT) {\n \t\t\t\t\tretval = -EIO;\n@@ -1992,13 +1993,14 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi, bool grab_rtnl)\n \t}\n \n \tif (!list_empty(&tmp_add_list)) {\n+\t\tint add_list_size;\n \n \t\t/* do all the adds now */\n \t\tfilter_list_len = pf->hw.aq.asq_buf_size /\n \t\t\t sizeof(struct i40e_aqc_add_macvlan_element_data),\n-\t\tadd_list = kcalloc(filter_list_len,\n-\t\t\t sizeof(struct i40e_aqc_add_macvlan_element_data),\n-\t\t\t GFP_KERNEL);\n+\t\tadd_list_size = filter_list_len *\n+\t\t\t sizeof(struct i40e_aqc_add_macvlan_element_data);\n+\t\tadd_list = kzalloc(add_list_size, GFP_KERNEL);\n \t\tif (!add_list) {\n \t\t\t/* Purge element from temporary lists */\n \t\t\ti40e_cleanup_add_list(&tmp_add_list);\n@@ -2037,7 +2039,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi, bool grab_rtnl)\n \n \t\t\t\tif (aq_ret)\n \t\t\t\t\tbreak;\n-\t\t\t\tmemset(add_list, 0, sizeof(*add_list));\n+\t\t\t\tmemset(add_list, 0, add_list_size);\n \t\t\t}\n \t\t\t/* Entries from tmp_add_list were cloned from MAC\n \t\t\t * filter list, hence clean those cloned entries\n", "prefixes": [ "V3:", "next", "S22", "10/12" ] }