Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/546643/?format=api
{ "id": 546643, "url": "http://patchwork.ozlabs.org/api/patches/546643/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1447961665-12344-2-git-send-email-deepthi.kavalur@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1447961665-12344-2-git-send-email-deepthi.kavalur@intel.com>", "list_archive_url": null, "date": "2015-11-19T19:34:14", "name": "[V3:,next,S22,01/12] i40e: chomp the BIT(_ULL)", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d89c8d943af0082b55f77d8f03d0a80c31fc77d1", "submitter": { "id": 67654, "url": "http://patchwork.ozlabs.org/api/people/67654/?format=api", "name": "Deepthi Kavalur", "email": "deepthi.kavalur@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1447961665-12344-2-git-send-email-deepthi.kavalur@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/546643/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/546643/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 1BF241414BE\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 20 Nov 2015 06:34:31 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D57D08C2C1;\n\tThu, 19 Nov 2015 19:34:30 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bxIQRQf4eMnG; Thu, 19 Nov 2015 19:34:29 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BE7D989756;\n\tThu, 19 Nov 2015 19:34:28 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 576B01C1641\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5473A94554\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:27 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vRabMytdt3KC for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:26 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A987194C2A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:26 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP; 19 Nov 2015 11:34:27 -0800", "from dkavalur-mobl.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.88])\n\tby fmsmga001.fm.intel.com with ESMTP; 19 Nov 2015 11:34:25 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,318,1444719600\"; d=\"scan'208\";a=\"842678094\"", "From": "Deepthi Kavalur <deepthi.kavalur@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 19 Nov 2015 11:34:14 -0800", "Message-Id": "<1447961665-12344-2-git-send-email-deepthi.kavalur@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1447961665-12344-1-git-send-email-deepthi.kavalur@intel.com>", "References": "<1447961665-12344-1-git-send-email-deepthi.kavalur@intel.com>", "Subject": "[Intel-wired-lan] [V3: next PATCH S22 01/12] i40e: chomp the\n\tBIT(_ULL)", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nBIT_ULL was used on a u32 or less where it can simply be BIT. This\nfixes some trivial static analyzer warnings. Chomp, chomp.\n\nTested with objdump of binary before and after, no changes to code.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nChange-ID: I6245e9abd447192dbde1669c747aeb2878126c7d\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 30 ++++++++++++++---------------\n 1 file changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex c59d146..925654d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1531,7 +1531,7 @@ static void i40e_vsi_setup_queue_map(struct i40e_vsi *vsi,\n \tif (enabled_tc && (vsi->back->flags & I40E_FLAG_DCB_ENABLED)) {\n \t\t/* Find numtc from enabled TC bitmap */\n \t\tfor (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {\n-\t\t\tif (enabled_tc & BIT_ULL(i)) /* TC is enabled */\n+\t\t\tif (enabled_tc & BIT(i)) /* TC is enabled */\n \t\t\t\tnumtc++;\n \t\t}\n \t\tif (!numtc) {\n@@ -1560,7 +1560,7 @@ static void i40e_vsi_setup_queue_map(struct i40e_vsi *vsi,\n \t/* Setup queue offset/count for all TCs for given VSI */\n \tfor (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {\n \t\t/* See if the given TC is enabled for the given VSI */\n-\t\tif (vsi->tc_config.enabled_tc & BIT_ULL(i)) {\n+\t\tif (vsi->tc_config.enabled_tc & BIT(i)) {\n \t\t\t/* TC is enabled */\n \t\t\tint pow, num_qps;\n \n@@ -4433,7 +4433,7 @@ static u8 i40e_get_iscsi_tc_map(struct i40e_pf *pf)\n \t\tif (app.selector == I40E_APP_SEL_TCPIP &&\n \t\t app.protocolid == I40E_APP_PROTOID_ISCSI) {\n \t\t\ttc = dcbcfg->etscfg.prioritytable[app.priority];\n-\t\t\tenabled_tc |= BIT_ULL(tc);\n+\t\t\tenabled_tc |= BIT(tc);\n \t\t\tbreak;\n \t\t}\n \t}\n@@ -4517,7 +4517,7 @@ static u8 i40e_pf_get_num_tc(struct i40e_pf *pf)\n \t/* At least have TC0 */\n \tenabled_tc = (enabled_tc ? enabled_tc : 0x1);\n \tfor (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {\n-\t\tif (enabled_tc & BIT_ULL(i))\n+\t\tif (enabled_tc & BIT(i))\n \t\t\tnum_tc++;\n \t}\n \treturn num_tc;\n@@ -4539,7 +4539,7 @@ static u8 i40e_pf_get_default_tc(struct i40e_pf *pf)\n \n \t/* Find the first enabled TC */\n \tfor (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {\n-\t\tif (enabled_tc & BIT_ULL(i))\n+\t\tif (enabled_tc & BIT(i))\n \t\t\tbreak;\n \t}\n \n@@ -4699,7 +4699,7 @@ static void i40e_vsi_config_netdev_tc(struct i40e_vsi *vsi, u8 enabled_tc)\n \t\t * will set the numtc for netdev as 2 that will be\n \t\t * referenced by the netdev layer as TC 0 and 1.\n \t\t */\n-\t\tif (vsi->tc_config.enabled_tc & BIT_ULL(i))\n+\t\tif (vsi->tc_config.enabled_tc & BIT(i))\n \t\t\tnetdev_set_tc_queue(netdev,\n \t\t\t\t\tvsi->tc_config.tc_info[i].netdev_tc,\n \t\t\t\t\tvsi->tc_config.tc_info[i].qcount,\n@@ -4761,7 +4761,7 @@ static int i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 enabled_tc)\n \n \t/* Enable ETS TCs with equal BW Share for now across all VSIs */\n \tfor (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {\n-\t\tif (enabled_tc & BIT_ULL(i))\n+\t\tif (enabled_tc & BIT(i))\n \t\t\tbw_share[i] = 1;\n \t}\n \n@@ -4835,7 +4835,7 @@ int i40e_veb_config_tc(struct i40e_veb *veb, u8 enabled_tc)\n \n \t/* Enable ETS TCs with equal BW Share for now */\n \tfor (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {\n-\t\tif (enabled_tc & BIT_ULL(i))\n+\t\tif (enabled_tc & BIT(i))\n \t\t\tbw_data.tc_bw_share_credits[i] = 1;\n \t}\n \n@@ -5232,7 +5232,7 @@ static int i40e_setup_tc(struct net_device *netdev, u8 tc)\n \n \t/* Generate TC map for number of tc requested */\n \tfor (i = 0; i < tc; i++)\n-\t\tenabled_tc |= BIT_ULL(i);\n+\t\tenabled_tc |= BIT(i);\n \n \t/* Requesting same TC configuration as already enabled */\n \tif (enabled_tc == vsi->tc_config.enabled_tc)\n@@ -6096,23 +6096,23 @@ static void i40e_reset_subtask(struct i40e_pf *pf)\n \n \trtnl_lock();\n \tif (test_bit(__I40E_REINIT_REQUESTED, &pf->state)) {\n-\t\treset_flags |= BIT_ULL(__I40E_REINIT_REQUESTED);\n+\t\treset_flags |= BIT(__I40E_REINIT_REQUESTED);\n \t\tclear_bit(__I40E_REINIT_REQUESTED, &pf->state);\n \t}\n \tif (test_bit(__I40E_PF_RESET_REQUESTED, &pf->state)) {\n-\t\treset_flags |= BIT_ULL(__I40E_PF_RESET_REQUESTED);\n+\t\treset_flags |= BIT(__I40E_PF_RESET_REQUESTED);\n \t\tclear_bit(__I40E_PF_RESET_REQUESTED, &pf->state);\n \t}\n \tif (test_bit(__I40E_CORE_RESET_REQUESTED, &pf->state)) {\n-\t\treset_flags |= BIT_ULL(__I40E_CORE_RESET_REQUESTED);\n+\t\treset_flags |= BIT(__I40E_CORE_RESET_REQUESTED);\n \t\tclear_bit(__I40E_CORE_RESET_REQUESTED, &pf->state);\n \t}\n \tif (test_bit(__I40E_GLOBAL_RESET_REQUESTED, &pf->state)) {\n-\t\treset_flags |= BIT_ULL(__I40E_GLOBAL_RESET_REQUESTED);\n+\t\treset_flags |= BIT(__I40E_GLOBAL_RESET_REQUESTED);\n \t\tclear_bit(__I40E_GLOBAL_RESET_REQUESTED, &pf->state);\n \t}\n \tif (test_bit(__I40E_DOWN_REQUESTED, &pf->state)) {\n-\t\treset_flags |= BIT_ULL(__I40E_DOWN_REQUESTED);\n+\t\treset_flags |= BIT(__I40E_DOWN_REQUESTED);\n \t\tclear_bit(__I40E_DOWN_REQUESTED, &pf->state);\n \t}\n \n@@ -10571,7 +10571,7 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \n \t/* NVM bit on means WoL disabled for the port */\n \ti40e_read_nvm_word(hw, I40E_SR_NVM_WAKE_ON_LAN, &wol_nvm_bits);\n-\tif ((1 << hw->port) & wol_nvm_bits || hw->partition_id != 1)\n+\tif (BIT (hw->port) & wol_nvm_bits || hw->partition_id != 1)\n \t\tpf->wol_en = false;\n \telse\n \t\tpf->wol_en = true;\n", "prefixes": [ "V3:", "next", "S22", "01/12" ] }