Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/546642/?format=api
{ "id": 546642, "url": "http://patchwork.ozlabs.org/api/patches/546642/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1447961665-12344-5-git-send-email-deepthi.kavalur@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1447961665-12344-5-git-send-email-deepthi.kavalur@intel.com>", "list_archive_url": null, "date": "2015-11-19T19:34:17", "name": "[V3:,next,S22,04/12] i40e: don't add zero MAC filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9064b6f105a4c8f7290125114a6d6925d47258f2", "submitter": { "id": 67654, "url": "http://patchwork.ozlabs.org/api/people/67654/?format=api", "name": "Deepthi Kavalur", "email": "deepthi.kavalur@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1447961665-12344-5-git-send-email-deepthi.kavalur@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/546642/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/546642/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 7402F1414BF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 20 Nov 2015 06:34:30 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7E7C88C2BB;\n\tThu, 19 Nov 2015 19:34:29 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1Y-8Avuuz9Ix; Thu, 19 Nov 2015 19:34:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 947FE88C80;\n\tThu, 19 Nov 2015 19:34:28 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3A7AE1CF3E5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 378B894554\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:27 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9mpMoy1dELJR for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:26 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D2E3794C3D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Nov 2015 19:34:26 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP; 19 Nov 2015 11:34:28 -0800", "from dkavalur-mobl.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.88])\n\tby fmsmga001.fm.intel.com with ESMTP; 19 Nov 2015 11:34:26 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,318,1444719600\"; d=\"scan'208\";a=\"842678107\"", "From": "Deepthi Kavalur <deepthi.kavalur@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 19 Nov 2015 11:34:17 -0800", "Message-Id": "<1447961665-12344-5-git-send-email-deepthi.kavalur@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1447961665-12344-1-git-send-email-deepthi.kavalur@intel.com>", "References": "<1447961665-12344-1-git-send-email-deepthi.kavalur@intel.com>", "Subject": "[Intel-wired-lan] [V3: next PATCH S22 04/12] i40e: don't add zero\n\tMAC filter", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nWhen VFs are created, the MAC address defaults to all zeros, indicating\nto the VF driver that it should use a random MAC address. However, the\nPF driver was incorrectly adding this zero MAC to the filter table,\nalong with the VF's randomly generated MAC address.\n\nCheck for a good address before adding the default filter. While we're\nat it, make the error message a bit more useful.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: Ia100947d68140e0f73a19ba755cbffc3e79a8fcf\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex c04e3b7..b6be4a5 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -549,12 +549,15 @@ static int i40e_alloc_vsi_res(struct i40e_vf *vf, enum i40e_vsi_type type)\n \t\t\ti40e_vsi_add_pvid(vsi, vf->port_vlan_id);\n \n \t\tspin_lock_bh(&vsi->mac_filter_list_lock);\n-\t\tf = i40e_add_filter(vsi, vf->default_lan_addr.addr,\n-\t\t\t\t vf->port_vlan_id ? vf->port_vlan_id : -1,\n-\t\t\t\t true, false);\n-\t\tif (!f)\n-\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t \"Could not allocate VF MAC addr\\n\");\n+\t\tif (is_valid_ether_addr(vf->default_lan_addr.addr)) {\n+\t\t\tf = i40e_add_filter(vsi, vf->default_lan_addr.addr,\n+\t\t\t\t vf->port_vlan_id ? vf->port_vlan_id : -1,\n+\t\t\t\t true, false);\n+\t\t\tif (!f)\n+\t\t\t\tdev_info(&pf->pdev->dev,\n+\t\t\t\t\t \"Could not add MAC filter %pM for VF %d\\n\",\n+\t\t\t\t\tvf->default_lan_addr.addr, vf->vf_id);\n+\t\t}\n \t\tf = i40e_add_filter(vsi, brdcast,\n \t\t\t\t vf->port_vlan_id ? vf->port_vlan_id : -1,\n \t\t\t\t true, false);\n", "prefixes": [ "V3:", "next", "S22", "04/12" ] }