Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/545268/?format=api
{ "id": 545268, "url": "http://patchwork.ozlabs.org/api/patches/545268/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1447716814-4908-1-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1447716814-4908-1-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2015-11-16T23:33:34", "name": "[v2] fm10k: use ether_addr_equal instead of memcmp", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7b0e191a442a8a42ada2f95f941ae4f321900391", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1447716814-4908-1-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/545268/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/545268/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 3A991141482\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 17 Nov 2015 10:34:02 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 804312F083;\n\tMon, 16 Nov 2015 23:34:01 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id cIoZq7ChXE1K; Mon, 16 Nov 2015 23:34:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8866423A2D;\n\tMon, 16 Nov 2015 23:34:00 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 814341C1744\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 Nov 2015 23:33:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7B25886854\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 Nov 2015 23:33:59 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PZmS6HBEsGCu for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 Nov 2015 23:33:58 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D07CB868E6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 Nov 2015 23:33:58 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 16 Nov 2015 15:33:36 -0800", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.123])\n\tby orsmga002.jf.intel.com with ESMTP; 16 Nov 2015 15:33:36 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,304,1444719600\"; d=\"scan'208\";a=\"852255500\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 16 Nov 2015 15:33:34 -0800", "Message-Id": "<1447716814-4908-1-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.6.3.491.g3e3f6ce", "Subject": "[Intel-wired-lan] [PATCH v2] fm10k: use ether_addr_equal instead of\n\tmemcmp", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When comparing MAC addresses, use ether_addr_equal instead of memcmp to\nETH_ALEN length. Found and replaced using the following sed:\n\n sed -e 's/memcmp\\x28\\(.*\\), ETH_ALEN\\x29/!ether_addr_equal\\x28\\1\\x29/'\n\nReported-by: Bruce Allan <bruce.w.allan@intel.com>\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n\nNotes:\n\n This replaces the version on the queue inline and corrects issues\n with all 4 tests that were replaced. It should fix the mailbox\n ethtool test among other possible issues.\n\n - v2\n * correct sed expression and fix mis-use of ether_addr_equal\n\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 +-\n drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 2 +-\n drivers/net/ethernet/intel/fm10k/fm10k_tlv.c | 2 +-\n drivers/net/ethernet/intel/fm10k/fm10k_vf.c | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 15d8e10c2504..5a13e74db0e5 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -1164,7 +1164,7 @@ static s32 fm10k_mbx_mac_addr(struct fm10k_hw *hw, u32 **results,\n \n \t/* MAC was changed so we need reset */\n \tif (is_valid_ether_addr(hw->mac.perm_addr) &&\n-\t memcmp(hw->mac.perm_addr, hw->mac.addr, ETH_ALEN))\n+\t !ether_addr_equal(hw->mac.perm_addr, hw->mac.addr))\n \t\tinterface->flags |= FM10K_FLAG_RESET_REQUESTED;\n \n \t/* VLAN override was changed, or default VLAN changed */\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\nindex bbf0b4aef241..b83e23ba23a4 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n@@ -1249,7 +1249,7 @@ s32 fm10k_iov_msg_mac_vlan_pf(struct fm10k_hw *hw, u32 **results,\n \n \t\t/* block attempts to set MAC for a locked device */\n \t\tif (is_valid_ether_addr(vf_info->mac) &&\n-\t\t memcmp(mac, vf_info->mac, ETH_ALEN))\n+\t\t !ether_addr_equal(mac, vf_info->mac))\n \t\t\treturn FM10K_ERR_PARAM;\n \n \t\tset = !(vlan & FM10K_VLAN_CLEAR);\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c b/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c\nindex 9b29d7b0377a..ae255234d8f4 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c\n@@ -755,7 +755,7 @@ s32 fm10k_tlv_msg_test(struct fm10k_hw *hw, u32 **results,\n \t\terr = fm10k_tlv_attr_get_mac_vlan(\n \t\t\t\t\tresults[FM10K_TEST_MSG_MAC_ADDR],\n \t\t\t\t\tresult_mac, &result_vlan);\n-\t\tif (!err && memcmp(test_mac, result_mac, ETH_ALEN))\n+\t\tif (!err && !ether_addr_equal(test_mac, result_mac))\n \t\t\terr = FM10K_ERR_INVALID_VALUE;\n \t\tif (!err && test_vlan != result_vlan)\n \t\t\terr = FM10K_ERR_INVALID_VALUE;\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_vf.c b/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\nindex 2af697df5abc..bde7f01b3380 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\n@@ -298,7 +298,7 @@ static s32 fm10k_update_uc_addr_vf(struct fm10k_hw *hw, u16 glort,\n \n \t/* verify we are not locked down on the MAC address */\n \tif (is_valid_ether_addr(hw->mac.perm_addr) &&\n-\t memcmp(hw->mac.perm_addr, mac, ETH_ALEN))\n+\t !ether_addr_equal(hw->mac.perm_addr, mac))\n \t\treturn FM10K_ERR_PARAM;\n \n \t/* add bit to notify us if this is a set or clear operation */\n", "prefixes": [ "v2" ] }