Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/542007/?format=api
{ "id": 542007, "url": "http://patchwork.ozlabs.org/api/patches/542007/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1447106648-5591-1-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1447106648-5591-1-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2015-11-09T22:04:08", "name": "[next-queue,v3] fm10k: correctly pack TLV structures and explain reasoning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "29d1317fc79035490e6d8b333efc6c084e56fd49", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1447106648-5591-1-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/542007/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/542007/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id E97711413B9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 10 Nov 2015 09:04:13 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2AF7B881AD;\n\tMon, 9 Nov 2015 22:04:13 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NKh4Q03qh4Li; Mon, 9 Nov 2015 22:04:12 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9749888141;\n\tMon, 9 Nov 2015 22:04:12 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 58C3B1C1000\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 9 Nov 2015 22:04:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5031030B4F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 9 Nov 2015 22:04:11 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id av3Xy6740bLk for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 9 Nov 2015 22:04:10 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTP id 80A0E2635D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 9 Nov 2015 22:04:10 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 09 Nov 2015 14:04:10 -0800", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.123])\n\tby FMSMGA003.fm.intel.com with ESMTP; 09 Nov 2015 14:04:10 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,267,1444719600\"; d=\"scan'208\";a=\"597153168\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 9 Nov 2015 14:04:08 -0800", "Message-Id": "<1447106648-5591-1-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.6.1.264.gbab76a9", "Subject": "[Intel-wired-lan] [next-queue PATCH v3] fm10k: correctly pack TLV\n\tstructures and explain reasoning", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The TLV format for little endian structures is actually 4 byte aligned\ncopy. To this end, we need to add an additional __aligned(4) marker\nalong with __packed to ensure that these structures are actually 4 byte\naligned and packed correctly. Use of just __packed will not work as this\nwill result in 1byte alignment which is incorrect. Add a comment\nexplaining the reasoning behind why these structures need the special\ntreatment.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n- v3\n* use __aligned(4) instead of __attribute__(aligned(4))\n\nNote: this patch replaces both TLV patches currently on the queue as it\nlooks like Jeff had forgotten to remove the earlier one when the subject\nchanged.\n\n drivers/net/ethernet/intel/fm10k/fm10k_pf.h | 13 +++++++++----\n 1 file changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.h b/drivers/net/ethernet/intel/fm10k/fm10k_pf.h\nindex a8fc512a2416..337859260b9b 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.h\n@@ -74,6 +74,11 @@ enum fm10k_pf_tlv_attr_id_v1 {\n #define FM10K_MSG_UPDATE_PVID_PVID_SHIFT\t16\n #define FM10K_MSG_UPDATE_PVID_PVID_SIZE\t\t16\n \n+/* The following data structures are overlayed directly onto TLV mailbox\n+ * messages, and must not break 4 byte alignment. Ensure the structures line\n+ * up correctly as per their TLV definition.\n+ */\n+\n struct fm10k_mac_update {\n \t__le32\tmac_lower;\n \t__le16\tmac_upper;\n@@ -81,26 +86,26 @@ struct fm10k_mac_update {\n \t__le16\tglort;\n \tu8\tflags;\n \tu8\taction;\n-} __packed;\n+} __aligned(4) __packed;\n \n struct fm10k_global_table_data {\n \t__le32\tused;\n \t__le32\tavail;\n-} __packed;\n+} __aligned(4) __packed;\n \n struct fm10k_swapi_error {\n \t__le32\t\t\t\tstatus;\n \tstruct fm10k_global_table_data\tmac;\n \tstruct fm10k_global_table_data\tnexthop;\n \tstruct fm10k_global_table_data\tffu;\n-} __packed;\n+} __aligned(4) __packed;\n \n struct fm10k_swapi_1588_timestamp {\n \t__le64 egress;\n \t__le64 ingress;\n \t__le16 dglort;\n \t__le16 sglort;\n-} __packed;\n+} __aligned(4) __packed;\n \n s32 fm10k_msg_lport_map_pf(struct fm10k_hw *, u32 **, struct fm10k_mbx_info *);\n extern const struct fm10k_tlv_attr fm10k_lport_map_msg_attr[];\n", "prefixes": [ "next-queue", "v3" ] }