Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/540781/?format=api
{ "id": 540781, "url": "http://patchwork.ozlabs.org/api/patches/540781/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1446771662-36705-1-git-send-email-jesse.brandeburg@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1446771662-36705-1-git-send-email-jesse.brandeburg@intel.com>", "list_archive_url": null, "date": "2015-11-06T01:01:01", "name": "[next,1/2] i40e: fix: do not sleep in netdev_ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "92b7ace8586f550b3119e6b4a5a3a1a508bbb352", "submitter": { "id": 189, "url": "http://patchwork.ozlabs.org/api/people/189/?format=api", "name": "Jesse Brandeburg", "email": "jesse.brandeburg@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1446771662-36705-1-git-send-email-jesse.brandeburg@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/540781/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/540781/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 2910A1402BC\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 6 Nov 2015 12:02:55 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E93BC32F99;\n\tFri, 6 Nov 2015 01:02:53 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HFs2I72qPNcb; Fri, 6 Nov 2015 01:02:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1BD4226410;\n\tFri, 6 Nov 2015 01:02:53 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id CC1761BFC15\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Nov 2015 01:02:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C525626E07\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Nov 2015 01:02:51 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6Bss4pcPujEi for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Nov 2015 01:02:51 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTP id EFC4A26410\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Nov 2015 01:02:50 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga103.fm.intel.com with ESMTP; 05 Nov 2015 17:02:33 -0800", "from jbrandeb-hsm2.jf.intel.com ([134.134.3.178])\n\tby orsmga001.jf.intel.com with ESMTP; 05 Nov 2015 17:02:33 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,249,1444719600\"; d=\"scan'208\";a=\"812914474\"", "From": "Jesse Brandeburg <jesse.brandeburg@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 5 Nov 2015 17:01:01 -0800", "Message-Id": "<1446771662-36705-1-git-send-email-jesse.brandeburg@intel.com>", "X-Mailer": "git-send-email 2.1.0", "Subject": "[Intel-wired-lan] [next PATCH 1/2] i40e: fix: do not sleep in\n\tnetdev_ops", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The driver was being called by vlan, bonding, teaming operations\nthat expected to be able to hold locks like rcu_read_lock().\n\nThis causes the driver to be held to the requirement to not sleep,\nand was found by the kernel debug options for checking sleep\ninside critical section, and the locking validator.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nChange-ID: Ibc68c835f5ffa8ffe0638ffe910a66fc5649a7f7\n\n---\n\nTesting Hints (required if no HSD): add and remove vlan, over and under\nbonding and teaming driver, add and delete mac address, run debug kernel\nwith lock validator.\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 44 +++++++++++++----------------\n 1 file changed, 20 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 7759703..3119ee4 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1552,9 +1552,11 @@ static int i40e_set_mac(struct net_device *netdev, void *p)\n \t\tspin_unlock_bh(&vsi->mac_filter_list_lock);\n \t}\n \n-\ti40e_sync_vsi_filters(vsi, false);\n \tether_addr_copy(netdev->dev_addr, addr->sa_data);\n-\n+\t/* schedule our worker thread which will take care of\n+\t * applying the new filter changes\n+\t */\n+\ti40e_service_event_schedule(vsi->back);\n \treturn 0;\n }\n \n@@ -2118,12 +2120,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi, bool grab_rtnl)\n \t\t\t */\n \t\t\tif (pf->cur_promisc != cur_promisc) {\n \t\t\t\tpf->cur_promisc = cur_promisc;\n-\t\t\t\tif (grab_rtnl)\n-\t\t\t\t\ti40e_do_reset_safe(pf,\n-\t\t\t\t\t\tBIT(__I40E_PF_RESET_REQUESTED));\n-\t\t\t\telse\n-\t\t\t\t\ti40e_do_reset(pf,\n-\t\t\t\t\t\tBIT(__I40E_PF_RESET_REQUESTED));\n+\t\t\t\tset_bit(__I40E_PF_RESET_REQUESTED, &pf->state);\n \t\t\t}\n \t\t} else {\n \t\t\tret = i40e_aq_set_vsi_unicast_promiscuous(\n@@ -2383,16 +2380,13 @@ int i40e_vsi_add_vlan(struct i40e_vsi *vsi, s16 vid)\n \t\t}\n \t}\n \n-\t/* Make sure to release before sync_vsi_filter because that\n-\t * function will lock/unlock as necessary\n-\t */\n \tspin_unlock_bh(&vsi->mac_filter_list_lock);\n \n-\tif (test_bit(__I40E_DOWN, &vsi->back->state) ||\n-\t test_bit(__I40E_RESET_RECOVERY_PENDING, &vsi->back->state))\n-\t\treturn 0;\n-\n-\treturn i40e_sync_vsi_filters(vsi, false);\n+\t/* schedule our worker thread which will take care of\n+\t * applying the new filter changes\n+\t */\n+\ti40e_service_event_schedule(vsi->back);\n+\treturn 0;\n }\n \n /**\n@@ -2465,16 +2459,13 @@ int i40e_vsi_kill_vlan(struct i40e_vsi *vsi, s16 vid)\n \t\t}\n \t}\n \n-\t/* Make sure to release before sync_vsi_filter because that\n-\t * function with lock/unlock as necessary\n-\t */\n \tspin_unlock_bh(&vsi->mac_filter_list_lock);\n \n-\tif (test_bit(__I40E_DOWN, &vsi->back->state) ||\n-\t test_bit(__I40E_RESET_RECOVERY_PENDING, &vsi->back->state))\n-\t\treturn 0;\n-\n-\treturn i40e_sync_vsi_filters(vsi, false);\n+\t/* schedule our worker thread which will take care of\n+\t * applying the new filter changes\n+\t */\n+\ti40e_service_event_schedule(vsi->back);\n+\treturn 0;\n }\n \n /**\n@@ -2717,6 +2708,11 @@ static void i40e_config_xps_tx_ring(struct i40e_ring *ring)\n \t\tnetif_set_xps_queue(ring->netdev, mask, ring->queue_index);\n \t\tfree_cpumask_var(mask);\n \t}\n+\n+\t/* schedule our worker thread which will take care of\n+\t * applying the new filter changes\n+\t */\n+\ti40e_service_event_schedule(vsi->back);\n }\n \n /**\n", "prefixes": [ "next", "1/2" ] }