Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/540135/?format=api
{ "id": 540135, "url": "http://patchwork.ozlabs.org/api/patches/540135/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1064069608.305775.1446575838742.JavaMail.zimbra@xes-inc.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1064069608.305775.1446575838742.JavaMail.zimbra@xes-inc.com>", "list_archive_url": null, "date": "2015-11-03T18:37:18", "name": "[2/5] igb: Don't add PHY address to PCDL address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7b99df519c7bb1aca64c09917d6b724af134825a", "submitter": { "id": 10211, "url": "http://patchwork.ozlabs.org/api/people/10211/?format=api", "name": "Aaron Sierra", "email": "asierra@xes-inc.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1064069608.305775.1446575838742.JavaMail.zimbra@xes-inc.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/540135/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/540135/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 36E281413DB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 5 Nov 2015 05:59:29 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 85121939A5;\n\tWed, 4 Nov 2015 18:59:28 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Kk8Ed8WbPvRM; Wed, 4 Nov 2015 18:59:26 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4E88A9396E;\n\tWed, 4 Nov 2015 18:59:26 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 23E5C1C15DE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Nov 2015 19:34:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1F61F84317\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Nov 2015 19:34:25 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EjLHbjYVUDMC for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Nov 2015 19:34:23 +0000 (UTC)", "from xes-mad.com (xes-mad.com [216.165.139.218])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 9D631841A0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Nov 2015 19:34:23 +0000 (UTC)", "from zimbra.xes-mad.com (zimbra.xes-mad.com [10.52.0.127])\n\tby xes-mad.com (8.13.8/8.13.8) with ESMTP id tA3IbJCG028489;\n\tTue, 3 Nov 2015 12:37:19 -0600" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:57:11 by SQLgrey-1.7.6", "Date": "Tue, 3 Nov 2015 12:37:18 -0600 (CST)", "From": "Aaron Sierra <asierra@xes-inc.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org", "Message-ID": "<1064069608.305775.1446575838742.JavaMail.zimbra@xes-inc.com>", "In-Reply-To": "<197584129.304313.1446575155971.JavaMail.zimbra@xes-inc.com>", "MIME-Version": "1.0", "X-Originating-IP": "[10.52.16.65]", "X-Mailer": "Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF40 (Linux)/8.0.6_GA_5922)", "Thread-Topic": "Don't add PHY address to PCDL address", "Thread-Index": "UFb7Wia29HfE9p6n5tv+UpK/qY4ExQ==", "X-Mailman-Approved-At": "Wed, 04 Nov 2015 18:59:25 +0000", "Cc": "Joe Schultz <jschultz@xes-inc.com>", "Subject": "[Intel-wired-lan] [PATCH 2/5] igb: Don't add PHY address to PCDL\n\taddress", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "There is no reason to add the PHY address into the PCDL register address.\n\nSigned-off-by: Aaron Sierra <asierra@xes-inc.com>\n---\n drivers/net/ethernet/intel/igb/e1000_phy.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c\nindex ec1aea5..407d44a 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_phy.c\n+++ b/drivers/net/ethernet/intel/igb/e1000_phy.c\n@@ -1734,8 +1734,7 @@ s32 igb_get_cable_length_m88_gen2(struct e1000_hw *hw)\n \t\t\tgoto out;\n \n \t\t/* Get cable length from PHY Cable Diagnostics Control Reg */\n-\t\tret_val = phy->ops.read_reg(hw, (I347AT4_PCDL + phy->addr),\n-\t\t\t\t\t &phy_data);\n+\t\tret_val = phy->ops.read_reg(hw, I347AT4_PCDL, &phy_data);\n \t\tif (ret_val)\n \t\t\tgoto out;\n \n", "prefixes": [ "2/5" ] }