Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/537614/?format=api
{ "id": 537614, "url": "http://patchwork.ozlabs.org/api/patches/537614/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20151029001951.19165.58910.stgit@bwallan-cwp1.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20151029001951.19165.58910.stgit@bwallan-cwp1.jf.intel.com>", "list_archive_url": null, "date": "2015-10-29T00:19:51", "name": "[next-queue,v2] fm10k: cleanup namespace pollution", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c0212c75431b5467cf9793f683afdee31659ab18", "submitter": { "id": 503, "url": "http://patchwork.ozlabs.org/api/people/503/?format=api", "name": "Allan, Bruce W", "email": "bruce.w.allan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20151029001951.19165.58910.stgit@bwallan-cwp1.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/537614/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/537614/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id CCCA1140D7C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 29 Oct 2015 11:20:06 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 261698B1FA;\n\tThu, 29 Oct 2015 00:20:06 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jNUdRDajyKIh; Thu, 29 Oct 2015 00:20:05 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7BFB189628;\n\tThu, 29 Oct 2015 00:20:05 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id AC2281C44C4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Oct 2015 00:20:04 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A5D512F6A3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Oct 2015 00:20:04 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8h5JCk6Mso2Q for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Oct 2015 00:20:02 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby silver.osuosl.org (Postfix) with ESMTP id 24B832EC2E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Oct 2015 00:20:02 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP; 28 Oct 2015 17:20:01 -0700", "from bwallan-cwp1.jf.intel.com (HELO bwallan-cwp1)\n\t([10.166.140.23])\n\tby orsmga003.jf.intel.com with ESMTP; 28 Oct 2015 17:19:51 -0700", "from bwallan-cwp1.jf.intel.com (localhost [127.0.0.1])\n\tby bwallan-cwp1 (8.15.2/8.15.1) with ESMTP id t9T0JpmL019222\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 28 Oct 2015 17:19:51 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,212,1444719600\"; d=\"scan'208\";a=\"673930990\"", "From": "Bruce Allan <bruce.w.allan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 28 Oct 2015 17:19:51 -0700", "Message-ID": "<20151029001951.19165.58910.stgit@bwallan-cwp1.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next-queue PATCH v2] fm10k: cleanup namespace\n\tpollution", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Make functions that should be static. While we're at it, fix the function\nheader comment for fm10k_tlv_attr_nest_stop(), and update the copyright\nheader for fm10k_pf.h, fm10k_tlv.c and fm10k_tlv.h.\n\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 4 ++--\n drivers/net/ethernet/intel/fm10k/fm10k_pf.h | 4 +---\n drivers/net/ethernet/intel/fm10k/fm10k_tlv.c | 18 +++++++++---------\n drivers/net/ethernet/intel/fm10k/fm10k_tlv.h | 7 +------\n 4 files changed, 13 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\nindex 888ab8d..0183254 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n@@ -1688,8 +1688,8 @@ const struct fm10k_tlv_attr fm10k_update_pvid_msg_attr[] = {\n *\n * This handler configures the default VLAN for the PF\n **/\n-s32 fm10k_msg_update_pvid_pf(struct fm10k_hw *hw, u32 **results,\n-\t\t\t struct fm10k_mbx_info *mbx)\n+static s32 fm10k_msg_update_pvid_pf(struct fm10k_hw *hw, u32 **results,\n+\t\t\t\t struct fm10k_mbx_info *mbx)\n {\n \tu16 glort, pvid;\n \tu32 pvid_update;\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.h b/drivers/net/ethernet/intel/fm10k/fm10k_pf.h\nindex 9d77daa..a8fc512 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.h\n@@ -1,5 +1,5 @@\n /* Intel Ethernet Switch Host Interface Driver\n- * Copyright(c) 2013 - 2014 Intel Corporation.\n+ * Copyright(c) 2013 - 2015 Intel Corporation.\n *\n * This program is free software; you can redistribute it and/or modify it\n * under the terms and conditions of the GNU General Public License,\n@@ -107,8 +107,6 @@ extern const struct fm10k_tlv_attr fm10k_lport_map_msg_attr[];\n #define FM10K_PF_MSG_LPORT_MAP_HANDLER(func) \\\n \tFM10K_MSG_HANDLER(FM10K_PF_MSG_ID_LPORT_MAP, \\\n \t\t\t fm10k_lport_map_msg_attr, func)\n-s32 fm10k_msg_update_pvid_pf(struct fm10k_hw *, u32 **,\n-\t\t\t struct fm10k_mbx_info *);\n extern const struct fm10k_tlv_attr fm10k_update_pvid_msg_attr[];\n #define FM10K_PF_MSG_UPDATE_PVID_HANDLER(func) \\\n \tFM10K_MSG_HANDLER(FM10K_PF_MSG_ID_UPDATE_PVID, \\\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c b/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c\nindex d6ff1e8d..80f5c4b 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c\n@@ -1,5 +1,5 @@\n /* Intel Ethernet Switch Host Interface Driver\n- * Copyright(c) 2013 - 2014 Intel Corporation.\n+ * Copyright(c) 2013 - 2015 Intel Corporation.\n *\n * This program is free software; you can redistribute it and/or modify it\n * under the terms and conditions of the GNU General Public License,\n@@ -48,8 +48,8 @@ s32 fm10k_tlv_msg_init(u32 *msg, u16 msg_id)\n * the attribute buffer. It will return success if provided with a valid\n * pointers.\n **/\n-s32 fm10k_tlv_attr_put_null_string(u32 *msg, u16 attr_id,\n-\t\t\t\t const unsigned char *string)\n+static s32 fm10k_tlv_attr_put_null_string(u32 *msg, u16 attr_id,\n+\t\t\t\t\t const unsigned char *string)\n {\n \tu32 attr_data = 0, len = 0;\n \tu32 *attr;\n@@ -98,7 +98,7 @@ s32 fm10k_tlv_attr_put_null_string(u32 *msg, u16 attr_id,\n * it in the array pointed by by string. It will return success if provided\n * with a valid pointers.\n **/\n-s32 fm10k_tlv_attr_get_null_string(u32 *attr, unsigned char *string)\n+static s32 fm10k_tlv_attr_get_null_string(u32 *attr, unsigned char *string)\n {\n \tu32 len;\n \n@@ -353,7 +353,7 @@ s32 fm10k_tlv_attr_get_le_struct(u32 *attr, void *le_struct, u32 len)\n * function will return NULL on failure, and a pointer to the start\n * of the nested attributes on success.\n **/\n-u32 *fm10k_tlv_attr_nest_start(u32 *msg, u16 attr_id)\n+static u32 *fm10k_tlv_attr_nest_start(u32 *msg, u16 attr_id)\n {\n \tu32 *attr;\n \n@@ -370,7 +370,7 @@ u32 *fm10k_tlv_attr_nest_start(u32 *msg, u16 attr_id)\n }\n \n /**\n- * fm10k_tlv_attr_nest_start - Start a set of nested attributes\n+ * fm10k_tlv_attr_nest_stop - Stop a set of nested attributes\n * @msg: Pointer to message block\n *\n * This function closes off an existing set of nested attributes. The\n@@ -378,7 +378,7 @@ u32 *fm10k_tlv_attr_nest_start(u32 *msg, u16 attr_id)\n * the case of a nest within the nest this would be the outer nest pointer.\n * This function will return success provided all pointers are valid.\n **/\n-s32 fm10k_tlv_attr_nest_stop(u32 *msg)\n+static s32 fm10k_tlv_attr_nest_stop(u32 *msg)\n {\n \tu32 *attr;\n \tu32 len;\n@@ -483,8 +483,8 @@ static s32 fm10k_tlv_attr_validate(u32 *attr,\n * FM10K_NOT_IMPLEMENTED for any attribute that is outside of the array\n * and 0 on success.\n **/\n-s32 fm10k_tlv_attr_parse(u32 *attr, u32 **results,\n-\t\t\t const struct fm10k_tlv_attr *tlv_attr)\n+static s32 fm10k_tlv_attr_parse(u32 *attr, u32 **results,\n+\t\t\t\tconst struct fm10k_tlv_attr *tlv_attr)\n {\n \tu32 i, attr_id, offset = 0;\n \ts32 err = 0;\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_tlv.h b/drivers/net/ethernet/intel/fm10k/fm10k_tlv.h\nindex 7e045e8..d5ad359 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_tlv.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_tlv.h\n@@ -1,5 +1,5 @@\n /* Intel Ethernet Switch Host Interface Driver\n- * Copyright(c) 2013 - 2014 Intel Corporation.\n+ * Copyright(c) 2013 - 2015 Intel Corporation.\n *\n * This program is free software; you can redistribute it and/or modify it\n * under the terms and conditions of the GNU General Public License,\n@@ -106,8 +106,6 @@ struct fm10k_msg_data {\n #define FM10K_MSG_HANDLER(id, attr, func) { id, attr, func }\n \n s32 fm10k_tlv_msg_init(u32 *, u16);\n-s32 fm10k_tlv_attr_put_null_string(u32 *, u16, const unsigned char *);\n-s32 fm10k_tlv_attr_get_null_string(u32 *, unsigned char *);\n s32 fm10k_tlv_attr_put_mac_vlan(u32 *, u16, const u8 *, u16);\n s32 fm10k_tlv_attr_get_mac_vlan(u32 *, u8 *, u16 *);\n s32 fm10k_tlv_attr_put_bool(u32 *, u16);\n@@ -147,9 +145,6 @@ s32 fm10k_tlv_attr_get_value(u32 *, void *, u32);\n \t\tfm10k_tlv_attr_get_value(attr, ptr, sizeof(s64))\n s32 fm10k_tlv_attr_put_le_struct(u32 *, u16, const void *, u32);\n s32 fm10k_tlv_attr_get_le_struct(u32 *, void *, u32);\n-u32 *fm10k_tlv_attr_nest_start(u32 *, u16);\n-s32 fm10k_tlv_attr_nest_stop(u32 *);\n-s32 fm10k_tlv_attr_parse(u32 *, u32 **, const struct fm10k_tlv_attr *);\n s32 fm10k_tlv_msg_parse(struct fm10k_hw *, u32 *, struct fm10k_mbx_info *,\n \t\t\tconst struct fm10k_msg_data *);\n s32 fm10k_tlv_msg_error(struct fm10k_hw *hw, u32 **results,\n", "prefixes": [ "next-queue", "v2" ] }