Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/537144/?format=api
{ "id": 537144, "url": "http://patchwork.ozlabs.org/api/patches/537144/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20151027235931.30048.548.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20151027235931.30048.548.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2015-10-27T23:59:31", "name": "[next,4/5] e1000e: Switch e1000e_up to void, drop code checking for error result", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7bdc3b18da6a0078237a0d9a73ee3f48b60e636d", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20151027235931.30048.548.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/537144/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/537144/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 5625B1402B3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 28 Oct 2015 10:59:38 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 89BDA87BDE;\n\tTue, 27 Oct 2015 23:59:37 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8lEQr8BwtPnD; Tue, 27 Oct 2015 23:59:35 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 34E7B87A4B;\n\tTue, 27 Oct 2015 23:59:35 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7B18A1C0FD1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Oct 2015 23:59:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 756D532E22\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Oct 2015 23:59:33 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id o2-zL-GVv0p6 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Oct 2015 23:59:32 +0000 (UTC)", "from mail-pa0-f50.google.com (mail-pa0-f50.google.com\n\t[209.85.220.50])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C52C02EFD0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Oct 2015 23:59:32 +0000 (UTC)", "by pasz6 with SMTP id z6so236689641pas.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Oct 2015 16:59:32 -0700 (PDT)", "from localhost.localdomain\n\t(static-50-53-21-5.bvtn.or.frontiernet.net. [50.53.21.5])\n\tby smtp.gmail.com with ESMTPSA id\n\tb6sm41657391pbu.90.2015.10.27.16.59.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 27 Oct 2015 16:59:31 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=BflwfWMx; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-type:content-transfer-encoding;\n\tbh=yZX+4GjOGIfVhp8efRstLJywHAs1bFRpolCntC9dpUs=;\n\tb=BflwfWMxq8eglWCKrmHMB0xnGCsdaxuKRxrK6uo3My+l/hSdTPOOiPxGh5DefXl888\n\tn+2KiSRc0fFeMwSwst04ma/ieZFcZmtbgJO1icyceOvbUVjv3Un4swVXdzYbuHe0pX1+\n\tt6T1B3IiUvtL3dNIkJ08ZqeFpTHhqd1eMSb+U=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-type\n\t:content-transfer-encoding;\n\tbh=yZX+4GjOGIfVhp8efRstLJywHAs1bFRpolCntC9dpUs=;\n\tb=YdLswHDIWJLJ4xWCrtSG9vtMgbQWtFr916QWDKvhyBr8l14XDbOq+L5RtOeOZBRD6s\n\tcDVV63Ytqv61vctBRGtE021HRDeDoIbOkL5h7Myn70DwuD3nwA6ZIdUpm9L2rlDAUQ6D\n\txgDm2gSgLx2czbwyhMh+yJZe6zr6qx6F48vOC0468UCifB+o69dzw8AGQODedxB9EEeq\n\tkIRdXckUoYcN3WesDYj049b6WLBs0pPDbIlCL34pJ3DX5vusZB+3sBNsdZpzO1bj+IU3\n\tg1IXbzJMOUNQBfQoa5eb6Srib6ryipKoikpQAcdDvfRmWe52QPxbORZ2Piujhbwz3zNx\n\tUNYQ==", "X-Gm-Message-State": "ALoCoQle2cG7uO07gcb85REqrZKwPjjvoimRF9FYI6phS0t1id/j+l20f57FPkASX1VXyYTZjQyy", "X-Received": "by 10.67.12.166 with SMTP id er6mr49695199pad.40.1445990372186; \n\tTue, 27 Oct 2015 16:59:32 -0700 (PDT)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 27 Oct 2015 16:59:31 -0700", "Message-ID": "<20151027235931.30048.548.stgit@localhost.localdomain>", "In-Reply-To": "<20151027235341.30048.46286.stgit@localhost.localdomain>", "References": "<20151027235341.30048.46286.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH 4/5] e1000e: Switch e1000e_up to void,\n\tdrop code checking for error result", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The function e1000e_up always returns 0. As such we can convert it to a\nvoid and just ignore the results. This allows us to drop some code in a\ncouple spots as we no longer need to worry about non-zero return values.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/e1000e/e1000.h | 2 +-\n drivers/net/ethernet/intel/e1000e/netdev.c | 15 ++++-----------\n 2 files changed, 5 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h b/drivers/net/ethernet/intel/e1000e/e1000.h\nindex 0b748d1959d9..1dc293bad87b 100644\n--- a/drivers/net/ethernet/intel/e1000e/e1000.h\n+++ b/drivers/net/ethernet/intel/e1000e/e1000.h\n@@ -480,7 +480,7 @@ extern const char e1000e_driver_version[];\n void e1000e_check_options(struct e1000_adapter *adapter);\n void e1000e_set_ethtool_ops(struct net_device *netdev);\n \n-int e1000e_up(struct e1000_adapter *adapter);\n+void e1000e_up(struct e1000_adapter *adapter);\n void e1000e_down(struct e1000_adapter *adapter, bool reset);\n void e1000e_reinit_locked(struct e1000_adapter *adapter);\n void e1000e_reset(struct e1000_adapter *adapter);\ndiff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 7a10bb0a83f4..4ed69fee8549 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -4143,7 +4143,7 @@ void e1000e_reset(struct e1000_adapter *adapter)\n \n }\n \n-int e1000e_up(struct e1000_adapter *adapter)\n+void e1000e_up(struct e1000_adapter *adapter)\n {\n \tstruct e1000_hw *hw = &adapter->hw;\n \n@@ -4163,8 +4163,6 @@ int e1000e_up(struct e1000_adapter *adapter)\n \t\tew32(ICS, E1000_ICS_LSC | E1000_ICR_OTHER);\n \telse\n \t\tew32(ICS, E1000_ICS_LSC);\n-\n-\treturn 0;\n }\n \n static void e1000e_flush_descriptors(struct e1000_adapter *adapter)\n@@ -6643,7 +6641,7 @@ static int e1000e_pm_runtime_resume(struct device *dev)\n \t\treturn rc;\n \n \tif (netdev->flags & IFF_UP)\n-\t\trc = e1000e_up(adapter);\n+\t\te1000e_up(adapter);\n \n \treturn rc;\n }\n@@ -6834,13 +6832,8 @@ static void e1000_io_resume(struct pci_dev *pdev)\n \n \te1000_init_manageability_pt(adapter);\n \n-\tif (netif_running(netdev)) {\n-\t\tif (e1000e_up(adapter)) {\n-\t\t\tdev_err(&pdev->dev,\n-\t\t\t\t\"can't bring device back up after reset\\n\");\n-\t\t\treturn;\n-\t\t}\n-\t}\n+\tif (netif_running(netdev))\n+\t\te1000e_up(adapter);\n \n \tnetif_device_attach(netdev);\n \n", "prefixes": [ "next", "4/5" ] }