Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/537142/?format=api
{ "id": 537142, "url": "http://patchwork.ozlabs.org/api/patches/537142/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20151027235918.30048.41769.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20151027235918.30048.41769.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2015-10-27T23:59:18", "name": "[next,2/5] fm10k: Cleanup exception handling for mailbox interrupt", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4ff2b12c211964a1232ad776f7c283433d0bc8df", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20151027235918.30048.41769.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/537142/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/537142/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 470D8140D8E\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 28 Oct 2015 10:59:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5E24787D0B;\n\tTue, 27 Oct 2015 23:59:22 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qcw66o7-3sOk; Tue, 27 Oct 2015 23:59:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A3E2A87A4B;\n\tTue, 27 Oct 2015 23:59:21 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 806ED1C0FD1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Oct 2015 23:59:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7CB2985102\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Oct 2015 23:59:20 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lTw2o9igSqvl for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Oct 2015 23:59:20 +0000 (UTC)", "from mail-pa0-f51.google.com (mail-pa0-f51.google.com\n\t[209.85.220.51])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 154FD85778\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Oct 2015 23:59:20 +0000 (UTC)", "by pabla5 with SMTP id la5so43832261pab.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Oct 2015 16:59:19 -0700 (PDT)", "from localhost.localdomain\n\t(static-50-53-21-5.bvtn.or.frontiernet.net. [50.53.21.5])\n\tby smtp.gmail.com with ESMTPSA id\n\tix1sm41689468pbd.40.2015.10.27.16.59.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 27 Oct 2015 16:59:19 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=inwolCCL; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-type:content-transfer-encoding;\n\tbh=c8Q+r72fk5rPffEo1xJT/FWg9JO3v8NIEsVmqzJ20VE=;\n\tb=inwolCCL7qgJm4fBIxbCqKMnKniOVAq0SBEPS8cn4qV1hkESxks08xHVpAWZBirNIk\n\t4FZt7BUsbYXpYINTufhNMHXZ/Lz1OZwhVBBzsThCbb0K5PUdtZTTTzBMO5bXkaiZYO5M\n\tJlS5qXjUXm4E1wqJMLz8WkhyKREvjdZQ/iCRg=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-type\n\t:content-transfer-encoding;\n\tbh=c8Q+r72fk5rPffEo1xJT/FWg9JO3v8NIEsVmqzJ20VE=;\n\tb=UVXNjbiAo0HiizgM/2NyMJG0yFE+8N0b8j1HIU3ZK8t+gLv5lClTypW4H7Kew/TclN\n\t8w0FOTIWSgq0PHtAAToNUAkqgGZLXoLSLE8cJ1ODuxHbZka+3a4FPdlhgJHfyHZFD3fh\n\tkYhyHgPsyMNZbBLu+R2q1VRvDCNSaC6mQPlGUXjVQV7c85NiLrnxgaqL9hXK/VBgotSY\n\tyEwvrAyhGcQvjgZll1ryvxVRgg7phOyIn/L4GUbUR6EZRRB2AdOA0lIciKQdEZH3Ta25\n\tiG8uiyM2oAlTYY+Vc+ipliW8G5wfA9cb92FJAaNzMn1qL8GKu3IQ4ouvrZBcrXRhwycv\n\tnFOg==", "X-Gm-Message-State": "ALoCoQmp3KibzOjyzbPhE50nWlUX3goVu/GZpqiiJVYmGwEsoYbRO0LZaR11WmpF3rxowOGJAn1n", "X-Received": "by 10.68.196.97 with SMTP id il1mr31246138pbc.131.1445990359798; \n\tTue, 27 Oct 2015 16:59:19 -0700 (PDT)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 27 Oct 2015 16:59:18 -0700", "Message-ID": "<20151027235918.30048.41769.stgit@localhost.localdomain>", "In-Reply-To": "<20151027235341.30048.46286.stgit@localhost.localdomain>", "References": "<20151027235341.30048.46286.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH 2/5] fm10k: Cleanup exception\n\thandling for mailbox interrupt", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This patch addresses two issues.\n\nFirst is the fact that the fm10k_mbx_free_irq was assuming msix_entries was\nvalid and that will not always be the case. As such we need to add a check\nfor if it is NULL.\n\nSecond is the fact that we weren't freeing the IRQ if the mailbox API\nreturned an error on trying to connect.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 15e67a383d27..15327d274d72 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -1131,6 +1131,10 @@ void fm10k_mbx_free_irq(struct fm10k_intfc *interface)\n \tstruct fm10k_hw *hw = &interface->hw;\n \tint itr_reg;\n \n+\t/* no mailbox IRQ to free if MSI-X is not enabled */\n+\tif (!interface->msix_entries)\n+\t\treturn;\n+\n \t/* disconnect the mailbox */\n \thw->mbx.ops.disconnect(hw, &hw->mbx);\n \n@@ -1453,10 +1457,15 @@ int fm10k_mbx_request_irq(struct fm10k_intfc *interface)\n \t\terr = fm10k_mbx_request_irq_pf(interface);\n \telse\n \t\terr = fm10k_mbx_request_irq_vf(interface);\n+\tif (err)\n+\t\treturn err;\n \n \t/* connect mailbox */\n-\tif (!err)\n-\t\terr = hw->mbx.ops.connect(hw, &hw->mbx);\n+\terr = hw->mbx.ops.connect(hw, &hw->mbx);\n+\n+\t/* if the mailbox failed to connect, then free IRQ */\n+\tif (err)\n+\t\tfm10k_mbx_free_irq(interface);\n \n \treturn err;\n }\n", "prefixes": [ "next", "2/5" ] }