Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/536/?format=api
{ "id": 536, "url": "http://patchwork.ozlabs.org/api/patches/536/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1221757033-4874-4-git-send-email-benli@broadcom.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1221757033-4874-4-git-send-email-benli@broadcom.com>", "list_archive_url": null, "date": "2008-09-18T16:57:12", "name": "[UPDATED,NET-NEXT,3/4] bnx2: Remove name field from bnx2 structure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3b83a82e77f58c79d77333cc8f7e0054ab70375d", "submitter": { "id": 234, "url": "http://patchwork.ozlabs.org/api/people/234/?format=api", "name": "Benjamin Li", "email": "benli@broadcom.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1221757033-4874-4-git-send-email-benli@broadcom.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/536/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/536/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id F0B43DE0B4\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 19 Sep 2008 02:57:44 +1000 (EST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754741AbYIRQ5f (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 18 Sep 2008 12:57:35 -0400", "(majordomo@vger.kernel.org) by vger.kernel.org id S1754516AbYIRQ5f\n\t(ORCPT <rfc822; netdev-outgoing>); Thu, 18 Sep 2008 12:57:35 -0400", "from mms2.broadcom.com ([216.31.210.18]:3320 \"EHLO\n\tmms2.broadcom.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1756512AbYIRQ5d (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 18 Sep 2008 12:57:33 -0400", "from [10.11.16.99] by mms2.broadcom.com with ESMTP (Broadcom\n\tSMTP Relay (Email Firewall v6.3.2)); Thu, 18 Sep 2008 09:57:18 -0700", "by mail-irva-10.broadcom.com (Postfix, from userid 47) id\n\t63C172B2; Thu, 18 Sep 2008 09:57:18 -0700 (PDT)", "from mail-irva-8.broadcom.com (mail-irva-8 [10.11.18.52]) by\n\tmail-irva-10.broadcom.com (Postfix) with ESMTP id 4A7942B0;\n\tThu, 18 Sep 2008 09:57:18 -0700 (PDT)", "from mail-irva-13.broadcom.com (mail-irva-13.broadcom.com\n\t[10.11.16.103]) by mail-irva-8.broadcom.com (MOS 3.7.5a-GA) with\n\tESMTP id HDR82883; Thu, 18 Sep 2008 09:57:14 -0700 (PDT)", "from localhost (dhcp-10-12-137-98.broadcom.com [10.12.137.98])\n\tby mail-irva-13.broadcom.com (Postfix) with ESMTP id E8AAD74D09; Thu,\n\t18 Sep 2008 09:57:13 -0700 (PDT)" ], "X-Server-Uuid": "D3C04415-6FA8-4F2C-93C1-920E106A2031", "From": "\"Benjamin Li\" <benli@broadcom.com>", "To": "\"Jeff Garzik\" <jeff@garzik.org>", "cc": "benli@broadcom.com,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>", "Subject": "[UPDATED][NET-NEXT PATCH 3/4] bnx2: Remove name field from bnx2\n\tstructure", "Date": "Thu, 18 Sep 2008 09:57:12 -0700", "Message-ID": "<1221757033-4874-4-git-send-email-benli@broadcom.com>", "X-Mailer": "git-send-email 1.6.0.1", "In-Reply-To": "<1221757033-4874-3-git-send-email-benli@broadcom.com>", "References": "<20080918063933.GA8027@verge.net.au>\n\t<1221757033-4874-1-git-send-email-benli@broadcom.com>\n\t<1221757033-4874-2-git-send-email-benli@broadcom.com>\n\t<1221757033-4874-3-git-send-email-benli@broadcom.com>", "MIME-Version": "1.0", "X-WSS-ID": "64CC57E43D0157972905-01-01", "Content-Type": "text/plain", "Content-Transfer-Encoding": "7bit", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "The name of the board is only used during the initialization of\nthe adapter. We can save the space of a pointer by not storing\nthis information.\n\nSigned-off-by: Benjamin Li <benli@broadcom.com>\nSigned-off-by: Michael Chan <mchan@broadcom.com>", "diff": "diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c\nindex a78b664..8417766 100644\n--- a/drivers/net/bnx2.c\n+++ b/drivers/net/bnx2.c\n@@ -7718,7 +7718,6 @@ bnx2_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)\n \n \tmemcpy(dev->dev_addr, bp->mac_addr, 6);\n \tmemcpy(dev->perm_addr, bp->mac_addr, 6);\n-\tbp->name = board_info[ent->driver_data].name;\n \n \tdev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;\n \tif (CHIP_NUM(bp) == CHIP_NUM_5709)\n@@ -7745,7 +7744,7 @@ bnx2_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)\n \tprintk(KERN_INFO \"%s: %s (%c%d) %s found at mem %lx, \"\n \t\t\"IRQ %d, node addr %s\\n\",\n \t\tdev->name,\n-\t\tbp->name,\n+\t\tboard_info[ent->driver_data].name,\n \t\t((CHIP_ID(bp) & 0xf000) >> 12) + 'A',\n \t\t((CHIP_ID(bp) & 0x0ff0) >> 4),\n \t\tbnx2_bus_string(bp, str),\ndiff --git a/drivers/net/bnx2.h b/drivers/net/bnx2.h\nindex c3c579f..cb47c98 100644\n--- a/drivers/net/bnx2.h\n+++ b/drivers/net/bnx2.h\n@@ -6701,8 +6701,6 @@ struct bnx2 {\n \n \t/* End of fields used in the performance code paths. */\n \n-\tchar\t\t\t*name;\n-\n \tint\t\t\ttimer_interval;\n \tint\t\t\tcurrent_interval;\n \tstruct\t\t\ttimer_list timer;\n", "prefixes": [ "UPDATED", "NET-NEXT", "3/4" ] }