Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/534133/?format=api
{ "id": 534133, "url": "http://patchwork.ozlabs.org/api/patches/534133/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1445471236-35918-11-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1445471236-35918-11-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-10-21T23:47:11", "name": "[next,S19,10/15] i40e/i40evf: clean up error messages", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e9a2c0d6ad85c63ebe7a9d295ee99b5013fd5ceb", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1445471236-35918-11-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/534133/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/534133/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 1E673141310\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 22 Oct 2015 10:48:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6DBFA87D3B;\n\tWed, 21 Oct 2015 23:48:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mrZ85-1hAffB; Wed, 21 Oct 2015 23:48:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 682FF87F67;\n\tWed, 21 Oct 2015 23:48:42 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1DBB81C04C3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Oct 2015 23:48:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 096288AFA0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Oct 2015 23:48:41 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UxT7yoMXl9ob for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Oct 2015 23:48:40 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6097A88EA9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Oct 2015 23:48:40 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP; 21 Oct 2015 16:48:40 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby fmsmga001.fm.intel.com with ESMTP; 21 Oct 2015 16:48:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,179,1444719600\"; d=\"scan'208\";a=\"816562623\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 21 Oct 2015 19:47:11 -0400", "Message-Id": "<1445471236-35918-11-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1445471236-35918-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1445471236-35918-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S19 10/15] i40e/i40evf: clean up\n\terror messages", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nClean up and enhance error messages related to VF MAC/VLAN filters.\nIndicate which VF is having issues, and if possible indicate the MAC\naddress or VLAN involved.\n\nAlso, when an error is returned from the PF driver, print useful\ninformation about what went wrong, for the most likely cases.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: Ib3d15eef9e3369a78fd142948671e5fa26d921b8\n\n---\nTesting-hints: Add 1000 VLANS to a VF and add 1000 multicast filters to\na VF should show most of the errors, make sure the new errors are what\nis getting printed.\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 21 +++++++++--------\n .../net/ethernet/intel/i40evf/i40evf_virtchnl.c | 26 +++++++++++++++++++---\n 2 files changed, 35 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 44462b4..9c54ca2 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1623,7 +1623,8 @@ static int i40e_vc_add_mac_addr_msg(struct i40e_vf *vf, u8 *msg, u16 msglen)\n \n \t\tif (!f) {\n \t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"Unable to add VF MAC filter\\n\");\n+\t\t\t\t\"Unable to add MAC filter %pM for VF %d\\n\",\n+\t\t\t\t al->list[i].addr, vf->vf_id);\n \t\t\tret = I40E_ERR_PARAM;\n \t\t\tspin_unlock_bh(&vsi->mac_filter_list_lock);\n \t\t\tgoto error_param;\n@@ -1633,7 +1634,8 @@ static int i40e_vc_add_mac_addr_msg(struct i40e_vf *vf, u8 *msg, u16 msglen)\n \n \t/* program the updated filter list */\n \tif (i40e_sync_vsi_filters(vsi, false))\n-\t\tdev_err(&pf->pdev->dev, \"Unable to program VF MAC filters\\n\");\n+\t\tdev_err(&pf->pdev->dev, \"Unable to program VF %d MAC filters\\n\",\n+\t\t\tvf->vf_id);\n \n error_param:\n \t/* send the response to the VF */\n@@ -1669,8 +1671,8 @@ static int i40e_vc_del_mac_addr_msg(struct i40e_vf *vf, u8 *msg, u16 msglen)\n \tfor (i = 0; i < al->num_elements; i++) {\n \t\tif (is_broadcast_ether_addr(al->list[i].addr) ||\n \t\t is_zero_ether_addr(al->list[i].addr)) {\n-\t\t\tdev_err(&pf->pdev->dev, \"invalid VF MAC addr %pM\\n\",\n-\t\t\t\tal->list[i].addr);\n+\t\t\tdev_err(&pf->pdev->dev, \"Invalid MAC addr %pM for VF %d\\n\",\n+\t\t\t\tal->list[i].addr, vf->vf_id);\n \t\t\tret = I40E_ERR_INVALID_MAC_ADDR;\n \t\t\tgoto error_param;\n \t\t}\n@@ -1686,7 +1688,8 @@ static int i40e_vc_del_mac_addr_msg(struct i40e_vf *vf, u8 *msg, u16 msglen)\n \n \t/* program the updated filter list */\n \tif (i40e_sync_vsi_filters(vsi, false))\n-\t\tdev_err(&pf->pdev->dev, \"Unable to program VF MAC filters\\n\");\n+\t\tdev_err(&pf->pdev->dev, \"Unable to program VF %d MAC filters\\n\",\n+\t\t\tvf->vf_id);\n \n error_param:\n \t/* send the response to the VF */\n@@ -1740,8 +1743,8 @@ static int i40e_vc_add_vlan_msg(struct i40e_vf *vf, u8 *msg, u16 msglen)\n \n \t\tif (ret)\n \t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"Unable to add VF vlan filter %d, error %d\\n\",\n-\t\t\t\tvfl->vlan_id[i], ret);\n+\t\t\t\t\"Unable to add VLAN filter %d for VF %d, error %d\\n\",\n+\t\t\t\tvfl->vlan_id[i], vf->vf_id, ret);\n \t}\n \n error_param:\n@@ -1792,8 +1795,8 @@ static int i40e_vc_remove_vlan_msg(struct i40e_vf *vf, u8 *msg, u16 msglen)\n \n \t\tif (ret)\n \t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"Unable to delete VF vlan filter %d, error %d\\n\",\n-\t\t\t\tvfl->vlan_id[i], ret);\n+\t\t\t\t\"Unable to delete VLAN filter %d for VF %d, error %d\\n\",\n+\t\t\t\tvfl->vlan_id[i], vf->vf_id, ret);\n \t}\n \n error_param:\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\nindex 32e620e..091ef6a 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n@@ -724,9 +724,29 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,\n \t\treturn;\n \t}\n \tif (v_retval) {\n-\t\tdev_err(&adapter->pdev->dev, \"PF returned error %d (%s) to our request %d\\n\",\n-\t\t\tv_retval, i40evf_stat_str(&adapter->hw, v_retval),\n-\t\t\tv_opcode);\n+\t\tswitch (v_opcode) {\n+\t\tcase I40E_VIRTCHNL_OP_ADD_VLAN:\n+\t\t\tdev_err(&adapter->pdev->dev, \"Failed to add VLAN filter, error %s\\n\",\n+\t\t\t\ti40evf_stat_str(&adapter->hw, v_retval));\n+\t\t\tbreak;\n+\t\tcase I40E_VIRTCHNL_OP_ADD_ETHER_ADDRESS:\n+\t\t\tdev_err(&adapter->pdev->dev, \"Failed to add MAC filter, error %s\\n\",\n+\t\t\t\ti40evf_stat_str(&adapter->hw, v_retval));\n+\t\t\tbreak;\n+\t\tcase I40E_VIRTCHNL_OP_DEL_VLAN:\n+\t\t\tdev_err(&adapter->pdev->dev, \"Failed to delete VLAN filter, error %s\\n\",\n+\t\t\t\ti40evf_stat_str(&adapter->hw, v_retval));\n+\t\t\tbreak;\n+\t\tcase I40E_VIRTCHNL_OP_DEL_ETHER_ADDRESS:\n+\t\t\tdev_err(&adapter->pdev->dev, \"Failed to delete MAC filter, error %s\\n\",\n+\t\t\t\ti40evf_stat_str(&adapter->hw, v_retval));\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tdev_err(&adapter->pdev->dev, \"PF returned error %d (%s) to our request %d\\n\",\n+\t\t\t\tv_retval,\n+\t\t\t\ti40evf_stat_str(&adapter->hw, v_retval),\n+\t\t\t\tv_opcode);\n+\t\t}\n \t}\n \tswitch (v_opcode) {\n \tcase I40E_VIRTCHNL_OP_GET_STATS: {\n", "prefixes": [ "next", "S19", "10/15" ] }