Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/534128/?format=api
{ "id": 534128, "url": "http://patchwork.ozlabs.org/api/patches/534128/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1445471236-35918-7-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1445471236-35918-7-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-10-21T23:47:07", "name": "[next,S19,06/15] i40e: Workaround fix for mss < 256 issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "04a7b8ff1c616026bf2d70ab0992ce3f6466b9bd", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1445471236-35918-7-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/534128/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/534128/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 88A2A141311\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 22 Oct 2015 10:48:32 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BA2B28AF99;\n\tWed, 21 Oct 2015 23:48:31 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id sYS9MF9MoUtp; Wed, 21 Oct 2015 23:48:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B8E6C87FBE;\n\tWed, 21 Oct 2015 23:48:30 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6E6611C04C3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Oct 2015 23:48:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6B2E186779\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Oct 2015 23:48:29 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GJc1TjmBLKIv for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Oct 2015 23:48:29 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0D4CB86429\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Oct 2015 23:48:29 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP; 21 Oct 2015 16:48:28 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby fmsmga001.fm.intel.com with ESMTP; 21 Oct 2015 16:48:28 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,179,1444719600\"; d=\"scan'208\";a=\"816562505\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 21 Oct 2015 19:47:07 -0400", "Message-Id": "<1445471236-35918-7-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1445471236-35918-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1445471236-35918-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S19 06/15] i40e: Workaround fix for\n\tmss < 256 issue", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Anjali Singhai Jain <anjali.singhai@intel.com>\n\nHW/NVM sets a limit of no less than 256 bytes for MSS. Stack can send as\nlow as 76 bytes MSS. This patch lowers the HW limit to 64 bytes to avoid\nMDDs from firing and causing a reset when the MSS is lower than 256.\n\nSigned-off-by: Anjali Singhai Jain <anjali.singhai@intel.com>\nChange-ID: I36b500a6bb227d283c3e321a7718e0672b11fab0\n\n---\nTesting-hints: 5644586\nSet the mss to as low as 76 bytes using iperf3:\niperf3 -c 192.168.2.109 -B 192.168.2.108 -M 76\nCheck to see there are not resets and that the MSS for outbound packets\nis as was set by the test.\n drivers/net/ethernet/intel/i40e/i40e_main.c | 27 +++++++++++++++++++++++++++\n 1 file changed, 27 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex a8fd031..c8727b8 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -6705,6 +6705,7 @@ static void i40e_reset_and_rebuild(struct i40e_pf *pf, bool reinit)\n \tstruct i40e_hw *hw = &pf->hw;\n \tu8 set_fc_aq_fail = 0;\n \ti40e_status ret;\n+\tu32 val;\n \tu32 v;\n \n \t/* Now we wait for GRST to settle out.\n@@ -6843,6 +6844,20 @@ static void i40e_reset_and_rebuild(struct i40e_pf *pf, bool reinit)\n \t\t}\n \t}\n \n+\t/* Reconfigure hardware for allowing smaller MSS in the case\n+\t * of TSO, so that we avoid the MDD being fired and causing\n+\t * a reset in the case of small MSS+TSO.\n+\t */\n+#define I40E_REG_MSS 0x000E64DC\n+#define I40E_REG_MSS_MIN_MASK 0x3FF0000\n+#define I40E_64BYTE_MSS 0x400000\n+\tval = rd32(hw, I40E_REG_MSS);\n+\tif ((val & I40E_REG_MSS_MIN_MASK) > I40E_64BYTE_MSS) {\n+\t\tval &= ~I40E_REG_MSS_MIN_MASK;\n+\t\tval |= I40E_64BYTE_MSS;\n+\t\twr32(hw, I40E_REG_MSS, val);\n+\t}\n+\n \tif (((pf->hw.aq.fw_maj_ver == 4) && (pf->hw.aq.fw_min_ver < 33)) ||\n \t (pf->hw.aq.fw_maj_ver < 4)) {\n \t\tmsleep(75);\n@@ -10202,6 +10217,7 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \tu16 link_status;\n \tint err;\n \tu32 len;\n+\tu32 val;\n \tu32 i;\n \tu8 set_fc_aq_fail;\n \n@@ -10506,6 +10522,17 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\t\t i40e_stat_str(&pf->hw, err),\n \t\t\t i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status));\n \n+\t/* Reconfigure hardware for allowing smaller MSS in the case\n+\t * of TSO, so that we avoid the MDD being fired and causing\n+\t * a reset in the case of small MSS+TSO.\n+\t */\n+\tval = rd32(hw, I40E_REG_MSS);\n+\tif ((val & I40E_REG_MSS_MIN_MASK) > I40E_64BYTE_MSS) {\n+\t\tval &= ~I40E_REG_MSS_MIN_MASK;\n+\t\tval |= I40E_64BYTE_MSS;\n+\t\twr32(hw, I40E_REG_MSS, val);\n+\t}\n+\n \tif (((pf->hw.aq.fw_maj_ver == 4) && (pf->hw.aq.fw_min_ver < 33)) ||\n \t (pf->hw.aq.fw_maj_ver < 4)) {\n \t\tmsleep(75);\n", "prefixes": [ "next", "S19", "06/15" ] }