Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/532238/?format=api
{ "id": 532238, "url": "http://patchwork.ozlabs.org/api/patches/532238/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/5624E0C102000078000AC476@prv-mh.provo.novell.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<5624E0C102000078000AC476@prv-mh.provo.novell.com>", "list_archive_url": null, "date": "2015-10-19T10:23:29", "name": "igb: fix NULL derefs due to skipped SR-IOV enabling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7240bf99dad164ecc733033996fbdbd0cbf5d650", "submitter": { "id": 9477, "url": "http://patchwork.ozlabs.org/api/people/9477/?format=api", "name": "Jan Beulich", "email": "JBeulich@suse.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/5624E0C102000078000AC476@prv-mh.provo.novell.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/532238/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/532238/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 808E31402D0\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 19 Oct 2015 22:34:25 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B66A0892DD;\n\tMon, 19 Oct 2015 11:34:24 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 34ZL17hHPp-d; Mon, 19 Oct 2015 11:34:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 429F38A469;\n\tMon, 19 Oct 2015 11:34:23 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id CA3F71C10F4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Oct 2015 10:43:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A215630AE7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Oct 2015 10:43:43 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8Ti+kWE5GWwT for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Oct 2015 10:43:42 +0000 (UTC)", "from prv-mh.provo.novell.com (prv-mh.provo.novell.com\n\t[137.65.248.74])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 72FA226F3D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Oct 2015 10:43:42 +0000 (UTC)", "from INET-PRV-MTA by prv-mh.provo.novell.com\n\twith Novell_GroupWise; Mon, 19 Oct 2015 04:23:32 -0600" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:20:09 by SQLgrey-1.7.6", "Message-Id": "<5624E0C102000078000AC476@prv-mh.provo.novell.com>", "X-Mailer": "Novell GroupWise Internet Agent 14.0.1 ", "Date": "Mon, 19 Oct 2015 04:23:29 -0600", "From": "\"Jan Beulich\" <JBeulich@suse.com>", "To": "<jeffrey.t.kirsher@intel.com>", "Mime-Version": "1.0", "Content-Disposition": "inline", "X-Mailman-Approved-At": "Mon, 19 Oct 2015 11:34:21 +0000", "Cc": "sassmann@kpanic.de, intel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH] igb: fix NULL derefs due to skipped\n\tSR-IOV enabling", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The combined effect of commits 6423fc3416 (\"igb: do not re-init SR-IOV\nduring probe\") and ceee3450b3 (\"igb: make sure SR-IOV init uses the\nright number of queues\") causes VFs no longer getting set up, leading\nto NULL pointer dereferences due to the adapter's ->vf_data being NULL\nwhile ->vfs_allocated_count is non-zero. The first commit not only\nneglected the side effect of igb_sriov_reinit() that the second commit\ntried to account for, but also that of setting IGB_FLAG_HAS_MSIX,\nwithout which igb_enable_sriov() is effectively a no-op. Calling\nigb_{,re}set_interrupt_capability() as done here seems to address this,\nbut I'm not sure whether this is better than sinply reverting the other\ntwo commits.\n\nSigned-off-by: Jan Beulich <jbeulich@suse.com>\nCc: Stefan Assmann <sassmann@kpanic.de>\nCc: Todd Fujinaka <todd.fujinaka@intel.com>\nCc: Jesse Brandeburg <jesse.brandeburg@intel.com>\nCc: Shannon Nelson <shannon.nelson@intel.com>\nCc: Carolyn Wyborny <carolyn.wyborny@intel.com>\nCc: Don Skidmore <donald.c.skidmore@intel.com>\nCc: Matthew Vick <matthew.vick@intel.com>\nCc: John Ronciak <john.ronciak@intel.com>\nCc: Mitch Williams <mitch.a.williams@intel.com>\n---\nAs a side note, while looking at all the interactions here it seems\nsuspicious to me that igb_request_msix() failure does not lead to\nSR-IOV being disabled on the device, despite IGB_FLAG_HAS_MSIX being\nset being a prereq to it as explained above.\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "--- 4.3-rc6/drivers/net/ethernet/intel/igb/igb_main.c\n+++ 4.3-rc6-IGB-VF-setup/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -2856,6 +2856,14 @@ static void igb_probe_vfs(struct igb_ada\n \tif ((hw->mac.type == e1000_i210) || (hw->mac.type == e1000_i211))\n \t\treturn;\n \n+\t/*\n+\t * Of the below we really only want the effect of getting\n+\t * IGB_FLAG_HAS_MSIX set (if available), without which\n+\t * igb_enable_sriov() has no effect.\n+\t */\n+\tigb_set_interrupt_capability(adapter, true);\n+\tigb_reset_interrupt_capability(adapter);\n+\n \tpci_sriov_set_totalvfs(pdev, 7);\n \tigb_enable_sriov(pdev, max_vfs);\n \n", "prefixes": [] }