Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/531591/?format=api
{ "id": 531591, "url": "http://patchwork.ozlabs.org/api/patches/531591/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1445024551-21281-1-git-send-email-xerofoify@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1445024551-21281-1-git-send-email-xerofoify@gmail.com>", "list_archive_url": null, "date": "2015-10-16T19:42:31", "name": "fm10k:Fix error handling in the function fm10k_probe", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "f7cb9f1dcbd0e71342c00e8e451503838c2d5f6e", "submitter": { "id": 64281, "url": "http://patchwork.ozlabs.org/api/people/64281/?format=api", "name": "Nicholas Krause", "email": "xerofoify@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1445024551-21281-1-git-send-email-xerofoify@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/531591/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/531591/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id C218C1402B2\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 17 Oct 2015 11:12:35 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1365090EBD;\n\tSat, 17 Oct 2015 00:12:35 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1loOG4ua4fiD; Sat, 17 Oct 2015 00:12:34 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 59D6A90F39;\n\tSat, 17 Oct 2015 00:12:34 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 36BC41C0ED3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Oct 2015 19:42:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 31519A39B6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Oct 2015 19:42:38 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 221LLoiMXdAs for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Oct 2015 19:42:37 +0000 (UTC)", "from mail-qg0-f42.google.com (mail-qg0-f42.google.com\n\t[209.85.192.42])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 8F446A393B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Oct 2015 19:42:37 +0000 (UTC)", "by qgad10 with SMTP id d10so16275408qga.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Oct 2015 12:42:36 -0700 (PDT)", "from nick-System-Product-Name.hitronhub.home\n\t(CPEbc4dfb2691f3-CMbc4dfb2691f0.cpe.net.cable.rogers.com.\n\t[99.231.110.121]) by smtp.googlemail.com with ESMTPSA id\n\tj193sm8372472qhc.17.2015.10.16.12.42.34\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 16 Oct 2015 12:42:35 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=yzt+jvit;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id;\n\tbh=jgBpCzs//hsqA+kJiJJZ3ukaFfo9/+3c4rRXCNYGVd4=;\n\tb=yzt+jvitNv6LYYPp3UHxY88PenMWN0oVgTXSt7NVWGpso6IklkaHl+CYI01Bznpy6+\n\tDzf8+OZpTjbvQPNyVct6vxdZrZPg4STGgwXb/Z0XdfG60JYlRym1Pp8QliJZZ70wBOXV\n\tVCxS3xIYsTYtu8kEqWzfWYsFU2yanpWplftGjcyQYZH9U8x8Or6cbauab0VBdu1ILEbg\n\tp4vCD2L9JFdWa/LEgaJwoHelpeJR5WfVBe9Ei2KpmJYGKgw4J3x7XqTvng40CK7h6pa1\n\tNh7dIYjdu+1Wye9Amu/oW16+QH4chFve20D4j6WSLtRjBe5eNKDGXgD6c1j7atmRgRsR\n\tlKKQ==", "X-Received": "by 10.140.152.85 with SMTP id 82mr23216172qhy.8.1445024556552;\n\tFri, 16 Oct 2015 12:42:36 -0700 (PDT)", "From": "Nicholas Krause <xerofoify@gmail.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Fri, 16 Oct 2015 15:42:31 -0400", "Message-Id": "<1445024551-21281-1-git-send-email-xerofoify@gmail.com>", "X-Mailer": "git-send-email 2.1.4", "X-Mailman-Approved-At": "Sat, 17 Oct 2015 00:12:33 +0000", "Cc": "linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tnetdev@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] fm10k:Fix error handling in the function\n\tfm10k_probe", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This fixes error handling in the function fm10k_probe to properly\nif the call to the function fm10k_iov_configure has failed by\nreturning a error code before jumping to a new goto label,\nfm10k_iov_configure to clean up previously allocated resources\nbetween this goto label and the previous goto label before finally\nreturning the error code to the callers of the function fm10k_probe\n\nSigned-off-by: Nicholas Krause <xerofoify@gmail.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex ce53ff2..3d7374e 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -1844,13 +1844,17 @@ static int fm10k_probe(struct pci_dev *pdev,\n \tfm10k_slot_warn(interface);\n \n \t/* enable SR-IOV after registering netdev to enforce PF/VF ordering */\n-\tfm10k_iov_configure(pdev, 0);\n+\terr = fm10k_iov_configure(pdev, 0);\n+\tif (err)\n+\t\tgoto err_iov_configure;\n \n \t/* clear the service task disable bit to allow service task to start */\n \tclear_bit(__FM10K_SERVICE_DISABLE, &interface->state);\n \n \treturn 0;\n-\n+err_iov_configure:\n+\tfm10k_ptp_unregister(interface);\n+\tunregister_netdev(netdev);\n err_register:\n \tfm10k_mbx_free_irq(interface);\n err_mbx_interrupt:\n", "prefixes": [] }