Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/531503/?format=api
{ "id": 531503, "url": "http://patchwork.ozlabs.org/api/patches/531503/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1445018231-3196-8-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1445018231-3196-8-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2015-10-16T17:57:02", "name": "[next-queue,v5,08/17] fm10k: add statistics for actual DWORD count of mbmem mailbox", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c51c49187bd2d9733b1e6ff73d251abfd6acdd4b", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1445018231-3196-8-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/531503/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/531503/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id B2BA0140F97\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 17 Oct 2015 04:57:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0D622331EC;\n\tFri, 16 Oct 2015 17:57:23 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id c8wl2ULsHq5A; Fri, 16 Oct 2015 17:57:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id F1CCA32D36;\n\tFri, 16 Oct 2015 17:57:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5E6BA1C16C8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Oct 2015 17:57:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5ABBD8B1B3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Oct 2015 17:57:15 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fNgDgnEZlBr3 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Oct 2015 17:57:14 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9A05B8AE7C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Oct 2015 17:57:14 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga103.jf.intel.com with ESMTP; 16 Oct 2015 10:57:14 -0700", "from jekeller-desk.amr.corp.intel.com ([134.134.3.123])\n\tby fmsmga001.fm.intel.com with ESMTP; 16 Oct 2015 10:57:14 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,689,1437462000\"; d=\"scan'208\";a=\"812781766\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Fri, 16 Oct 2015 10:57:02 -0700", "Message-Id": "<1445018231-3196-8-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.6.1.264.gbab76a9", "In-Reply-To": "<1445018231-3196-1-git-send-email-jacob.e.keller@intel.com>", "References": "<1445018231-3196-1-git-send-email-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [next-queue v5 08/17] fm10k: add statistics for\n\tactual DWORD count of mbmem mailbox", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "A previous bug was uncovered by addition of a debug stat to indicate the\nactual number of DWORDS we pulled from the mbmem. It turned out this was\nnot the same as the tx_dwords counter. While the previous bug fix should\nhave corrected this in all cases, add some debug stats that count the\nnumber of DWORDs pushed or pulled from the mbmem. A future debugger may\ntake advantage of this statistic for debugging purposes. Since we're\nmodifying fm10k_mbx.h, update the copyright year as well.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 2 ++\n drivers/net/ethernet/intel/fm10k/fm10k_mbx.c | 4 ++++\n drivers/net/ethernet/intel/fm10k/fm10k_mbx.h | 4 +++-\n 3 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\nindex 447a5f8da42f..5db5a97cf28e 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n@@ -114,9 +114,11 @@ static const struct fm10k_stats fm10k_gstrings_mbx_stats[] = {\n \tFM10K_MBX_STAT(\"mbx_tx_oversized\", tx_dropped),\n \tFM10K_MBX_STAT(\"mbx_tx_messages\", tx_messages),\n \tFM10K_MBX_STAT(\"mbx_tx_dwords\", tx_dwords),\n+\tFM10K_MBX_STAT(\"mbx_tx_mbmem_pulled\", tx_mbmem_pulled),\n \tFM10K_MBX_STAT(\"mbx_rx_messages\", rx_messages),\n \tFM10K_MBX_STAT(\"mbx_rx_dwords\", rx_dwords),\n \tFM10K_MBX_STAT(\"mbx_rx_parse_err\", rx_parse_err),\n+\tFM10K_MBX_STAT(\"mbx_rx_mbmem_pushed\", rx_mbmem_pushed),\n };\n \n #define FM10K_GLOBAL_STATS_LEN ARRAY_SIZE(fm10k_gstrings_global_stats)\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\nindex af09a1b272e6..2bce47490723 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\n@@ -375,6 +375,8 @@ static void fm10k_mbx_write_copy(struct fm10k_hw *hw,\n \t\t\tif (!tail)\n \t\t\t\ttail++;\n \n+\t\t\tmbx->tx_mbmem_pulled++;\n+\n \t\t\t/* write message to hardware FIFO */\n \t\t\tfm10k_write_reg(hw, mbmem + tail++, *(head++));\n \t\t} while (--len && --end);\n@@ -459,6 +461,8 @@ static void fm10k_mbx_read_copy(struct fm10k_hw *hw,\n \t\t\tif (!head)\n \t\t\t\thead++;\n \n+\t\t\tmbx->rx_mbmem_pushed++;\n+\n \t\t\t/* read message from hardware FIFO */\n \t\t\t*(tail++) = fm10k_read_reg(hw, mbmem + head++);\n \t\t} while (--len && --end);\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.h b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.h\nindex 0419a7f0035e..c4f18a8f176c 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.h\n@@ -1,5 +1,5 @@\n /* Intel Ethernet Switch Host Interface Driver\n- * Copyright(c) 2013 - 2014 Intel Corporation.\n+ * Copyright(c) 2013 - 2015 Intel Corporation.\n *\n * This program is free software; you can redistribute it and/or modify it\n * under the terms and conditions of the GNU General Public License,\n@@ -291,8 +291,10 @@ struct fm10k_mbx_info {\n \tu64 tx_dropped;\n \tu64 tx_messages;\n \tu64 tx_dwords;\n+\tu64 tx_mbmem_pulled;\n \tu64 rx_messages;\n \tu64 rx_dwords;\n+\tu64 rx_mbmem_pushed;\n \tu64 rx_parse_err;\n \n \t/* Buffer to store messages */\n", "prefixes": [ "next-queue", "v5", "08/17" ] }