Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/528444/?format=api
{ "id": 528444, "url": "http://patchwork.ozlabs.org/api/patches/528444/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1444406000-4446-1-git-send-email-xerofoify@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1444406000-4446-1-git-send-email-xerofoify@gmail.com>", "list_archive_url": null, "date": "2015-10-09T15:53:20", "name": "fm10k:Fix error handling in the function fm10k_setup_tc for certain function calls", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "b7e7500e6c84bd5a800046ead9ba9b17d5cdd110", "submitter": { "id": 64281, "url": "http://patchwork.ozlabs.org/api/people/64281/?format=api", "name": "Nicholas Krause", "email": "xerofoify@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1444406000-4446-1-git-send-email-xerofoify@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/528444/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/528444/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id EC26F140291\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 10 Oct 2015 08:45:33 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7F6FB315C0;\n\tFri, 9 Oct 2015 21:45:32 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AEnpSejV1LIb; Fri, 9 Oct 2015 21:45:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 36E623332C;\n\tFri, 9 Oct 2015 21:45:28 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9231E1C1309\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 9 Oct 2015 15:53:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8D73832DE1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 9 Oct 2015 15:53:26 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id IYQM2qDjCXgt for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 9 Oct 2015 15:53:25 +0000 (UTC)", "from mail-ig0-f173.google.com (mail-ig0-f173.google.com\n\t[209.85.213.173])\n\tby silver.osuosl.org (Postfix) with ESMTPS id BEECF32ADF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 9 Oct 2015 15:53:25 +0000 (UTC)", "by igkz10 with SMTP id z10so4633476igk.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 09 Oct 2015 08:53:25 -0700 (PDT)", "from nick-System-Product-Name.hitronhub.home\n\t(CPEbc4dfb2691f3-CMbc4dfb2691f0.cpe.net.cable.rogers.com.\n\t[99.231.110.121]) by smtp.googlemail.com with ESMTPSA id\n\ti26sm1751850iod.27.2015.10.09.08.53.23\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 09 Oct 2015 08:53:23 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=Q7HaJb2t;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id;\n\tbh=iuaocrbv2ozvkCVUyE7gKepq4lI/oRPQZXtNkA164dA=;\n\tb=Q7HaJb2tFHWLPBjydT06J/TKeJ3efTss4nApw1q8ZmmFqf35C4E0S0Kw3IJpmBAUgF\n\tOIiQOZ7BXreVFlZ3v7oHsUmxAuegVBeQ88ELB2QesLGhG7kzK4nDkHzG6WFWnf03eDfI\n\tP+bKxyscJV8ZvVBThxLaIWYU5DTCusBq/XTuLbmUIR+mjKC+vdSMKuCBPj5xGUxUZh5z\n\tXh0lE+dsEOX1/BTtJ80QFaD3Wy7XJhVE84QBoAXGMeWPfkcQFn4JJMoj8bEBh2lCkgvV\n\tH/Nz++cTDdWmY2YIFg9K71euL3PVUrFfsZd1bitmwijrF+5KwsSpwrQssS7Lyzo0D6TW\n\tsYTQ==", "X-Received": "by 10.50.107.104 with SMTP id hb8mr10745540igb.1.1444406005145; \n\tFri, 09 Oct 2015 08:53:25 -0700 (PDT)", "From": "Nicholas Krause <xerofoify@gmail.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Fri, 9 Oct 2015 11:53:20 -0400", "Message-Id": "<1444406000-4446-1-git-send-email-xerofoify@gmail.com>", "X-Mailer": "git-send-email 2.1.4", "X-Mailman-Approved-At": "Fri, 09 Oct 2015 21:45:26 +0000", "Cc": "linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tnetdev@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] fm10k:Fix error handling in the function\n\tfm10k_setup_tc for certain function calls", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This fixes the function fm10k_setup_tc to propley check if the\ncalls to either the function fm10k_init_queueing_scheme or the\nfunction fm10k_mbx_request_irq fail by returning a error code to\nsignal that the call to either function has failed. Furthermore\nif this arises exit immediately from the function fm10k_setup_tc\nby returning the returned error code from the failed function call\nto signal to the caller that setting up the tc on the device has\nfailed and the caller needs to handle this failed setup.\n\nSigned-off-by: Nicholas Krause <xerofoify@gmail.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex 99228bf..5e9087a 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -1146,6 +1146,7 @@ static struct rtnl_link_stats64 *fm10k_get_stats64(struct net_device *netdev,\n int fm10k_setup_tc(struct net_device *dev, u8 tc)\n {\n \tstruct fm10k_intfc *interface = netdev_priv(dev);\n+\tint err;\n \n \t/* Currently only the PF supports priority classes */\n \tif (tc && (interface->hw.mac.type != fm10k_mac_pf))\n@@ -1170,9 +1171,13 @@ int fm10k_setup_tc(struct net_device *dev, u8 tc)\n \tnetdev_reset_tc(dev);\n \tnetdev_set_num_tc(dev, tc);\n \n-\tfm10k_init_queueing_scheme(interface);\n+\terr = fm10k_init_queueing_scheme(interface);\n+\tif (err)\n+\t\treturn err;\n \n-\tfm10k_mbx_request_irq(interface);\n+\terr = fm10k_mbx_request_irq(interface);\n+\tif (err)\n+\t\treturn err;\n \n \tif (netif_running(dev))\n \t\tfm10k_open(dev);\n", "prefixes": [] }