Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/527582/?format=api
{ "id": 527582, "url": "http://patchwork.ozlabs.org/api/patches/527582/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1444276739-20372-9-git-send-email-gwshan@linux.vnet.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<1444276739-20372-9-git-send-email-gwshan@linux.vnet.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/1444276739-20372-9-git-send-email-gwshan@linux.vnet.ibm.com/", "date": "2015-10-08T03:58:59", "name": "[v2,8/8] powerpc/powernv: Simplify pnv_eeh_set_option()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f8745659f9d55e8d98c29653e033f6464df14acd", "submitter": { "id": 63923, "url": "http://patchwork.ozlabs.org/api/people/63923/?format=api", "name": "Gavin Shan", "email": "gwshan@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1444276739-20372-9-git-send-email-gwshan@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/527582/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/527582/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org", "linuxppc-dev@ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 9AFCE14029C\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 8 Oct 2015 15:09:28 +1100 (AEDT)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 7EB461A099E\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 8 Oct 2015 15:09:28 +1100 (AEDT)", "from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id CAAF11A01D7\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tThu, 8 Oct 2015 15:00:24 +1100 (AEDT)", "by ozlabs.org (Postfix)\n\tid 9A61B140D87; Thu, 8 Oct 2015 15:00:24 +1100 (AEDT)", "from e23smtp02.au.ibm.com (e23smtp02.au.ibm.com [202.81.31.144])\n\t(using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 84D07140D8C\n\tfor <linuxppc-dev@ozlabs.org>; Thu, 8 Oct 2015 15:00:24 +1100 (AEDT)", "from /spool/local\n\tby e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@ozlabs.org> from <gwshan@linux.vnet.ibm.com>;\n\tThu, 8 Oct 2015 14:00:23 +1000", "from d23dlp03.au.ibm.com (202.81.31.214)\n\tby e23smtp02.au.ibm.com (202.81.31.208) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 8 Oct 2015 14:00:22 +1000", "from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181])\n\tby d23dlp03.au.ibm.com (Postfix) with ESMTP id 272F33578053\n\tfor <linuxppc-dev@ozlabs.org>; Thu, 8 Oct 2015 15:00:22 +1100 (EST)", "from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138])\n\tby d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tt9840EdJ000438\n\tfor <linuxppc-dev@ozlabs.org>; Thu, 8 Oct 2015 15:00:22 +1100", "from d23av02.au.ibm.com (localhost [127.0.0.1])\n\tby d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tt983xn8l007048\n\tfor <linuxppc-dev@ozlabs.org>; Thu, 8 Oct 2015 14:59:49 +1100", "from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tt983xng1006655; Thu, 8 Oct 2015 14:59:49 +1100", "from bran.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114])\n\tby ozlabs.au.ibm.com (Postfix) with ESMTP id 7D6E5A03E3;\n\tThu, 8 Oct 2015 14:59:02 +1100 (AEDT)", "from gwshan (shangw.ozlabs.ibm.com [10.61.2.199])\n\tby bran.ozlabs.ibm.com (Postfix) with ESMTP id 76103E460C;\n\tThu, 8 Oct 2015 14:59:02 +1100 (AEDT)", "by gwshan (Postfix, from userid 1000)\n\tid 70ED2942239; Thu, 8 Oct 2015 14:59:02 +1100 (AEDT)" ], "X-Helo": "d23dlp03.au.ibm.com", "X-MailFrom": "gwshan@linux.vnet.ibm.com", "X-RcptTo": "linuxppc-dev@ozlabs.org", "From": "Gavin Shan <gwshan@linux.vnet.ibm.com>", "To": "linuxppc-dev@ozlabs.org", "Subject": "[PATCH v2 8/8] powerpc/powernv: Simplify pnv_eeh_set_option()", "Date": "Thu, 8 Oct 2015 14:58:59 +1100", "Message-Id": "<1444276739-20372-9-git-send-email-gwshan@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1444276739-20372-1-git-send-email-gwshan@linux.vnet.ibm.com>", "References": "<1444276739-20372-1-git-send-email-gwshan@linux.vnet.ibm.com>", "X-TM-AS-MML": "disable", "X-Content-Scanned": "Fidelis XPS MAILER", "x-cbid": "15100804-0005-0000-0000-0000028F9292", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Gavin Shan <gwshan@linux.vnet.ibm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "This simplifies pnv_eeh_set_option() to avoid unnecessary nested\nif statements, to improve readability. No functional changes.\n\nSigned-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>\n---\n arch/powerpc/platforms/powernv/eeh-powernv.c | 51 ++++++++++++++--------------\n 1 file changed, 25 insertions(+), 26 deletions(-)", "diff": "diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c\nindex 2b5c70b..d62007f 100644\n--- a/arch/powerpc/platforms/powernv/eeh-powernv.c\n+++ b/arch/powerpc/platforms/powernv/eeh-powernv.c\n@@ -471,7 +471,7 @@ static int pnv_eeh_set_option(struct eeh_pe *pe, int option)\n \tstruct pci_controller *hose = pe->phb;\n \tstruct pnv_phb *phb = hose->private_data;\n \tbool freeze_pe = false;\n-\tint opt, ret = 0;\n+\tint opt;\n \ts64 rc;\n \n \tswitch (option) {\n@@ -494,38 +494,37 @@ static int pnv_eeh_set_option(struct eeh_pe *pe, int option)\n \t\treturn -EINVAL;\n \t}\n \n-\t/* If PHB supports compound PE, to handle it */\n+\t/* Freeze master and slave PEs if PHB supports compound PEs */\n \tif (freeze_pe) {\n \t\tif (phb->freeze_pe) {\n \t\t\tphb->freeze_pe(phb, pe->addr);\n-\t\t} else {\n-\t\t\trc = opal_pci_eeh_freeze_set(phb->opal_id,\n-\t\t\t\t\t\t pe->addr, opt);\n-\t\t\tif (rc != OPAL_SUCCESS) {\n-\t\t\t\tpr_warn(\"%s: Failure %lld freezing \"\n-\t\t\t\t\t\"PHB#%x-PE#%x\\n\",\n-\t\t\t\t\t__func__, rc,\n-\t\t\t\t\tphb->hose->global_number, pe->addr);\n-\t\t\t\tret = -EIO;\n-\t\t\t}\n+\t\t\treturn 0;\n \t\t}\n-\t} else {\n-\t\tif (phb->unfreeze_pe) {\n-\t\t\tret = phb->unfreeze_pe(phb, pe->addr, opt);\n-\t\t} else {\n-\t\t\trc = opal_pci_eeh_freeze_clear(phb->opal_id,\n-\t\t\t\t\t\t pe->addr, opt);\n-\t\t\tif (rc != OPAL_SUCCESS) {\n-\t\t\t\tpr_warn(\"%s: Failure %lld enable %d \"\n-\t\t\t\t\t\"for PHB#%x-PE#%x\\n\",\n-\t\t\t\t\t__func__, rc, option,\n-\t\t\t\t\tphb->hose->global_number, pe->addr);\n-\t\t\t\tret = -EIO;\n-\t\t\t}\n+\n+\t\trc = opal_pci_eeh_freeze_set(phb->opal_id, pe->addr, opt);\n+\t\tif (rc != OPAL_SUCCESS) {\n+\t\t\tpr_warn(\"%s: Failure %lld freezing PHB#%x-PE#%x\\n\",\n+\t\t\t\t__func__, rc, phb->hose->global_number,\n+\t\t\t\tpe->addr);\n+\t\t\treturn -EIO;\n \t\t}\n+\n+\t\treturn 0;\n \t}\n \n-\treturn ret;\n+\t/* Unfreeze master and slave PEs if PHB supports */\n+\tif (phb->unfreeze_pe)\n+\t\treturn phb->unfreeze_pe(phb, pe->addr, opt);\n+\n+\trc = opal_pci_eeh_freeze_clear(phb->opal_id, pe->addr, opt);\n+\tif (rc != OPAL_SUCCESS) {\n+\t\tpr_warn(\"%s: Failure %lld enable %d for PHB#%x-PE#%x\\n\",\n+\t\t\t__func__, rc, option, phb->hose->global_number,\n+\t\t\tpe->addr);\n+\t\treturn -EIO;\n+\t}\n+\n+\treturn 0;\n }\n \n /**\n", "prefixes": [ "v2", "8/8" ] }