Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/527580/?format=api
{ "id": 527580, "url": "http://patchwork.ozlabs.org/api/patches/527580/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1444276739-20372-7-git-send-email-gwshan@linux.vnet.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<1444276739-20372-7-git-send-email-gwshan@linux.vnet.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/1444276739-20372-7-git-send-email-gwshan@linux.vnet.ibm.com/", "date": "2015-10-08T03:58:57", "name": "[v2,6/8] powerpc/powernv: Cleanup on EEH comments", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "81441f47aa091a15231cf8eb58175d20f3ba8879", "submitter": { "id": 63923, "url": "http://patchwork.ozlabs.org/api/people/63923/?format=api", "name": "Gavin Shan", "email": "gwshan@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1444276739-20372-7-git-send-email-gwshan@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/527580/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/527580/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org", "linuxppc-dev@ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id D298D140D87\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 8 Oct 2015 15:07:09 +1100 (AEDT)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id B29B51A0AD3\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 8 Oct 2015 15:07:09 +1100 (AEDT)", "from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id BB21B1A021E\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tThu, 8 Oct 2015 15:00:23 +1100 (AEDT)", "by ozlabs.org (Postfix)\n\tid A787D140D8A; Thu, 8 Oct 2015 15:00:23 +1100 (AEDT)", "from e23smtp04.au.ibm.com (e23smtp04.au.ibm.com [202.81.31.146])\n\t(using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 92DBF140D87\n\tfor <linuxppc-dev@ozlabs.org>; Thu, 8 Oct 2015 15:00:23 +1100 (AEDT)", "from /spool/local\n\tby e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@ozlabs.org> from <gwshan@linux.vnet.ibm.com>;\n\tThu, 8 Oct 2015 14:00:23 +1000", "from d23dlp01.au.ibm.com (202.81.31.203)\n\tby e23smtp04.au.ibm.com (202.81.31.210) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 8 Oct 2015 14:00:21 +1000", "from d23relay06.au.ibm.com (d23relay06.au.ibm.com [9.185.63.219])\n\tby d23dlp01.au.ibm.com (Postfix) with ESMTP id 85B1F2CE8054\n\tfor <linuxppc-dev@ozlabs.org>; Thu, 8 Oct 2015 15:00:21 +1100 (EST)", "from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])\n\tby d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tt98409QF25952446\n\tfor <linuxppc-dev@ozlabs.org>; Thu, 8 Oct 2015 15:00:17 +1100", "from d23av03.au.ibm.com (localhost [127.0.0.1])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tt983xnbo023227\n\tfor <linuxppc-dev@ozlabs.org>; Thu, 8 Oct 2015 14:59:49 +1100", "from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tt983xn7H022653; Thu, 8 Oct 2015 14:59:49 +1100", "from bran.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114])\n\tby ozlabs.au.ibm.com (Postfix) with ESMTP id 2870EA03E1;\n\tThu, 8 Oct 2015 14:59:02 +1100 (AEDT)", "from gwshan (shangw.ozlabs.ibm.com [10.61.2.199])\n\tby bran.ozlabs.ibm.com (Postfix) with ESMTP id 2200EE460C;\n\tThu, 8 Oct 2015 14:59:02 +1100 (AEDT)", "by gwshan (Postfix, from userid 1000)\n\tid 14CCC942239; Thu, 8 Oct 2015 14:59:02 +1100 (AEDT)" ], "X-Helo": "d23dlp01.au.ibm.com", "X-MailFrom": "gwshan@linux.vnet.ibm.com", "X-RcptTo": "linuxppc-dev@ozlabs.org", "From": "Gavin Shan <gwshan@linux.vnet.ibm.com>", "To": "linuxppc-dev@ozlabs.org", "Subject": "[PATCH v2 6/8] powerpc/powernv: Cleanup on EEH comments", "Date": "Thu, 8 Oct 2015 14:58:57 +1100", "Message-Id": "<1444276739-20372-7-git-send-email-gwshan@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1444276739-20372-1-git-send-email-gwshan@linux.vnet.ibm.com>", "References": "<1444276739-20372-1-git-send-email-gwshan@linux.vnet.ibm.com>", "X-TM-AS-MML": "disable", "X-Content-Scanned": "Fidelis XPS MAILER", "x-cbid": "15100804-0013-0000-0000-000001FFBBC0", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Gavin Shan <gwshan@linux.vnet.ibm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "This applies cleanup on eeh-powernv.c, no functional changes:\n\n * Remove unnecessary comments and empty line.\n * Correct inaccurate comments.\n\nSigned-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>\n---\n arch/powerpc/platforms/powernv/eeh-powernv.c | 13 ++-----------\n 1 file changed, 2 insertions(+), 11 deletions(-)", "diff": "diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c\nindex 3bb6acb..2032936 100644\n--- a/arch/powerpc/platforms/powernv/eeh-powernv.c\n+++ b/arch/powerpc/platforms/powernv/eeh-powernv.c\n@@ -43,17 +43,11 @@\n static bool pnv_eeh_nb_init = false;\n static int eeh_event_irq = -EINVAL;\n \n-/**\n- * pnv_eeh_init - EEH platform dependent initialization\n- *\n- * EEH platform dependent initialization on powernv\n- */\n static int pnv_eeh_init(void)\n {\n \tstruct pci_controller *hose;\n \tstruct pnv_phb *phb;\n \n-\t/* We require OPALv3 */\n \tif (!firmware_has_feature(FW_FEATURE_OPALv3)) {\n \t\tpr_warn(\"%s: OPALv3 is required !\\n\",\n \t\t\t__func__);\n@@ -77,9 +71,9 @@ static int pnv_eeh_init(void)\n \t\t/*\n \t\t * PE#0 should be regarded as valid by EEH core\n \t\t * if it's not the reserved one. Currently, we\n-\t\t * have the reserved PE#0 and PE#127 for PHB3\n+\t\t * have the reserved PE#255 and PE#127 for PHB3\n \t\t * and P7IOC separately. So we should regard\n-\t\t * PE#0 as valid for P7IOC.\n+\t\t * PE#0 as valid for PHB3 and P7IOC.\n \t\t */\n \t\tif (phb->ioda.reserved_pe != 0)\n \t\t\teeh_add_flag(EEH_VALID_PE_ZERO);\n@@ -284,7 +278,6 @@ static int pnv_eeh_post_init(void)\n #endif /* CONFIG_DEBUG_FS */\n \t}\n \n-\n \treturn ret;\n }\n \n@@ -490,7 +483,6 @@ static int pnv_eeh_set_option(struct eeh_pe *pe, int option)\n \tint opt, ret = 0;\n \ts64 rc;\n \n-\t/* Sanity check on option */\n \tswitch (option) {\n \tcase EEH_OPT_DISABLE:\n \t\treturn -EPERM;\n@@ -1065,7 +1057,6 @@ static int pnv_eeh_err_inject(struct eeh_pe *pe, int type, int func,\n \tstruct pnv_phb *phb = hose->private_data;\n \ts64 rc;\n \n-\t/* Sanity check on error type */\n \tif (type != OPAL_ERR_INJECT_TYPE_IOA_BUS_ERR &&\n \t type != OPAL_ERR_INJECT_TYPE_IOA_BUS_ERR64) {\n \t\tpr_warn(\"%s: Invalid error type %d\\n\",\n", "prefixes": [ "v2", "6/8" ] }