Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/525665/?format=api
{ "id": 525665, "url": "http://patchwork.ozlabs.org/api/patches/525665/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443806386-150326-1-git-send-email-mitch.a.williams@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1443806386-150326-1-git-send-email-mitch.a.williams@intel.com>", "list_archive_url": null, "date": "2015-10-02T17:19:46", "name": "[net] i40e/i40evf: set aq count after memory allocation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "17670541a839e60dadcbf62429db250383980c5e", "submitter": { "id": 967, "url": "http://patchwork.ozlabs.org/api/people/967/?format=api", "name": "Mitch Williams", "email": "mitch.a.williams@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443806386-150326-1-git-send-email-mitch.a.williams@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/525665/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/525665/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 912791402F0\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 3 Oct 2015 03:18:54 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id BEA6132DD5;\n\tFri, 2 Oct 2015 17:18:53 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aL5+whStV3jP; Fri, 2 Oct 2015 17:18:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9E8B12D363;\n\tFri, 2 Oct 2015 17:18:52 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id C32DB1BF863\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Oct 2015 17:18:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BEF6195680\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Oct 2015 17:18:51 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id agpAVvtkewhO for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Oct 2015 17:18:51 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 051B895677\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Oct 2015 17:18:50 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 02 Oct 2015 10:18:30 -0700", "from mawilli1-mobl.jf.intel.com ([10.166.14.28])\n\tby FMSMGA003.fm.intel.com with ESMTP; 02 Oct 2015 10:18:29 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,624,1437462000\"; d=\"scan'208\";a=\"572929119\"", "From": "Mitch Williams <mitch.a.williams@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 2 Oct 2015 10:19:46 -0700", "Message-Id": "<1443806386-150326-1-git-send-email-mitch.a.williams@intel.com>", "X-Mailer": "git-send-email 2.4.3", "Subject": "[Intel-wired-lan] [net PATCH] i40e/i40evf: set aq count after\n\tmemory allocation", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The standard way to check if the AQ is enabled is to look at the\ncount field. So we should only set this field after we have\nsuccessfully allocated memory. To do otherwise is to incite\npanic among the populace.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_adminq.c | 4 ++--\n drivers/net/ethernet/intel/i40evf/i40e_adminq.c | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.c b/drivers/net/ethernet/intel/i40e/i40e_adminq.c\nindex 62488a6..c0e943a 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_adminq.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.c\n@@ -386,7 +386,6 @@ static i40e_status i40e_init_asq(struct i40e_hw *hw)\n \n \thw->aq.asq.next_to_use = 0;\n \thw->aq.asq.next_to_clean = 0;\n-\thw->aq.asq.count = hw->aq.num_asq_entries;\n \n \t/* allocate the ring memory */\n \tret_code = i40e_alloc_adminq_asq_ring(hw);\n@@ -404,6 +403,7 @@ static i40e_status i40e_init_asq(struct i40e_hw *hw)\n \t\tgoto init_adminq_free_rings;\n \n \t/* success! */\n+\thw->aq.asq.count = hw->aq.num_asq_entries;\n \tgoto init_adminq_exit;\n \n init_adminq_free_rings:\n@@ -445,7 +445,6 @@ static i40e_status i40e_init_arq(struct i40e_hw *hw)\n \n \thw->aq.arq.next_to_use = 0;\n \thw->aq.arq.next_to_clean = 0;\n-\thw->aq.arq.count = hw->aq.num_arq_entries;\n \n \t/* allocate the ring memory */\n \tret_code = i40e_alloc_adminq_arq_ring(hw);\n@@ -463,6 +462,7 @@ static i40e_status i40e_init_arq(struct i40e_hw *hw)\n \t\tgoto init_adminq_free_rings;\n \n \t/* success! */\n+\thw->aq.arq.count = hw->aq.num_arq_entries;\n \tgoto init_adminq_exit;\n \n init_adminq_free_rings:\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_adminq.c b/drivers/net/ethernet/intel/i40evf/i40e_adminq.c\nindex 7f52ee1..8ce43b9 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_adminq.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_adminq.c\n@@ -384,7 +384,6 @@ static i40e_status i40e_init_asq(struct i40e_hw *hw)\n \n \thw->aq.asq.next_to_use = 0;\n \thw->aq.asq.next_to_clean = 0;\n-\thw->aq.asq.count = hw->aq.num_asq_entries;\n \n \t/* allocate the ring memory */\n \tret_code = i40e_alloc_adminq_asq_ring(hw);\n@@ -402,6 +401,7 @@ static i40e_status i40e_init_asq(struct i40e_hw *hw)\n \t\tgoto init_adminq_free_rings;\n \n \t/* success! */\n+\thw->aq.asq.count = hw->aq.num_asq_entries;\n \tgoto init_adminq_exit;\n \n init_adminq_free_rings:\n@@ -443,7 +443,6 @@ static i40e_status i40e_init_arq(struct i40e_hw *hw)\n \n \thw->aq.arq.next_to_use = 0;\n \thw->aq.arq.next_to_clean = 0;\n-\thw->aq.arq.count = hw->aq.num_arq_entries;\n \n \t/* allocate the ring memory */\n \tret_code = i40e_alloc_adminq_arq_ring(hw);\n@@ -461,6 +460,7 @@ static i40e_status i40e_init_arq(struct i40e_hw *hw)\n \t\tgoto init_adminq_free_rings;\n \n \t/* success! */\n+\thw->aq.arq.count = hw->aq.num_arq_entries;\n \tgoto init_adminq_exit;\n \n init_adminq_free_rings:\n", "prefixes": [ "net" ] }