Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/524090/?format=api
{ "id": 524090, "url": "http://patchwork.ozlabs.org/api/patches/524090/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1443578287-7847-1-git-send-email-andrew.donnellan@au1.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<1443578287-7847-1-git-send-email-andrew.donnellan@au1.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/1443578287-7847-1-git-send-email-andrew.donnellan@au1.ibm.com/", "date": "2015-09-30T01:58:05", "name": "[1/3] cxl: fix leak of IRQ names in cxl_free_afu_irqs()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bb4a72ffa37193bc99959d0d8343a0b2835c6e97", "submitter": { "id": 66955, "url": "http://patchwork.ozlabs.org/api/people/66955/?format=api", "name": "Andrew Donnellan", "email": "andrew.donnellan@au1.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1443578287-7847-1-git-send-email-andrew.donnellan@au1.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/524090/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/524090/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org", "linuxppc-dev@ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 60627140787\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 30 Sep 2015 12:00:08 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 467ED1A0ADD\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 30 Sep 2015 12:00:08 +1000 (AEST)", "from ozlabs.org (ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 87BF21A002B\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed, 30 Sep 2015 11:59:02 +1000 (AEST)", "by ozlabs.org (Postfix)\n\tid 5BCE9140787; Wed, 30 Sep 2015 11:59:02 +1000 (AEST)", "from e23smtp01.au.ibm.com (e23smtp01.au.ibm.com [202.81.31.143])\n\t(using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id CA855140778\n\tfor <linuxppc-dev@ozlabs.org>; Wed, 30 Sep 2015 11:59:01 +1000 (AEST)", "from /spool/local\n\tby e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@ozlabs.org> from <andrew.donnellan@au1.ibm.com>;\n\tWed, 30 Sep 2015 11:59:00 +1000", "from d23dlp03.au.ibm.com (202.81.31.214)\n\tby e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 30 Sep 2015 11:58:57 +1000", "from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181])\n\tby d23dlp03.au.ibm.com (Postfix) with ESMTP id 01F7E3578053\n\tfor <linuxppc-dev@ozlabs.org>; Wed, 30 Sep 2015 11:58:57 +1000 (EST)", "from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])\n\tby d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tt8U1wmCZ60358708\n\tfor <linuxppc-dev@ozlabs.org>; Wed, 30 Sep 2015 11:58:56 +1000", "from d23av03.au.ibm.com (localhost [127.0.0.1])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tt8U1wNCq030177\n\tfor <linuxppc-dev@ozlabs.org>; Wed, 30 Sep 2015 11:58:24 +1000", "from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tt8U1wNeh029602; Wed, 30 Sep 2015 11:58:23 +1000", "from ajd.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114])\n\tby ozlabs.au.ibm.com (Postfix) with ESMTP id 7B756A024C;\n\tWed, 30 Sep 2015 11:57:59 +1000 (AEST)" ], "X-Helo": "d23dlp03.au.ibm.com", "X-MailFrom": "andrew.donnellan@au1.ibm.com", "X-RcptTo": "linuxppc-dev@ozlabs.org", "From": "Andrew Donnellan <andrew.donnellan@au1.ibm.com>", "To": "linuxppc-dev@ozlabs.org", "Subject": "[PATCH 1/3] cxl: fix leak of IRQ names in cxl_free_afu_irqs()", "Date": "Wed, 30 Sep 2015 11:58:05 +1000", "Message-Id": "<1443578287-7847-1-git-send-email-andrew.donnellan@au1.ibm.com>", "X-Mailer": "git-send-email 2.1.4", "X-TM-AS-MML": "disable", "X-Content-Scanned": "Fidelis XPS MAILER", "x-cbid": "15093001-1618-0000-0000-000002D773D2", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "mikey@neuling.org, mrochs@linux.vnet.ibm.com, imunsie@au1.ibm.com,\n\tvaibhav@linux.vnet.ibm.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "cxl_free_afu_irqs() doesn't free IRQ names when it releases an AFU's IRQ\nranges. The userspace API equivalent in afu_release_irqs() calls\nafu_irq_name_free() to release the IRQ names.\n\nCall afu_irq_name_free() in cxl_free_afu_irqs() to release the IRQ names.\nMake afu_irq_name_free() non-static to allow this.\n\nReported-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>\nFixes: 6f7f0b3df6d4 (\"cxl: Add AFU virtual PHB and kernel API\")\nSigned-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>\nSigned-off-by: Ian Munsie <imunsie@au1.ibm.com>\n---\n drivers/misc/cxl/api.c | 1 +\n drivers/misc/cxl/cxl.h | 1 +\n drivers/misc/cxl/irq.c | 2 +-\n 3 files changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c\nindex 8af12c8..103baf0 100644\n--- a/drivers/misc/cxl/api.c\n+++ b/drivers/misc/cxl/api.c\n@@ -105,6 +105,7 @@ EXPORT_SYMBOL_GPL(cxl_allocate_afu_irqs);\n \n void cxl_free_afu_irqs(struct cxl_context *ctx)\n {\n+\tafu_irq_name_free(ctx);\n \tcxl_release_irq_ranges(&ctx->irqs, ctx->afu->adapter);\n }\n EXPORT_SYMBOL_GPL(cxl_free_afu_irqs);\ndiff --git a/drivers/misc/cxl/cxl.h b/drivers/misc/cxl/cxl.h\nindex 1c30ef7..0cfb9c1 100644\n--- a/drivers/misc/cxl/cxl.h\n+++ b/drivers/misc/cxl/cxl.h\n@@ -677,6 +677,7 @@ int cxl_register_serr_irq(struct cxl_afu *afu);\n void cxl_release_serr_irq(struct cxl_afu *afu);\n int afu_register_irqs(struct cxl_context *ctx, u32 count);\n void afu_release_irqs(struct cxl_context *ctx, void *cookie);\n+void afu_irq_name_free(struct cxl_context *ctx);\n irqreturn_t cxl_slice_irq_err(int irq, void *data);\n \n int cxl_debugfs_init(void);\ndiff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c\nindex 583b42a..38b57d6 100644\n--- a/drivers/misc/cxl/irq.c\n+++ b/drivers/misc/cxl/irq.c\n@@ -414,7 +414,7 @@ void cxl_release_psl_irq(struct cxl_afu *afu)\n \tkfree(afu->psl_irq_name);\n }\n \n-static void afu_irq_name_free(struct cxl_context *ctx)\n+void afu_irq_name_free(struct cxl_context *ctx)\n {\n \tstruct cxl_irq_name *irq_name, *tmp;\n \n", "prefixes": [ "1/3" ] }