Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/524045/?format=api
{ "id": 524045, "url": "http://patchwork.ozlabs.org/api/patches/524045/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150929221950.3388.63535.stgit@ahduyck-vm-fedora22/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150929221950.3388.63535.stgit@ahduyck-vm-fedora22>", "list_archive_url": null, "date": "2015-09-29T22:19:50", "name": "[2/3] i40e/i40evf: use napi_schedule_irqoff()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ade5f9d86fa7cf9cdd460d9d22acb59ac4d28d88", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150929221950.3388.63535.stgit@ahduyck-vm-fedora22/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/524045/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/524045/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3596A14029C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Sep 2015 08:19:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 84BB494CB9;\n\tTue, 29 Sep 2015 22:19:54 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id P0U8cjv8xdvy; Tue, 29 Sep 2015 22:19:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 25D1694C98;\n\tTue, 29 Sep 2015 22:19:54 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8770F1C1536\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Sep 2015 22:19:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8325594C97\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Sep 2015 22:19:52 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EGIGZpsUNYot for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Sep 2015 22:19:52 +0000 (UTC)", "from mail-pa0-f46.google.com (mail-pa0-f46.google.com\n\t[209.85.220.46])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 0237C94CAF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Sep 2015 22:19:51 +0000 (UTC)", "by pacfv12 with SMTP id fv12so18390080pac.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Sep 2015 15:19:51 -0700 (PDT)", "from [192.168.122.149] (static-50-53-21-5.bvtn.or.frontiernet.net.\n\t[50.53.21.5]) by smtp.gmail.com with ESMTPSA id\n\trl17sm27635969pab.2.2015.09.29.15.19.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Sep 2015 15:19:51 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=hX3EEjz7; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-type:content-transfer-encoding;\n\tbh=6VM6R6/hJoGrZ529szPOARfBxRW3zq2DheYc0sMJjkw=;\n\tb=hX3EEjz7nUH3yuawhY+pB5qJUjxVg8F0z0yqDYNUVmwthF2jlNYDK4UbZirDSO2WMZ\n\tQKV6TjBKMqTQ37io77mej8rdZtlb8bOD0R23scFp+lefigi+QpRIeEot58ogYnpP0Z1Z\n\tHQIWeBSfKCquUn1/bh8AlIUwQTltsCKXStHhY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-type\n\t:content-transfer-encoding;\n\tbh=6VM6R6/hJoGrZ529szPOARfBxRW3zq2DheYc0sMJjkw=;\n\tb=clGyzwVKg5jId+GsZO0fQNmP0u7v3/MmtE4RHLlh82jp0AuC7ZQbuk8zLmepgABGyZ\n\tkBN3cIamyFeiSA4RsKy8vsD3QoiPavj93xUJP0v6tZ4wSAmC8q0kIB360VrSqgFf0/xa\n\t8+qCd9YplAh4o6ZwahsF4m4aHb/tBZV7UNhGlZKizyVW76RihY+1xVx1ONsbITifr5tn\n\tec77aGRnMHho9/4XaJ2xH3dy7SFfUhlt4sUDAHGhxQ7aD0LVYOckTPko8cFHQA8cIn+o\n\tKN0BOyT/l3hjMHxOJW4pWhqeektD2qDwUNu/Ggs3j2+JftyWEPuwvU78EtycCv46bZkN\n\tjCfw==", "X-Gm-Message-State": "ALoCoQlQSXgUOvtOmmhXfD51FDDbOcsrrg+bijZNo6gzeWQQWduDUkO/WazoSB5HVgiftBbu/of2", "X-Received": "by 10.68.110.165 with SMTP id ib5mr509907pbb.58.1443565191718;\n\tTue, 29 Sep 2015 15:19:51 -0700 (PDT)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Date": "Tue, 29 Sep 2015 15:19:50 -0700", "Message-ID": "<20150929221950.3388.63535.stgit@ahduyck-vm-fedora22>", "In-Reply-To": "<20150929215117.3388.48642.stgit@ahduyck-vm-fedora22>", "References": "<20150929215117.3388.48642.stgit@ahduyck-vm-fedora22>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 2/3] i40e/i40evf: use\n\tnapi_schedule_irqoff()", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The i40e_intr and i40e/i40evf_msix_clean_rings functions run from hard\ninterrupt context or with interrupts already disabled in netpoll.\n\nThey can use napi_schedule_irqoff() instead of napi_schedule()\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++++--\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-\n 2 files changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 484226e0365d..3cc97d4f5f70 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -3281,7 +3281,7 @@ static irqreturn_t i40e_msix_clean_rings(int irq, void *data)\n \tif (!q_vector->tx.ring && !q_vector->rx.ring)\n \t\treturn IRQ_HANDLED;\n \n-\tnapi_schedule(&q_vector->napi);\n+\tnapi_schedule_irqoff(&q_vector->napi);\n \n \treturn IRQ_HANDLED;\n }\n@@ -3450,6 +3450,8 @@ static irqreturn_t i40e_intr(int irq, void *data)\n \n \t/* only q0 is used in MSI/Legacy mode, and none are used in MSIX */\n \tif (icr0 & I40E_PFINT_ICR0_QUEUE_0_MASK) {\n+\t\tstruct i40e_vsi *vsi = pf->vsi[pf->lan_vsi];\n+\t\tstruct i40e_q_vector *q_vector = vsi->q_vectors[0];\n \n \t\t/* temporarily disable queue cause for NAPI processing */\n \t\tu32 qval = rd32(hw, I40E_QINT_RQCTL(0));\n@@ -3462,7 +3464,7 @@ static irqreturn_t i40e_intr(int irq, void *data)\n \t\twr32(hw, I40E_QINT_TQCTL(0), qval);\n \n \t\tif (!test_bit(__I40E_DOWN, &pf->state))\n-\t\t\tnapi_schedule(&pf->vsi[pf->lan_vsi]->q_vectors[0]->napi);\n+\t\t\tnapi_schedule_irqoff(&q_vector->napi);\n \t}\n \n \tif (icr0 & I40E_PFINT_ICR0_ADMINQ_MASK) {\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 5e1336321c2f..4b3db099f58c 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -334,7 +334,7 @@ static irqreturn_t i40evf_msix_clean_rings(int irq, void *data)\n \tif (!q_vector->tx.ring && !q_vector->rx.ring)\n \t\treturn IRQ_HANDLED;\n \n-\tnapi_schedule(&q_vector->napi);\n+\tnapi_schedule_irqoff(&q_vector->napi);\n \n \treturn IRQ_HANDLED;\n }\n", "prefixes": [ "2/3" ] }