Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/523547/?format=api
{ "id": 523547, "url": "http://patchwork.ozlabs.org/api/patches/523547/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443464220-148318-4-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1443464220-148318-4-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-09-28T18:16:52", "name": "[next,S17,03/11] i40e/i40evf: fix bug in throttle rate math", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e717398900e72f59c0b4f558a2d0423534130e61", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443464220-148318-4-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/523547/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/523547/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id B386B1400B7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Sep 2015 04:17:34 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0E4ED921EB;\n\tMon, 28 Sep 2015 18:17:34 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HSUc0kWqlJPc; Mon, 28 Sep 2015 18:17:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 10657921E3;\n\tMon, 28 Sep 2015 18:17:31 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id CA6371C1591\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:17:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C46993048E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:17:29 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xn27Iz+2svmy for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:17:29 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0477C32B76\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:17:28 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 28 Sep 2015 11:17:03 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby orsmga002.jf.intel.com with ESMTP; 28 Sep 2015 11:17:03 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,604,1437462000\"; d=\"scan'208\";a=\"814862571\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 28 Sep 2015 14:16:52 -0400", "Message-Id": "<1443464220-148318-4-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1443464220-148318-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1443464220-148318-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S17 03/11] i40e/i40evf: fix bug in\n\tthrottle rate math", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThe driver was using a value expressed in 2us increments\nfor the divisor to figure out our bytes/usec values.\n\nFix the usecs variable to contain a value in microseconds.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nChange-ID: I5c20493103c295d6f201947bb908add7040b7c41\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 9 ++++++++-\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 9 ++++++++-\n 2 files changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex c023b12..24e8f6b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -829,6 +829,7 @@ static bool i40e_set_new_dynamic_itr(struct i40e_ring_container *rc)\n \tenum i40e_latency_range new_latency_range = rc->latency_range;\n \tu32 new_itr = rc->itr;\n \tint bytes_per_int;\n+\tint usecs;\n \n \tif (rc->total_packets == 0 || !rc->itr)\n \t\treturn false;\n@@ -837,8 +838,14 @@ static bool i40e_set_new_dynamic_itr(struct i40e_ring_container *rc)\n \t * 0-10MB/s lowest (100000 ints/s)\n \t * 10-20MB/s low (20000 ints/s)\n \t * 20-1249MB/s bulk (8000 ints/s)\n+\t *\n+\t * The math works out because the divisor is in 10^(-6) which\n+\t * turns the bytes/us input value into MB/s values, but\n+\t * make sure to use usecs, as the register values written\n+\t * are in 2 usec increments in the ITR registers.\n \t */\n-\tbytes_per_int = rc->total_bytes / rc->itr;\n+\tusecs = (rc->itr << 1);\n+\tbytes_per_int = rc->total_bytes / usecs;\n \tswitch (new_latency_range) {\n \tcase I40E_LOWEST_LATENCY:\n \t\tif (bytes_per_int > 10)\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 3d2646b..3f4a595 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -333,6 +333,7 @@ static bool i40e_set_new_dynamic_itr(struct i40e_ring_container *rc)\n \tenum i40e_latency_range new_latency_range = rc->latency_range;\n \tu32 new_itr = rc->itr;\n \tint bytes_per_int;\n+\tint usecs;\n \n \tif (rc->total_packets == 0 || !rc->itr)\n \t\treturn false;\n@@ -341,8 +342,14 @@ static bool i40e_set_new_dynamic_itr(struct i40e_ring_container *rc)\n \t * 0-10MB/s lowest (100000 ints/s)\n \t * 10-20MB/s low (20000 ints/s)\n \t * 20-1249MB/s bulk (8000 ints/s)\n+\t *\n+\t * The math works out because the divisor is in 10^(-6) which\n+\t * turns the bytes/us input value into MB/s values, but\n+\t * make sure to use usecs, as the register values written\n+\t * are in 2 usec increments in the ITR registers.\n \t */\n-\tbytes_per_int = rc->total_bytes / rc->itr;\n+\tusecs = (rc->itr << 1);\n+\tbytes_per_int = rc->total_bytes / usecs;\n \tswitch (new_latency_range) {\n \tcase I40E_LOWEST_LATENCY:\n \t\tif (bytes_per_int > 10)\n", "prefixes": [ "next", "S17", "03/11" ] }