Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/523544/?format=api
{ "id": 523544, "url": "http://patchwork.ozlabs.org/api/patches/523544/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443463964-148204-14-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1443463964-148204-14-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-09-28T18:12:42", "name": "[next,S16,13/15] i40evf: relax and stagger init timing a bit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e9bec28ff9d8440b9a32d86a798f7e649c56a6b8", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443463964-148204-14-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/523544/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/523544/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 60C0C1400B7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Sep 2015 04:15:04 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0BE66954E7;\n\tMon, 28 Sep 2015 18:15:04 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zcwH9Y3tNvRr; Mon, 28 Sep 2015 18:15:02 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B0782954F4;\n\tMon, 28 Sep 2015 18:15:02 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8A6781CE9AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8694732E47\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:59 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jSDKCGCG9ewD for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:56 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby silver.osuosl.org (Postfix) with ESMTP id 49FDF33296\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:56 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga101.jf.intel.com with ESMTP; 28 Sep 2015 11:14:32 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby FMSMGA003.fm.intel.com with ESMTP; 28 Sep 2015 11:14:32 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,603,1437462000\"; d=\"scan'208\";a=\"569972255\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 28 Sep 2015 14:12:42 -0400", "Message-Id": "<1443463964-148204-14-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1443463964-148204-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1443463964-148204-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S16 13/15] i40evf: relax and stagger\n\tinit timing a bit", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nOn some devices, in some systems, in some configurations, the VFs would\nfail to initialize the first time you loaded the driver.\n\nTo correct this, increase the delay time for the init task slightly, and\nwait longer before giving up.\n\nIf we enable VFs and load the VF driver in the same kernel as the PF\ndriver, we can totally overwhelm the PF driver with AQ requests because\nall of the instances try to initialize at the same time.\n\nTo help alleviate this, stagger the initial scheduling of the init task\nusing the PCIe function as a multiplier. We mask off the function to\nonly three bits so no instance has to wait too long.\n\nWith these two changes, initializing 128 VFs on a single device goes\nfrom four minutes to just a few seconds.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: If3d8720c1c4e838ab36d8781d9ec295a62380936\n---\n drivers/net/ethernet/intel/i40evf/i40evf.h | 2 +-\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf.h b/drivers/net/ethernet/intel/i40evf/i40evf.h\nindex e18e413..d6cd2c8 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf.h\n@@ -87,7 +87,7 @@ struct i40e_vsi {\n #define I40EVF_MAX_RXBUFFER 16384 /* largest size for single descriptor */\n #define I40EVF_MAX_AQ_BUF_SIZE 4096\n #define I40EVF_AQ_LEN 32\n-#define I40EVF_AQ_MAX_ERR 10 /* times to try before resetting AQ */\n+#define I40EVF_AQ_MAX_ERR 20 /* times to try before resetting AQ */\n \n #define MAXIMUM_ETHERNET_VLAN_SIZE (VLAN_ETH_FRAME_LEN + ETH_FCS_LEN)\n \ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 9e754d0..b943d93 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -2344,7 +2344,7 @@ static void i40evf_init_task(struct work_struct *work)\n \t}\n \treturn;\n restart:\n-\tschedule_delayed_work(&adapter->init_task, msecs_to_jiffies(20));\n+\tschedule_delayed_work(&adapter->init_task, msecs_to_jiffies(30));\n \treturn;\n \n err_register:\n@@ -2361,7 +2361,7 @@ err:\n \t\tadapter->flags |= I40EVF_FLAG_PF_COMMS_FAILED;\n \t\treturn; /* do not reschedule */\n \t}\n-\tschedule_delayed_work(&adapter->init_task, HZ / 2);\n+\tschedule_delayed_work(&adapter->init_task, HZ);\n }\n \n /**\n", "prefixes": [ "next", "S16", "13/15" ] }