Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/523533/?format=api
{ "id": 523533, "url": "http://patchwork.ozlabs.org/api/patches/523533/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443463964-148204-4-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1443463964-148204-4-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-09-28T18:12:32", "name": "[next,S16,03/15] i40e: remove read/write failed messages from nvmupdate", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5320e79bbf7c6329a31cbe4262525663c6ee2438", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443463964-148204-4-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/523533/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/523533/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 2E67F1400B7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Sep 2015 04:14:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7035F954FE;\n\tMon, 28 Sep 2015 18:14:48 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lu-XLCs0jfYC; Mon, 28 Sep 2015 18:14:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0529A954C0;\n\tMon, 28 Sep 2015 18:14:48 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1179E1CE9AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0C711A3B7D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:46 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MhjhijlaqoPI for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:45 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A8703A3B7A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:45 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga101.jf.intel.com with ESMTP; 28 Sep 2015 11:14:20 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby FMSMGA003.fm.intel.com with ESMTP; 28 Sep 2015 11:14:20 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,603,1437462000\"; d=\"scan'208\";a=\"569972105\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 28 Sep 2015 14:12:32 -0400", "Message-Id": "<1443463964-148204-4-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1443463964-148204-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1443463964-148204-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S16 03/15] i40e: remove read/write\n\tfailed messages from nvmupdate", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nAllow the nvmupdate application to decide when a read or write error\nshould be exposed to the user. Since the application needs to use\nwrite probes to find the ReadOnly sections on a potentially unknown NVM\nversion in the HW and read probes to check the status of the last write,\nsome error messages are expected, but need not be shown to the users.\nThe driver doesn't know which are ignorable from real errors, so needs\nto let the application make the decision.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nChange-ID: I78fca8ab672bede11c10c820b83c26adfd536d03\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 0d5aecf..0ea71c0 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -993,9 +993,7 @@ static int i40e_get_eeprom(struct net_device *netdev,\n \n \t\tcmd = (struct i40e_nvm_access *)eeprom;\n \t\tret_val = i40e_nvmupd_command(hw, cmd, bytes, &errno);\n-\t\tif (ret_val &&\n-\t\t ((hw->aq.asq_last_status != I40E_AQ_RC_EACCES) ||\n-\t\t (hw->debug_mask & I40E_DEBUG_NVM)))\n+\t\tif (ret_val && (hw->debug_mask & I40E_DEBUG_NVM))\n \t\t\tdev_info(&pf->pdev->dev,\n \t\t\t\t \"NVMUpdate read failed err=%d status=0x%x errno=%d module=%d offset=0x%x size=%d\\n\",\n \t\t\t\t ret_val, hw->aq.asq_last_status, errno,\n@@ -1099,10 +1097,7 @@ static int i40e_set_eeprom(struct net_device *netdev,\n \n \tcmd = (struct i40e_nvm_access *)eeprom;\n \tret_val = i40e_nvmupd_command(hw, cmd, bytes, &errno);\n-\tif (ret_val &&\n-\t ((hw->aq.asq_last_status != I40E_AQ_RC_EPERM &&\n-\t hw->aq.asq_last_status != I40E_AQ_RC_EBUSY) ||\n-\t (hw->debug_mask & I40E_DEBUG_NVM)))\n+\tif (ret_val && (hw->debug_mask & I40E_DEBUG_NVM))\n \t\tdev_info(&pf->pdev->dev,\n \t\t\t \"NVMUpdate write failed err=%d status=0x%x errno=%d module=%d offset=0x%x size=%d\\n\",\n \t\t\t ret_val, hw->aq.asq_last_status, errno,\n", "prefixes": [ "next", "S16", "03/15" ] }