Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/523532/?format=api
{ "id": 523532, "url": "http://patchwork.ozlabs.org/api/patches/523532/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443463964-148204-3-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1443463964-148204-3-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-09-28T18:12:31", "name": "[next,S16,02/15] i40e/i40evf: Fix compile issue related to const string", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d827c4b4cc14ad309827b6df9f48018efd6aa0e7", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443463964-148204-3-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/523532/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/523532/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 03A951400B7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Sep 2015 04:14:47 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 51E49954F4;\n\tMon, 28 Sep 2015 18:14:47 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id B3GUIT-cRuW5; Mon, 28 Sep 2015 18:14:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D319E954BE;\n\tMon, 28 Sep 2015 18:14:45 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 52E4C1CE9AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4E0F1A3B7A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:45 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1dtSsrJaOrr6 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:44 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B0A83A3B58\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Sep 2015 18:14:44 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga101.jf.intel.com with ESMTP; 28 Sep 2015 11:14:19 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby FMSMGA003.fm.intel.com with ESMTP; 28 Sep 2015 11:14:19 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,603,1437462000\"; d=\"scan'208\";a=\"569972089\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 28 Sep 2015 14:12:31 -0400", "Message-Id": "<1443463964-148204-3-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1443463964-148204-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1443463964-148204-1-git-send-email-catherine.sullivan@intel.com>", "Cc": "Jingjing Wu <jingjing.wu@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S16 02/15] i40e/i40evf: Fix compile\n\tissue related to const string", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jingjing Wu <jingjing.wu@intel.com>\n\nAdd const to functions that return strings that aren't going to be\nmodified. This addresses some reported compile complaints.\n\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\nChange-ID: Ic56b1e814ab4d23a50480e7fdec652445f776ee8\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++--\n drivers/net/ethernet/intel/i40e/i40e_nvm.c | 2 +-\n drivers/net/ethernet/intel/i40e/i40e_prototype.h | 4 ++--\n drivers/net/ethernet/intel/i40evf/i40e_common.c | 4 ++--\n drivers/net/ethernet/intel/i40evf/i40e_prototype.h | 4 ++--\n 5 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex a6ea6be..01d5f0b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -87,7 +87,7 @@ static i40e_status i40e_set_mac_type(struct i40e_hw *hw)\n * @hw: pointer to the HW structure\n * @aq_err: the AQ error code to convert\n **/\n-char *i40e_aq_str(struct i40e_hw *hw, enum i40e_admin_queue_err aq_err)\n+const char *i40e_aq_str(struct i40e_hw *hw, enum i40e_admin_queue_err aq_err)\n {\n \tswitch (aq_err) {\n \tcase I40E_AQ_RC_OK:\n@@ -147,7 +147,7 @@ char *i40e_aq_str(struct i40e_hw *hw, enum i40e_admin_queue_err aq_err)\n * @hw: pointer to the HW structure\n * @stat_err: the status error code to convert\n **/\n-char *i40e_stat_str(struct i40e_hw *hw, i40e_status stat_err)\n+const char *i40e_stat_str(struct i40e_hw *hw, i40e_status stat_err)\n {\n \tswitch (stat_err) {\n \tcase 0:\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_nvm.c b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\nindex 21572be..58e384a 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n@@ -651,7 +651,7 @@ static inline u8 i40e_nvmupd_get_transaction(u32 val)\n \treturn (u8)((val & I40E_NVM_TRANS_MASK) >> I40E_NVM_TRANS_SHIFT);\n }\n \n-static char *i40e_nvm_update_state_str[] = {\n+static const char * const i40e_nvm_update_state_str[] = {\n \t\"I40E_NVMUPD_INVALID\",\n \t\"I40E_NVMUPD_READ_CON\",\n \t\"I40E_NVMUPD_READ_SNT\",\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_prototype.h b/drivers/net/ethernet/intel/i40e/i40e_prototype.h\nindex 0e2bfb1ad..642c9aa5 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_prototype.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_prototype.h\n@@ -58,8 +58,8 @@ void i40e_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask,\n void i40e_idle_aq(struct i40e_hw *hw);\n bool i40e_check_asq_alive(struct i40e_hw *hw);\n i40e_status i40e_aq_queue_shutdown(struct i40e_hw *hw, bool unloading);\n-char *i40e_aq_str(struct i40e_hw *hw, enum i40e_admin_queue_err aq_err);\n-char *i40e_stat_str(struct i40e_hw *hw, i40e_status stat_err);\n+const char *i40e_aq_str(struct i40e_hw *hw, enum i40e_admin_queue_err aq_err);\n+const char *i40e_stat_str(struct i40e_hw *hw, i40e_status stat_err);\n \n i40e_status i40e_aq_get_rss_lut(struct i40e_hw *hw, u16 seid,\n \t\t\t\tbool pf_lut, u8 *lut, u16 lut_size);\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c b/drivers/net/ethernet/intel/i40evf/i40e_common.c\nindex b98b642..7435fb3 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c\n@@ -87,7 +87,7 @@ i40e_status i40e_set_mac_type(struct i40e_hw *hw)\n * @hw: pointer to the HW structure\n * @aq_err: the AQ error code to convert\n **/\n-char *i40evf_aq_str(struct i40e_hw *hw, enum i40e_admin_queue_err aq_err)\n+const char *i40evf_aq_str(struct i40e_hw *hw, enum i40e_admin_queue_err aq_err)\n {\n \tswitch (aq_err) {\n \tcase I40E_AQ_RC_OK:\n@@ -147,7 +147,7 @@ char *i40evf_aq_str(struct i40e_hw *hw, enum i40e_admin_queue_err aq_err)\n * @hw: pointer to the HW structure\n * @stat_err: the status error code to convert\n **/\n-char *i40evf_stat_str(struct i40e_hw *hw, i40e_status stat_err)\n+const char *i40evf_stat_str(struct i40e_hw *hw, i40e_status stat_err)\n {\n \tswitch (stat_err) {\n \tcase 0:\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_prototype.h b/drivers/net/ethernet/intel/i40evf/i40e_prototype.h\nindex 55ae4b0..8ed0edf 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_prototype.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_prototype.h\n@@ -60,8 +60,8 @@ void i40e_idle_aq(struct i40e_hw *hw);\n void i40evf_resume_aq(struct i40e_hw *hw);\n bool i40evf_check_asq_alive(struct i40e_hw *hw);\n i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw, bool unloading);\n-char *i40evf_aq_str(struct i40e_hw *hw, enum i40e_admin_queue_err aq_err);\n-char *i40evf_stat_str(struct i40e_hw *hw, i40e_status stat_err);\n+const char *i40evf_aq_str(struct i40e_hw *hw, enum i40e_admin_queue_err aq_err);\n+const char *i40evf_stat_str(struct i40e_hw *hw, i40e_status stat_err);\n \n i40e_status i40evf_aq_get_rss_lut(struct i40e_hw *hw, u16 seid,\n \t\t\t\t bool pf_lut, u8 *lut, u16 lut_size);\n", "prefixes": [ "next", "S16", "02/15" ] }