Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/523145/?format=api
{ "id": 523145, "url": "http://patchwork.ozlabs.org/api/patches/523145/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/CAEvZX5eZjLdD9O97EUXiBqWcnfoHrVp93tfVEHt7Mk2tEanr4A@mail.gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<CAEvZX5eZjLdD9O97EUXiBqWcnfoHrVp93tfVEHt7Mk2tEanr4A@mail.gmail.com>", "list_archive_url": null, "date": "2015-09-27T10:36:22", "name": "igb: garbled \"ethtool -m\" output in igb-driven NICs, patch for igb_get_module_eeprom()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "23d7650ed4554c18747ffba22f9fd1d3d20f0864", "submitter": { "id": 67295, "url": "http://patchwork.ozlabs.org/api/people/67295/?format=api", "name": "Doron Shikmoni", "email": "doron.shikmoni@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/CAEvZX5eZjLdD9O97EUXiBqWcnfoHrVp93tfVEHt7Mk2tEanr4A@mail.gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/523145/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/523145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id B7E431402A2\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 27 Sep 2015 20:36:31 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id EDF3A33375;\n\tSun, 27 Sep 2015 10:36:30 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id uY2jpJWljW0I; Sun, 27 Sep 2015 10:36:26 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5B63433389;\n\tSun, 27 Sep 2015 10:36:26 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E85771C10F7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 27 Sep 2015 10:36:24 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E3AA487531\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 27 Sep 2015 10:36:24 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VewpRSPreFp1 for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 27 Sep 2015 10:36:24 +0000 (UTC)", "from mail-wi0-f182.google.com (mail-wi0-f182.google.com\n\t[209.85.212.182])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 19CE087FF1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 27 Sep 2015 10:36:24 +0000 (UTC)", "by wicfx3 with SMTP id fx3so66895238wic.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 27 Sep 2015 03:36:22 -0700 (PDT)", "by 10.194.133.169 with HTTP; Sun, 27 Sep 2015 03:36:22 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=gnu3qxQp;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=mime-version:date:message-id:subject:from:to:content-type;\n\tbh=HjDhqAHedSsvFzN7YeYga2nSPpZsGQ+6PBTgQdJATY4=;\n\tb=gnu3qxQppXw+L9ODnguI2A093EtvJrJxFcYfgy/rIm1tvySU0kWbverXHPOyUBdaMb\n\tX3ZmRUeNAdHqJlZNVAx43W13FK0mfZ3IBXu06AhApVzaN+TxWZJl8iqPDX4vxPuq5vt7\n\tm3B5/t9g8Eho5XZuNHyu70fseE+Nns1xDQr3RSZ/RGYWc1fTbqRefI205SPh1lXzfCpL\n\tI+UCzzMHvU4nNINb6PfW99u5hS+0ibsP79ojBeyd9KY9YQpsKSvkjGvq8egU2zPiPrMh\n\tEOAT3xaGlUE9Iur/TEYAf7XqkOwps0ZQJf3SdBVCM/dKweGUvxKCcLd5yWHTo8/2Bkfg\n\tl9SA==", "MIME-Version": "1.0", "X-Received": "by 10.180.89.101 with SMTP id bn5mr12076955wib.20.1443350182379; \n\tSun, 27 Sep 2015 03:36:22 -0700 (PDT)", "Date": "Sun, 27 Sep 2015 13:36:22 +0300", "Message-ID": "<CAEvZX5eZjLdD9O97EUXiBqWcnfoHrVp93tfVEHt7Mk2tEanr4A@mail.gmail.com>", "From": "Doron Shikmoni <doron.shikmoni@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] igb: garbled \"ethtool -m\" output in\n\tigb-driven NICs, patch for igb_get_module_eeprom()", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "multipart/mixed;\n\tboundary=\"===============5859558772779123159==\"", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "For igb-driven NICs with module/plugin EEPROM, \"ethtool -m ethX\" provides\ngarbled output (every time). Each data byte appears to be duplicated.\n\nThe issue is within igb_get_module_eeprom() in igb_ethtool.c. In the reading\nof the EEPROM via i2c, the eeprom offset for each word that's read via\nigb_read_phy_reg_i2c() is passed in #words, whereas it needs to be a byte\noffset.\n\nSigned-off-by: Doron Shikmoni <doron.shikmoni@gmail.com>\n---\n\nProposed patch tested; with this patch applied, the output of \"ethtool -m\"\nappears perfect. It'd be great if you could push this into the main tree.\n\n[ \"(first_word + i ) * 2\" and not \"ee->offset + i\", due to word boundary ]\n\n\n /* Error occurred while reading module */\n kfree(dataword);", "diff": "diff -up igb_ethtool.c igb_ethtool.c.patched\n--- igb_ethtool.c\n+++ igb_ethtool.c.patched\n@@ -2808,7 +2808,7 @@ static int igb_get_module_eeprom(struct\n\n /* Read EEPROM block, SFF-8079/SFF-8472, word at a time */\n for (i = 0; i < last_word - first_word + 1; i++) {\n- status = igb_read_phy_reg_i2c(hw, first_word + i,\n&dataword[i]);\n+ status = igb_read_phy_reg_i2c(hw, (first_word + i) * 2,\n&dataword[i]);\n if (status) {\n", "prefixes": [] }