Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/522508/?format=api
{ "id": 522508, "url": "http://patchwork.ozlabs.org/api/patches/522508/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443122442-21345-1-git-send-email-jesse.brandeburg@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1443122442-21345-1-git-send-email-jesse.brandeburg@intel.com>", "list_archive_url": null, "date": "2015-09-24T19:20:42", "name": "[net,v1] i40e: fix recursive rtnl lock", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "4cf0558a87a26d2a4493b19137319f60aca0c91b", "submitter": { "id": 189, "url": "http://patchwork.ozlabs.org/api/people/189/?format=api", "name": "Jesse Brandeburg", "email": "jesse.brandeburg@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1443122442-21345-1-git-send-email-jesse.brandeburg@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/522508/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/522508/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 6359C140271\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 25 Sep 2015 05:20:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 50496914F7;\n\tThu, 24 Sep 2015 19:20:47 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XCzVTNRPYb+k; Thu, 24 Sep 2015 19:20:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 234EE914F1;\n\tThu, 24 Sep 2015 19:20:45 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1E27F1CEC1A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Sep 2015 19:20:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 19C338755C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Sep 2015 19:20:44 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YokmjGCLiREN for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Sep 2015 19:20:43 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4F80A8753E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Sep 2015 19:20:43 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 24 Sep 2015 12:20:43 -0700", "from jbrandeb-cp2.jf.intel.com ([134.134.3.139])\n\tby orsmga003.jf.intel.com with ESMTP; 24 Sep 2015 12:20:43 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,582,1437462000\"; d=\"scan'208\";a=\"651704926\"", "From": "Jesse Brandeburg <jesse.brandeburg@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 24 Sep 2015 12:20:42 -0700", "Message-Id": "<1443122442-21345-1-git-send-email-jesse.brandeburg@intel.com>", "X-Mailer": "git-send-email 2.4.3", "Subject": "[Intel-wired-lan] [net PATCH v1] i40e: fix recursive rtnl lock", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Anjali Singhai Jain <anjali.singhai@intel.com>\n\nThe sync_vsi_filters function can be called directly under RTNL\nor through the timer subtask without one. This was causing\na deadlock.\n\nIf sync_vsi_filter is called from a thread which held the lock,\nand in another thread the PROMISC setting got changed we would be\nexecuting the PROMISC change in the thread which already held the\nlock alongside the other filter update. The PROMISC change\nrequires a reset if we are on a VEB, which requires it to be\ncalled under RTNL.\n\nEarlier the driver would call reset for PROMISC change without\nchecking if we were already under RTNL and would try to grab\nit causing a deadlock. This patch changes the flow to see if we\nare already under RTNL before trying to grab it.\n\nSigned-off-by: Anjali Singhai Jain <anjali.singhai@intel.com>\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nReviewed-by: Kiran Patil <kiran.patil@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 3410fb3..7557c02 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -5340,9 +5340,13 @@ exit:\n **/\n void i40e_do_reset_safe(struct i40e_pf *pf, u32 reset_flags)\n {\n-\trtnl_lock();\n-\ti40e_do_reset(pf, reset_flags);\n-\trtnl_unlock();\n+\tif (!rtnl_is_locked()) {\n+\t\trtnl_lock();\n+\t\ti40e_do_reset(pf, reset_flags);\n+\t\trtnl_unlock();\n+\t} else {\n+\t\ti40e_do_reset(pf, reset_flags);\n+\t}\n }\n \n /**\n", "prefixes": [ "net", "v1" ] }