Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/522400/?format=api
{ "id": 522400, "url": "http://patchwork.ozlabs.org/api/patches/522400/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150924160426.22015.37868.stgit@ahduyck-vm-fedora22/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150924160426.22015.37868.stgit@ahduyck-vm-fedora22>", "list_archive_url": null, "date": "2015-09-24T16:04:26", "name": "[net-next,v2,1/3] i40e/i40evf: Fix handling of napi budget", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cba75b4a9fb0af9838e9682b9bc598f2b212582a", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150924160426.22015.37868.stgit@ahduyck-vm-fedora22/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/522400/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/522400/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 4224A140281\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 25 Sep 2015 02:04:32 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 68CD695D64;\n\tThu, 24 Sep 2015 16:04:31 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jtKK6gkf67tv; Thu, 24 Sep 2015 16:04:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E0EC195D60;\n\tThu, 24 Sep 2015 16:04:30 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id A006A1CEC1A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Sep 2015 16:04:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9A84895D60\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Sep 2015 16:04:29 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id uPC-fmEmK8ct for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Sep 2015 16:04:28 +0000 (UTC)", "from mail-pa0-f45.google.com (mail-pa0-f45.google.com\n\t[209.85.220.45])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 1A37C95D61\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Sep 2015 16:04:28 +0000 (UTC)", "by pacgz1 with SMTP id gz1so10227310pac.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Sep 2015 09:04:27 -0700 (PDT)", "from [192.168.122.149] (50-43-10-6.bvtn.or.frontiernet.net.\n\t[50.43.10.6]) by smtp.gmail.com with ESMTPSA id\n\tco4sm14342562pbb.91.2015.09.24.09.04.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 24 Sep 2015 09:04:27 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=WLU0f8cx; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-type:content-transfer-encoding;\n\tbh=vKHiigswcFRghg6295vWeooTRKT0AS+lbiXVDu2YyLE=;\n\tb=WLU0f8cxZCObvPYEAD/V8VReUTwX0BYt+4AFYuEK5y4GimIaLVkqmSt8hTsaQx3vmm\n\tGMxLyuwvd6CQrvvJt0zoKUuM9m1WUI5Qu3KbIe48N/MR6mlJJl+6FI2FAprYp2ryGcWr\n\t25JQ1dIBw5kLHgKwcOLcMYwhkcKPiBV3iwPYE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-type\n\t:content-transfer-encoding;\n\tbh=vKHiigswcFRghg6295vWeooTRKT0AS+lbiXVDu2YyLE=;\n\tb=dM6zX6ihTVwUDBoHdKRamlai1E0GsL7h3njSNj71c3rOxf4SKWjcF97E1Dit2/Xt5Q\n\tZKrjANIPdc6nyZSx3kZVLqP5kfmZhSH6PVmDOGEmIGUVStyHwLE/+wNDV7lyOGxoWemJ\n\tWLRL68c4oYzD4+l7Cm9Da5JP2gh2XxBSbqt3IoSxF9SBPeciqMoi6KkZhif0DWxR76EH\n\tWOyUJ/9cjzFK8iViDmQepo+XbtDyAqL13bS6hmnszC2juTUlwA7xISpJ4zTH8pxmDcaT\n\tCgXge3CnswTsHgOquojPXwMuEg/bWSWAZoODN8Du/GDcxznsVPkiam0eYlv60Bft8aW3\n\tHNgw==", "X-Gm-Message-State": "ALoCoQkeUrwJ98qrzHwFyWmAjXw1GLSa2lrXpZjHzzEEXYYclErdVxytJtcuOT+8uoYzoiIKjJT0", "X-Received": "by 10.68.89.100 with SMTP id bn4mr510148pbb.93.1443110667756;\n\tThu, 24 Sep 2015 09:04:27 -0700 (PDT)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Date": "Thu, 24 Sep 2015 09:04:26 -0700", "Message-ID": "<20150924160426.22015.37868.stgit@ahduyck-vm-fedora22>", "In-Reply-To": "<20150924160027.22015.15754.stgit@ahduyck-vm-fedora22>", "References": "<20150924160027.22015.15754.stgit@ahduyck-vm-fedora22>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net-next PATCH v2 1/3] i40e/i40evf: Fix handling\n\tof napi budget", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The polling routine for i40e was rounding up the budget for Rx cleanup to\n1. This is incorrect as the netpoll poll call is expecting no Rx to be\nprocessed as the budget passed was 0.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 5 +++++\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 5 +++++\n 2 files changed, 10 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex d51b8edebfee..66b1fd26f0fc 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -1923,6 +1923,10 @@ int i40e_napi_poll(struct napi_struct *napi, int budget)\n \t\tring->arm_wb = false;\n \t}\n \n+\t/* Handle case where we are called by netpoll with a budget of 0 */\n+\tif (budget <= 0)\n+\t\tgoto tx_only;\n+\n \t/* We attempt to distribute budget to each Rx queue fairly, but don't\n \t * allow the budget to go below 1 because that would exit polling early.\n \t */\n@@ -1939,6 +1943,7 @@ int i40e_napi_poll(struct napi_struct *napi, int budget)\n \n \t/* If work not completed, return budget and polling will return */\n \tif (!clean_complete) {\n+tx_only:\n \t\tif (arm_wb)\n \t\t\ti40e_force_wb(vsi, q_vector);\n \t\treturn budget;\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 7b20f53a414a..c60e9cf016c2 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -1367,6 +1367,10 @@ int i40evf_napi_poll(struct napi_struct *napi, int budget)\n \t\tring->arm_wb = false;\n \t}\n \n+\t/* Handle case where we are called by netpoll with a budget of 0 */\n+\tif (budget <= 0)\n+\t\tgoto tx_only;\n+\n \t/* We attempt to distribute budget to each Rx queue fairly, but don't\n \t * allow the budget to go below 1 because that would exit polling early.\n \t */\n@@ -1383,6 +1387,7 @@ int i40evf_napi_poll(struct napi_struct *napi, int budget)\n \n \t/* If work not completed, return budget and polling will return */\n \tif (!clean_complete) {\n+tx_only:\n \t\tif (arm_wb)\n \t\t\ti40e_force_wb(vsi, q_vector);\n \t\treturn budget;\n", "prefixes": [ "net-next", "v2", "1/3" ] }