Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/519710/?format=api
{ "id": 519710, "url": "http://patchwork.ozlabs.org/api/patches/519710/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1442660927-30431-1-git-send-email-sakiwit@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1442660927-30431-1-git-send-email-sakiwit@gmail.com>", "list_archive_url": null, "date": "2015-09-19T11:08:40", "name": "[next-queue,v2,1/8] e1000: clean up the checking logic", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a096deea8b082586f2a7f5f52923060573dc0fee", "submitter": { "id": 8799, "url": "http://patchwork.ozlabs.org/api/people/8799/?format=api", "name": "Jεan Sacren", "email": "sakiwit@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1442660927-30431-1-git-send-email-sakiwit@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/519710/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/519710/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 118DE140216\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 19 Sep 2015 21:06:10 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 230AB8A65F;\n\tSat, 19 Sep 2015 11:06:09 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YoLzStZAw88R; Sat, 19 Sep 2015 11:06:04 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5134688287;\n\tSat, 19 Sep 2015 11:06:04 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 01E251BFE29\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 19 Sep 2015 11:06:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F0CF390E0E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 19 Sep 2015 11:06:01 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4eC-lfTBKDpD for <intel-wired-lan@lists.osuosl.org>;\n\tSat, 19 Sep 2015 11:06:01 +0000 (UTC)", "from mail-pa0-f48.google.com (mail-pa0-f48.google.com\n\t[209.85.220.48])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 4E0F290D90\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 19 Sep 2015 11:06:01 +0000 (UTC)", "by pacfv12 with SMTP id fv12so74617229pac.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 19 Sep 2015 04:06:01 -0700 (PDT)", "from localhost ([67.214.236.25]) by smtp.gmail.com with ESMTPSA id\n\tql5sm13994354pac.46.2015.09.19.04.06.00\n\t(version=TLS1_2 cipher=AES128-GCM-SHA256 bits=128/128);\n\tSat, 19 Sep 2015 04:06:00 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=HJiYKCoo;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id;\n\tbh=pjv5OT1Nga9lotsyXeYwAoW4iBqriwtXgw/UwF4ifWw=;\n\tb=HJiYKCooOZHLDWXISIbGKO89xfrBbgaEosPHhA7PZuUWMpV5llP6srZAyyek1IE2H2\n\tycoi5tIBzjhp9X+aGDNYNEfHcqIcIPO8j9WAoZmaTEh1gEWVpbqDTBddBiWAJuCYMMBv\n\tDGbkeGnUfHTVqkZs8A/VA/Ca52AXJ/xcVwAHA+KAWZpMw9+4DVH9Qs1yv8aOT4qSC96D\n\tUWS9Q5kPi6O/rxh9BfoSQiWK3tqD6NltgI+tONvnSDBL6jj/OQF7mWtdJe8fl5/1fSCC\n\tvosarb/Pq8hQJV3O8M/xSQhdtE7sDbEaXmdw1iFHBgl072Jvi6FW+XO5hstEZjjg4Fz2\n\ttX2w==", "X-Received": "by 10.66.164.230 with SMTP id yt6mr12498309pab.149.1442660761083;\n\tSat, 19 Sep 2015 04:06:01 -0700 (PDT)", "From": "=?UTF-8?q?J=CE=B5an=20Sacren?= <sakiwit@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Sat, 19 Sep 2015 05:08:40 -0600", "Message-Id": "<1442660927-30431-1-git-send-email-sakiwit@gmail.com>", "X-Mailer": "git-send-email 2.4.6", "Subject": "[Intel-wired-lan] [next-queue v2 1/8] e1000: clean up the checking\n\tlogic", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jean Sacren <sakiwit@gmail.com>\n\nThe checking logic needed some clean-up work, so we rewrite it by\nchecking for break first. With that change in place, we can even move\nthe second check for goto statement outside of the loop.\n\nAs this is merely a cleanup, no functional change is involved. The\nquestionable 'tmp != 0xFF' is intentionally left alone.\n\nMark Rustad and Alexander Duyck contributed to this patch.\n\nSigned-off-by: Jean Sacren <sakiwit@gmail.com>\nCc: \"Rustad, Mark D\" <mark.d.rustad@intel.com>\nCc: Alexander Duyck <alexander.duyck@gmail.com>\n---\nv2:\n\n1) Update the changelog to reflect the rewrite of the checking logic and\n others' contributions;\n2) Update the changelog title accordingly;\n3) Add credits and cc the pertinent parties.\n\n drivers/net/ethernet/intel/e1000/e1000_main.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c\nindex 97e38cee649f..5ba8d13a068c 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_main.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c\n@@ -1199,13 +1199,13 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\tfor (i = 0; i < 32; i++) {\n \t\t\thw->phy_addr = i;\n \t\t\te1000_read_phy_reg(hw, PHY_ID2, &tmp);\n-\t\t\tif (tmp == 0 || tmp == 0xFF) {\n-\t\t\t\tif (i == 31)\n-\t\t\t\t\tgoto err_eeprom;\n-\t\t\t\tcontinue;\n-\t\t\t} else\n+\n+\t\t\tif (tmp != 0 && tmp != 0xFF)\n \t\t\t\tbreak;\n \t\t}\n+\n+\t\tif (i >= 32)\n+\t\t\tgoto err_eeprom;\n \t}\n \n \t/* reset the hardware with the new settings */\n", "prefixes": [ "next-queue", "v2", "1/8" ] }