Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/518827/?format=api
{ "id": 518827, "url": "http://patchwork.ozlabs.org/api/patches/518827/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1442493970-20073-1-git-send-email-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1442493970-20073-1-git-send-email-sassmann@kpanic.de>", "list_archive_url": null, "date": "2015-09-17T12:46:10", "name": "[net-next] igb: assume MSI-X interrupts during initialization", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "04ea2a977a854fde9106294eebe3b458751fce7c", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1442493970-20073-1-git-send-email-sassmann@kpanic.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/518827/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/518827/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 24ABE14090A\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 17 Sep 2015 22:46:36 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 69E8A8A896;\n\tThu, 17 Sep 2015 12:46:35 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hnsfvvd4BKzO; Thu, 17 Sep 2015 12:46:34 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 51DB488C1B;\n\tThu, 17 Sep 2015 12:46:34 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6F6ED1BFC00\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 Sep 2015 12:46:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 695AF8ABBF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 Sep 2015 12:46:33 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7ijtH5swyvdp for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 Sep 2015 12:46:32 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 539AD8ABA2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 Sep 2015 12:46:31 +0000 (UTC)", "from int-mx11.intmail.prod.int.phx2.redhat.com\n\t(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])\n\tby mx1.redhat.com (Postfix) with ESMTPS id 084582F90D2;\n\tThu, 17 Sep 2015 12:46:30 +0000 (UTC)", "from w541.redhat.com (ovpn-116-98.ams2.redhat.com [10.36.116.98])\n\tby int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id t8HCkSju020790; Thu, 17 Sep 2015 08:46:29 -0400" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 17 Sep 2015 14:46:10 +0200", "Message-Id": "<1442493970-20073-1-git-send-email-sassmann@kpanic.de>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.24", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH net-next] igb: assume MSI-X interrupts\n\tduring initialization", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "In igb_sw_init() the sequence of calls was changed from\nigb_init_queue_configuration()\nigb_init_interrupt_scheme()\nigb_probe_vfs()\nto\nigb_probe_vfs()\nigb_init_queue_configuration()\nigb_init_interrupt_scheme()\n\nThis results in adapter->flags not having the IGB_FLAG_HAS_MSIX bit set\nduring igb_probe_vfs()->igb_enable_sriov(). Therefore SR-IOV does not\nget enabled properly and we run into a NULL pointer if the max_vfs\nmodule parameter is specified (adapter->vf_data does not get allocated,\ncrash on accessing the structure).\n\n[ 7.419348] BUG: unable to handle kernel NULL pointer dereference at 0000000000000048\n[ 7.419367] IP: [<ffffffffa02161c6>] igb_reset+0xe6/0x5d0 [igb]\n[ 7.419370] PGD 0\n[ 7.419373] Oops: 0002 [#1] SMP\n[ 7.419381] Modules linked in: ahci(+) libahci igb(+) i40e(+) vxlan ip6_udp_tunnel udp_tunnel megaraid_sas(+) ixgbe(+) mdio\n[ 7.419385] CPU: 0 PID: 4 Comm: kworker/0:0 Not tainted 4.2.0+ #153\n[ 7.419387] Hardware name: Dell Inc. PowerEdge R720/0C4Y3R, BIOS 1.6.0 03/07/2013\n[...]\n[ 7.419431] Call Trace:\n[ 7.419442] [<ffffffffa0217236>] igb_probe+0x8b6/0x1340 [igb]\n[ 7.419447] [<ffffffff814c7f15>] local_pci_probe+0x45/0xa0\n\nPrevent this by setting the IGB_FLAG_HAS_MSIX bit before calling\nigb_probe_vfs(). The real interrupt capabilities will be checked during\nigb_init_interrupt_scheme() so this is safe to do.\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex e174fbb..ba019fc 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -2986,6 +2986,9 @@ static int igb_sw_init(struct igb_adapter *adapter)\n \t}\n #endif /* CONFIG_PCI_IOV */\n \n+\t/* Assume MSI-X interrupts, will be checked during IRQ allocation */\n+\tadapter->flags |= IGB_FLAG_HAS_MSIX;\n+\n \tigb_probe_vfs(adapter);\n \n \tigb_init_queue_configuration(adapter);\n", "prefixes": [ "net-next" ] }