Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/517283/?format=api
{ "id": 517283, "url": "http://patchwork.ozlabs.org/api/patches/517283/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1442212070-24937-9-git-send-email-sakiwit@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1442212070-24937-9-git-send-email-sakiwit@gmail.com>", "list_archive_url": null, "date": "2015-09-14T06:27:50", "name": "[next-queue,8/8] e1000: get rid of duplicate exit path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fef0de8a158618aac36d8d01fa2ef235fcffe41d", "submitter": { "id": 8799, "url": "http://patchwork.ozlabs.org/api/people/8799/?format=api", "name": "Jεan Sacren", "email": "sakiwit@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1442212070-24937-9-git-send-email-sakiwit@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/517283/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/517283/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 59FE9140D16\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 14 Sep 2015 16:25:13 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AFA9494FF2;\n\tMon, 14 Sep 2015 06:25:12 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id B12rywgODlmm; Mon, 14 Sep 2015 06:25:12 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4FE8A95345;\n\tMon, 14 Sep 2015 06:25:12 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1270C1CEDBE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Sep 2015 06:25:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0F9D9A4C1B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Sep 2015 06:25:11 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vx3fDxAKpBvs for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Sep 2015 06:25:10 +0000 (UTC)", "from mail-pa0-f42.google.com (mail-pa0-f42.google.com\n\t[209.85.220.42])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id A8B7AA4C19\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Sep 2015 06:25:10 +0000 (UTC)", "by pacex6 with SMTP id ex6so134866821pac.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 13 Sep 2015 23:25:10 -0700 (PDT)", "from localhost ([67.214.236.25]) by smtp.gmail.com with ESMTPSA id\n\tbc1sm13783558pbb.66.2015.09.13.23.25.09\n\t(version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128);\n\tSun, 13 Sep 2015 23:25:10 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=FyoppISn;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=O36XZ4XJm3LbXav4N1gu4OMy4OzENVV4KthKSkU8468=;\n\tb=FyoppISnid865fs7CDVpOhVIuC1jDB0lRZ7MO7DZZ3JK6wQLWUYgiAwcrgaxNd+yBr\n\tN2V0gLCLXKGF/HAh9XPOnDzZe09JEPnrBVcbLroUNOk8SaMiW498eYiz4M0/0bt8vFOQ\n\t8yMDJ8Ub/lYbFQN7r0F98QGHPq5UC24Qbkr2WNCCVCnJxTQI6Zb4qyFP3SPLTelgWSuD\n\tUm0wPTw1DwMyhM9n24/85/LBM91tbFQK5kagywgD5KqZ7WNvNi+3PFM3AjpLKyJNPuGM\n\t5AU4b72GIxtlgw6IfvPQkIJoBKa0QLR2/kCy2A3Vk58XpV+RMOkeMvtCSvnVO0/NWhWB\n\tnPMA==", "X-Received": "by 10.67.2.98 with SMTP id bn2mr31161894pad.20.1442211910468;\n\tSun, 13 Sep 2015 23:25:10 -0700 (PDT)", "From": "=?UTF-8?q?J=CE=B5an=20Sacren?= <sakiwit@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 14 Sep 2015 00:27:50 -0600", "Message-Id": "<1442212070-24937-9-git-send-email-sakiwit@gmail.com>", "X-Mailer": "git-send-email 2.4.6", "In-Reply-To": "<1442212070-24937-1-git-send-email-sakiwit@gmail.com>", "References": "<1442212070-24937-1-git-send-email-sakiwit@gmail.com>", "Subject": "[Intel-wired-lan] [next-queue 8/8] e1000: get rid of duplicate exit\n\tpath", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jean Sacren <sakiwit@gmail.com>\n\nBy using goto statement, we can achieve sharing the same exit path so\nthat code duplication could be minimized.\n\nSigned-off-by: Jean Sacren <sakiwit@gmail.com>\n---\n drivers/net/ethernet/intel/e1000/e1000_hw.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c\nindex a67a2c4499eb..737d5c79256b 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_hw.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c\n@@ -2824,14 +2824,13 @@ s32 e1000_read_phy_reg(struct e1000_hw *hw, u32 reg_addr, u16 *phy_data)\n \t (reg_addr > MAX_PHY_MULTI_PAGE_REG)) {\n \t\tret_val = e1000_write_phy_reg_ex(hw, IGP01E1000_PHY_PAGE_SELECT,\n \t\t\t\t\t\t (u16) reg_addr);\n-\t\tif (ret_val) {\n-\t\t\tspin_unlock_irqrestore(&e1000_phy_lock, flags);\n-\t\t\treturn ret_val;\n-\t\t}\n+\t\tif (ret_val)\n+\t\t\tgoto out;\n \t}\n \n \tret_val = e1000_read_phy_reg_ex(hw, MAX_PHY_REG_ADDRESS & reg_addr,\n \t\t\t\t\tphy_data);\n+out:\n \tspin_unlock_irqrestore(&e1000_phy_lock, flags);\n \n \treturn ret_val;\n", "prefixes": [ "next-queue", "8/8" ] }