Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/517278/?format=api
{ "id": 517278, "url": "http://patchwork.ozlabs.org/api/patches/517278/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1442212070-24937-2-git-send-email-sakiwit@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1442212070-24937-2-git-send-email-sakiwit@gmail.com>", "list_archive_url": null, "date": "2015-09-14T06:27:43", "name": "[next-queue,1/8] e1000: clean up the useless 'continue' statement", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c60e6a616882ce05fcc72386db1f99577e741e4a", "submitter": { "id": 8799, "url": "http://patchwork.ozlabs.org/api/people/8799/?format=api", "name": "Jεan Sacren", "email": "sakiwit@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1442212070-24937-2-git-send-email-sakiwit@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/517278/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/517278/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id E17B6140D16\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 14 Sep 2015 16:25:06 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3DB2694FDE;\n\tMon, 14 Sep 2015 06:25:06 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3qzqgBp9Myrm; Mon, 14 Sep 2015 06:25:05 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 476B994FD8;\n\tMon, 14 Sep 2015 06:25:05 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 525721CEDBE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Sep 2015 06:25:03 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4D3F7A4C31\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Sep 2015 06:25:03 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hzGJnWXO3oZ8 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Sep 2015 06:25:02 +0000 (UTC)", "from mail-pa0-f49.google.com (mail-pa0-f49.google.com\n\t[209.85.220.49])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id B3D36A4C17\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Sep 2015 06:25:02 +0000 (UTC)", "by padhy16 with SMTP id hy16so134472706pad.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 13 Sep 2015 23:25:02 -0700 (PDT)", "from localhost ([67.214.236.25]) by smtp.gmail.com with ESMTPSA id\n\tla4sm13770784pbc.76.2015.09.13.23.25.01\n\t(version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128);\n\tSun, 13 Sep 2015 23:25:01 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=KDsBWCNs;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=yc96IPb9npJBNYlfNgTiEw7TGCzxpK9yvdaxwDMoCpk=;\n\tb=KDsBWCNsO+UTGUnVOaxNOUmjmOjNompJ+hLOpWn2wFwO9vr9tCTrg8Bd81BT0maESp\n\tJJn1onciP6otm+ZcQ633qBWOZMeSVfLl+2Ag3IZaIKFQmr72xr7GMPi3Yd3aJeh2te88\n\tdAEBKkPnGMcqIFDUE4V8rqjC8SpIug26J1bzca6V9t7EALinU1O57+qxuVv8xfU2ZwkZ\n\t7hAsBxmkOZXbW0j0GTi9ivsBTaBpvTl+cL1Vy8Z48evwkkgJCK/tJlbb7bxNrKkCEbPQ\n\tu5JuVR/j0YbmB1L/Zr7AcKuUve5y/TvWhzcjQrOb3906nct4g490JI4pUkq1ySBA/O74\n\tSlhw==", "X-Received": "by 10.68.176.227 with SMTP id cl3mr31263886pbc.8.1442211902523; \n\tSun, 13 Sep 2015 23:25:02 -0700 (PDT)", "From": "=?UTF-8?q?J=CE=B5an=20Sacren?= <sakiwit@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 14 Sep 2015 00:27:43 -0600", "Message-Id": "<1442212070-24937-2-git-send-email-sakiwit@gmail.com>", "X-Mailer": "git-send-email 2.4.6", "In-Reply-To": "<1442212070-24937-1-git-send-email-sakiwit@gmail.com>", "References": "<1442212070-24937-1-git-send-email-sakiwit@gmail.com>", "Subject": "[Intel-wired-lan] [next-queue 1/8] e1000: clean up the useless\n\t'continue' statement", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jean Sacren <sakiwit@gmail.com>\n\nWe can delete the 'continue' statement as it is in the end of the block\nand doesn't do any good. To make it distinctive, put an empty line above\nthe checking block.\n\nAdditionally add a pair of braces in the 'else' branch.\n\nSigned-off-by: Jean Sacren <sakiwit@gmail.com>\n---\n drivers/net/ethernet/intel/e1000/e1000_main.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c\nindex 74dc15055971..47397d7b97df 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_main.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c\n@@ -1199,12 +1199,13 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\tfor (i = 0; i < 32; i++) {\n \t\t\thw->phy_addr = i;\n \t\t\te1000_read_phy_reg(hw, PHY_ID2, &tmp);\n+\n \t\t\tif (tmp == 0 || tmp == 0xFF) {\n \t\t\t\tif (i == 31)\n \t\t\t\t\tgoto err_eeprom;\n-\t\t\t\tcontinue;\n-\t\t\t} else\n+\t\t\t} else {\n \t\t\t\tbreak;\n+\t\t\t}\n \t\t}\n \t}\n \n", "prefixes": [ "next-queue", "1/8" ] }