Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/514271/?format=api
{ "id": 514271, "url": "http://patchwork.ozlabs.org/api/patches/514271/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1441315142-173025-14-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1441315142-173025-14-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-09-03T21:19:00", "name": "[next,S15,13/15] i40e: remove unnecessary string copy operations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "339dca75f5224fae0c0212bd29255b1672526c86", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1441315142-173025-14-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/514271/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/514271/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 209A2140771\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 4 Sep 2015 07:18:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6BFFA9519B;\n\tThu, 3 Sep 2015 21:18:45 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Y8L0ycpTFGX7; Thu, 3 Sep 2015 21:18:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4329995439;\n\tThu, 3 Sep 2015 21:18:43 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 30D8E1C1777\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 Sep 2015 21:18:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2C29E9515A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 Sep 2015 21:18:41 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mRHZZqD5sLTy for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 Sep 2015 21:18:39 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BC153952DE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 Sep 2015 21:18:39 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 03 Sep 2015 14:18:26 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby orsmga002.jf.intel.com with ESMTP; 03 Sep 2015 14:18:27 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,464,1437462000\"; d=\"scan'208\";a=\"797336073\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 3 Sep 2015 17:19:00 -0400", "Message-Id": "<1441315142-173025-14-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1441315142-173025-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1441315142-173025-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S15 13/15] i40e: remove unnecessary\n\tstring copy operations", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nSave a little stack space and remove unnecessary strncpy() with a little\nstring pointer.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nChange-ID: Id2719d34710bfc273d3bb445fec085cd04276e88\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 4bcf4a1..848482b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -4896,8 +4896,8 @@ out:\n */\n void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)\n {\n-\tchar speed[SPEED_SIZE] = \"Unknown\";\n-\tchar fc[FC_SIZE] = \"RX/TX\";\n+\tchar *speed = \"Unknown\";\n+\tchar *fc = \"Unknown\";\n \n \tif (vsi->current_isup == isup)\n \t\treturn;\n@@ -4918,19 +4918,19 @@ void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)\n \n \tswitch (vsi->back->hw.phy.link_info.link_speed) {\n \tcase I40E_LINK_SPEED_40GB:\n-\t\tstrlcpy(speed, \"40 Gbps\", SPEED_SIZE);\n+\t\tspeed = \"40 G\";\n \t\tbreak;\n \tcase I40E_LINK_SPEED_20GB:\n-\t\tstrncpy(speed, \"20 Gbps\", SPEED_SIZE);\n+\t\tspeed = \"20 G\";\n \t\tbreak;\n \tcase I40E_LINK_SPEED_10GB:\n-\t\tstrlcpy(speed, \"10 Gbps\", SPEED_SIZE);\n+\t\tspeed = \"10 G\";\n \t\tbreak;\n \tcase I40E_LINK_SPEED_1GB:\n-\t\tstrlcpy(speed, \"1000 Mbps\", SPEED_SIZE);\n+\t\tspeed = \"1000 M\";\n \t\tbreak;\n \tcase I40E_LINK_SPEED_100MB:\n-\t\tstrncpy(speed, \"100 Mbps\", SPEED_SIZE);\n+\t\tspeed = \"100 M\";\n \t\tbreak;\n \tdefault:\n \t\tbreak;\n@@ -4938,20 +4938,20 @@ void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)\n \n \tswitch (vsi->back->hw.fc.current_mode) {\n \tcase I40E_FC_FULL:\n-\t\tstrlcpy(fc, \"RX/TX\", FC_SIZE);\n+\t\tfc = \"RX/TX\";\n \t\tbreak;\n \tcase I40E_FC_TX_PAUSE:\n-\t\tstrlcpy(fc, \"TX\", FC_SIZE);\n+\t\tfc = \"TX\";\n \t\tbreak;\n \tcase I40E_FC_RX_PAUSE:\n-\t\tstrlcpy(fc, \"RX\", FC_SIZE);\n+\t\tfc = \"RX\";\n \t\tbreak;\n \tdefault:\n-\t\tstrlcpy(fc, \"None\", FC_SIZE);\n+\t\tfc = \"None\";\n \t\tbreak;\n \t}\n \n-\tnetdev_info(vsi->netdev, \"NIC Link is Up %s Full Duplex, Flow Control: %s\\n\",\n+\tnetdev_info(vsi->netdev, \"NIC Link is Up %sbps Full Duplex, Flow Control: %s\\n\",\n \t\t speed, fc);\n }\n \n", "prefixes": [ "next", "S15", "13/15" ] }