Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/512648/?format=api
{ "id": 512648, "url": "http://patchwork.ozlabs.org/api/patches/512648/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150831212641.FA5D579A@viggo.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150831212641.FA5D579A@viggo.jf.intel.com>", "list_archive_url": null, "date": "2015-08-31T21:26:41", "name": "e1000: fix e1000e_disable_aspm_locked() warning", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "7f73bcd84739954be95c16a06fa243cbf8e56600", "submitter": { "id": 685, "url": "http://patchwork.ozlabs.org/api/people/685/?format=api", "name": "Dave Hansen", "email": "dave@sr71.net" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150831212641.FA5D579A@viggo.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/512648/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/512648/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id C223C14076B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 1 Sep 2015 10:08:59 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 19E46A35D7;\n\tTue, 1 Sep 2015 00:08:59 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6gNcdEtS7aQT; Tue, 1 Sep 2015 00:08:57 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BA7F6A362B;\n\tTue, 1 Sep 2015 00:08:57 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E1EBA1C1FB8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Aug 2015 21:36:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BE57B95ECB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Aug 2015 21:36:10 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id B1Qr-McAJTH8 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Aug 2015 21:36:08 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C847295E64\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Aug 2015 21:36:08 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP; 31 Aug 2015 14:26:43 -0700", "from viggo.jf.intel.com (HELO localhost.localdomain)\n\t([10.54.39.19])\n\tby fmsmga001.fm.intel.com with ESMTP; 31 Aug 2015 14:26:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:09:26 by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,444,1437462000\"; d=\"scan'208\";a=\"779668621\"", "To": "dave@sr71.net", "From": "Dave Hansen <dave@sr71.net>", "Date": "Mon, 31 Aug 2015 14:26:41 -0700", "Message-Id": "<20150831212641.FA5D579A@viggo.jf.intel.com>", "X-Mailman-Approved-At": "Tue, 01 Sep 2015 00:08:56 +0000", "Cc": "dave.hansen@linux.intel.com, intel-wired-lan@lists.osuosl.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] e1000: fix e1000e_disable_aspm_locked()\n\twarning", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Dave Hansen <dave.hansen@linux.intel.com>\n\nI have a .config with CONFIG_PM disabled. I get the following whenever\ncompiling the e1000 driver:\n\n...net/ethernet/intel/e1000e/netdev.c:6450:13: warning: 'e1000e_disable_aspm_locked' defined but not used [-Wunused-function]\n static void e1000e_disable_aspm_locked(struct pci_dev *pdev, u16 state)\n\nLooks like we just need to move e1000e_disable_aspm_locked() to\nbe underneath the CONFIG_PM #ifdef.\n\nSigned-off-by: Dave Hansen <dave.hansen@linux.intel.com>\nCc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> (supporter:INTEL ETHERNET DRIVERS)\nCc: Jesse Brandeburg <jesse.brandeburg@intel.com> (reviewer)\nCc: Shannon Nelson <shannon.nelson@intel.com> (reviewer)\nCc: Carolyn Wyborny <carolyn.wyborny@intel.com> (reviewer)\nCc: Don Skidmore <donald.c.skidmore@intel.com> (reviewer)\nCc: Matthew Vick <matthew.vick@intel.com> (reviewer)\nCc: John Ronciak <john.ronciak@intel.com> (reviewer)\nCc: Mitch Williams <mitch.a.williams@intel.com> (reviewer)\nCc: intel-wired-lan@lists.osuosl.org (open list:INTEL ETHERNET DRIVERS)\nCc: netdev@vger.kernel.org (open list:NETWORKING DRIVERS)\nCc: linux-kernel@vger.kernel.org (open list)\n---\n\n b/drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff -puN drivers/net/ethernet/intel/e1000e/netdev.c~fix-e1000-warning drivers/net/ethernet/intel/e1000e/netdev.c\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c~fix-e1000-warning\t2015-08-31 14:19:11.520115321 -0700\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\t2015-08-31 14:19:11.525115549 -0700\n@@ -6439,6 +6439,7 @@ static void e1000e_disable_aspm(struct p\n \t__e1000e_disable_aspm(pdev, state, 0);\n }\n \n+#ifdef CONFIG_PM\n /**\n * e1000e_disable_aspm_locked Disable ASPM states.\n * @pdev: pointer to PCI device struct\n@@ -6452,7 +6453,6 @@ static void e1000e_disable_aspm_locked(s\n \t__e1000e_disable_aspm(pdev, state, 1);\n }\n \n-#ifdef CONFIG_PM\n static int __e1000_resume(struct pci_dev *pdev)\n {\n \tstruct net_device *netdev = pci_get_drvdata(pdev);\n", "prefixes": [] }