Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/511346/?format=api
{ "id": 511346, "url": "http://patchwork.ozlabs.org/api/patches/511346/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1440690163-128213-12-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1440690163-128213-12-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-08-27T15:42:39", "name": "[next,S12,11/15] i40e: Fix multiple link up messages", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1d925ea144a3ec970d39a608bcd61acfbec8642b", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1440690163-128213-12-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/511346/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/511346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 7E24C1401F0\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 28 Aug 2015 01:41:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C594A88107;\n\tThu, 27 Aug 2015 15:41:54 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lgNtGUZXewi5; Thu, 27 Aug 2015 15:41:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2BCC5950A3;\n\tThu, 27 Aug 2015 15:41:54 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 588C51C11E9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Aug 2015 15:41:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5588295198\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Aug 2015 15:41:51 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id R3R+12U71n-8 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Aug 2015 15:41:50 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BFBF1950BC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Aug 2015 15:41:50 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 27 Aug 2015 08:41:50 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby orsmga003.jf.intel.com with ESMTP; 27 Aug 2015 08:41:49 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,422,1437462000\"; d=\"scan'208\";a=\"633370279\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 27 Aug 2015 11:42:39 -0400", "Message-Id": "<1440690163-128213-12-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1440690163-128213-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1440690163-128213-1-git-send-email-catherine.sullivan@intel.com>", "Cc": "Matt Jared <matthew.a.jared@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S12 11/15] i40e: Fix multiple link up\n\tmessages", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Matt Jared <matthew.a.jared@intel.com>\n\nThis patch addresses an issue where multiple link up messages can be logged\nresulting from aq link status timing when link properties are changed (fc,\nspeed, etc.); solved by using a single function to handle status printing\nand adding a mechanism to track whether link state (up or down) has\nactually changed.\n\nSigned-off-by: Matt Jared <matthew.a.jared@intel.com>\nChange-ID: Ied6ed6e49dc397c77d992adc0bc9ed3767152b9d\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 2 ++\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++--\n drivers/net/ethernet/intel/i40e/i40e_main.c | 5 ++++-\n 3 files changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 877fab3..672ca75 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -539,6 +539,7 @@ struct i40e_vsi {\n \tu16 idx; /* index in pf->vsi[] */\n \tu16 veb_idx; /* index of VEB parent */\n \tstruct kobject *kobj; /* sysfs object */\n+\tbool current_isup; /* Sync 'link up' logging */\n \n \t/* VSI specific handlers */\n \tirqreturn_t (*irq_handler)(int irq, void *data);\n@@ -793,4 +794,5 @@ int i40e_is_vsi_uplink_mode_veb(struct i40e_vsi *vsi);\n i40e_status i40e_get_npar_bw_setting(struct i40e_pf *pf);\n i40e_status i40e_set_npar_bw_setting(struct i40e_pf *pf);\n i40e_status i40e_commit_npar_bw_setting(struct i40e_pf *pf);\n+void i40e_print_link_message(struct i40e_vsi *vsi, bool isup);\n #endif /* _I40E_H_ */\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex ef471fc..f2b4f8b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -690,7 +690,7 @@ static int i40e_set_settings(struct net_device *netdev,\n \t\t\t/* Tell the OS link is going down, the link will go\n \t\t\t * back up when fw says it is ready asynchronously\n \t\t\t */\n-\t\t\tnetdev_info(netdev, \"PHY settings change requested, NIC Link is going down.\\n\");\n+\t\t\ti40e_print_link_message(vsi, false);\n \t\t\tnetif_carrier_off(netdev);\n \t\t\tnetif_tx_stop_all_queues(netdev);\n \t\t}\n@@ -834,7 +834,7 @@ static int i40e_set_pauseparam(struct net_device *netdev,\n \t/* Tell the OS link is going down, the link will go back up when fw\n \t * says it is ready asynchronously\n \t */\n-\tnetdev_info(netdev, \"Flow control settings change requested, NIC Link is going down.\\n\");\n+\ti40e_print_link_message(vsi, false);\n \tnetif_carrier_off(netdev);\n \tnetif_tx_stop_all_queues(netdev);\n \ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 6cc0fa0..73c6d37 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -4627,11 +4627,14 @@ out:\n * i40e_print_link_message - print link up or down\n * @vsi: the VSI for which link needs a message\n */\n-static void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)\n+void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)\n {\n \tchar speed[SPEED_SIZE] = \"Unknown\";\n \tchar fc[FC_SIZE] = \"RX/TX\";\n \n+\tif (vsi->current_isup == isup)\n+\t\treturn;\n+\tvsi->current_isup = isup;\n \tif (!isup) {\n \t\tnetdev_info(vsi->netdev, \"NIC Link is Down\\n\");\n \t\treturn;\n", "prefixes": [ "next", "S12", "11/15" ] }