Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/511339/?format=api
{ "id": 511339, "url": "http://patchwork.ozlabs.org/api/patches/511339/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1440690163-128213-3-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1440690163-128213-3-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-08-27T15:42:30", "name": "[next,S12,02/15] i40e: Additional checks for CEE APP priority validity", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "29531f19e1612bc098b1586d8b889b0869a6795f", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1440690163-128213-3-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/511339/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/511339/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id C71201401DA\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 28 Aug 2015 01:41:47 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 27C5194FFB;\n\tThu, 27 Aug 2015 15:41:47 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lXlGJh24BmR6; Thu, 27 Aug 2015 15:41:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E9365950A3;\n\tThu, 27 Aug 2015 15:41:44 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6BEC31C11E9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Aug 2015 15:41:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 67BFEA3C8B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Aug 2015 15:41:43 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ygj_K9GPqUkK for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Aug 2015 15:41:43 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 07957A3C89\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Aug 2015 15:41:43 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga102.fm.intel.com with ESMTP; 27 Aug 2015 08:41:42 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby orsmga003.jf.intel.com with ESMTP; 27 Aug 2015 08:41:43 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,422,1437462000\"; d=\"scan'208\";a=\"633370188\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 27 Aug 2015 11:42:30 -0400", "Message-Id": "<1440690163-128213-3-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1440690163-128213-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1440690163-128213-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S12 02/15] i40e: Additional checks\n\tfor CEE APP priority validity", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Neerav Parikh <neerav.parikh@intel.com>\n\nThe firmware has added additional status information to allow software\nto determine if the APP priority for FCoE/iSCSI/FIP is valid or not in\nCEE DCBX mode.\n\nThis patch adds to support those additional checks and will only add\napplications to the software table that have oper and sync bits set\nwithout any error.\n\nSigned-off-by: Neerav Parikh <neerav.parikh@intel.com>\nChange-ID: I0a76c52427dadf97d4dba4538a3068d05e4eb56b\n---\n drivers/net/ethernet/intel/i40e/i40e_dcb.c | 48 ++++++++++++++++++++----------\n 1 file changed, 33 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_dcb.c b/drivers/net/ethernet/intel/i40e/i40e_dcb.c\nindex 90de46a..9aee35d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_dcb.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_dcb.c\n@@ -531,37 +531,55 @@ static void i40e_cee_to_dcb_config(\n \tdcbcfg->pfc.pfcenable = cee_cfg->oper_pfc_en;\n \tdcbcfg->pfc.pfccap = I40E_MAX_TRAFFIC_CLASS;\n \n-\tstatus = (tlv_status & I40E_AQC_CEE_APP_STATUS_MASK) >>\n-\t\t I40E_AQC_CEE_APP_STATUS_SHIFT;\n+\ti = 0;\n+\tstatus = (tlv_status & I40E_AQC_CEE_FCOE_STATUS_MASK) >>\n+\t\t I40E_AQC_CEE_FCOE_STATUS_SHIFT;\n \terr = (status & I40E_TLV_STATUS_ERR) ? 1 : 0;\n \tsync = (status & I40E_TLV_STATUS_SYNC) ? 1 : 0;\n \toper = (status & I40E_TLV_STATUS_OPER) ? 1 : 0;\n-\t/* Add APPs if Error is False and Oper/Sync is True */\n+\t/* Add FCoE APP if Error is False and Oper/Sync is True */\n \tif (!err && sync && oper) {\n-\t\t/* CEE operating configuration supports FCoE/iSCSI/FIP only */\n-\t\tdcbcfg->numapps = I40E_CEE_OPER_MAX_APPS;\n-\n \t\t/* FCoE APP */\n-\t\tdcbcfg->app[0].priority =\n+\t\tdcbcfg->app[i].priority =\n \t\t\t(app_prio & I40E_AQC_CEE_APP_FCOE_MASK) >>\n \t\t\t I40E_AQC_CEE_APP_FCOE_SHIFT;\n-\t\tdcbcfg->app[0].selector = I40E_APP_SEL_ETHTYPE;\n-\t\tdcbcfg->app[0].protocolid = I40E_APP_PROTOID_FCOE;\n+\t\tdcbcfg->app[i].selector = I40E_APP_SEL_ETHTYPE;\n+\t\tdcbcfg->app[i].protocolid = I40E_APP_PROTOID_FCOE;\n+\t\ti++;\n+\t}\n \n+\tstatus = (tlv_status & I40E_AQC_CEE_ISCSI_STATUS_MASK) >>\n+\t\t I40E_AQC_CEE_ISCSI_STATUS_SHIFT;\n+\terr = (status & I40E_TLV_STATUS_ERR) ? 1 : 0;\n+\tsync = (status & I40E_TLV_STATUS_SYNC) ? 1 : 0;\n+\toper = (status & I40E_TLV_STATUS_OPER) ? 1 : 0;\n+\t/* Add iSCSI APP if Error is False and Oper/Sync is True */\n+\tif (!err && sync && oper) {\n \t\t/* iSCSI APP */\n-\t\tdcbcfg->app[1].priority =\n+\t\tdcbcfg->app[i].priority =\n \t\t\t(app_prio & I40E_AQC_CEE_APP_ISCSI_MASK) >>\n \t\t\t I40E_AQC_CEE_APP_ISCSI_SHIFT;\n-\t\tdcbcfg->app[1].selector = I40E_APP_SEL_TCPIP;\n-\t\tdcbcfg->app[1].protocolid = I40E_APP_PROTOID_ISCSI;\n+\t\tdcbcfg->app[i].selector = I40E_APP_SEL_TCPIP;\n+\t\tdcbcfg->app[i].protocolid = I40E_APP_PROTOID_ISCSI;\n+\t\ti++;\n+\t}\n \n+\tstatus = (tlv_status & I40E_AQC_CEE_FIP_STATUS_MASK) >>\n+\t\t I40E_AQC_CEE_FIP_STATUS_SHIFT;\n+\terr = (status & I40E_TLV_STATUS_ERR) ? 1 : 0;\n+\tsync = (status & I40E_TLV_STATUS_SYNC) ? 1 : 0;\n+\toper = (status & I40E_TLV_STATUS_OPER) ? 1 : 0;\n+\t/* Add FIP APP if Error is False and Oper/Sync is True */\n+\tif (!err && sync && oper) {\n \t\t/* FIP APP */\n-\t\tdcbcfg->app[2].priority =\n+\t\tdcbcfg->app[i].priority =\n \t\t\t(app_prio & I40E_AQC_CEE_APP_FIP_MASK) >>\n \t\t\t I40E_AQC_CEE_APP_FIP_SHIFT;\n-\t\tdcbcfg->app[2].selector = I40E_APP_SEL_ETHTYPE;\n-\t\tdcbcfg->app[2].protocolid = I40E_APP_PROTOID_FIP;\n+\t\tdcbcfg->app[i].selector = I40E_APP_SEL_ETHTYPE;\n+\t\tdcbcfg->app[i].protocolid = I40E_APP_PROTOID_FIP;\n+\t\ti++;\n \t}\n+\tdcbcfg->numapps = i;\n }\n \n /**\n", "prefixes": [ "next", "S12", "02/15" ] }