Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/511031/?format=api
{ "id": 511031, "url": "http://patchwork.ozlabs.org/api/patches/511031/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1440616461-110869-11-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1440616461-110869-11-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-08-26T19:14:16", "name": "[next,S11,10/15] i40e: Never let speed get set to 0 in get_settings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dcd9357a668656e534397692b4048bfe621cf594", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1440616461-110869-11-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/511031/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/511031/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 327D7140332\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 27 Aug 2015 05:13:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 885A7A2B32;\n\tWed, 26 Aug 2015 19:13:54 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ah_JumxoBCsQ; Wed, 26 Aug 2015 19:13:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E6290A2D38;\n\tWed, 26 Aug 2015 19:13:53 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 438BA1C1550\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 26 Aug 2015 19:13:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3FF8394F5F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 26 Aug 2015 19:13:52 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vBdiUN5idJ30 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 26 Aug 2015 19:13:51 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E387F94F37\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 26 Aug 2015 19:13:51 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 26 Aug 2015 12:13:51 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby orsmga003.jf.intel.com with ESMTP; 26 Aug 2015 12:13:51 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,418,1437462000\"; d=\"scan'208\";a=\"632786459\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 26 Aug 2015 15:14:16 -0400", "Message-Id": "<1440616461-110869-11-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1440616461-110869-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1440616461-110869-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S11 10/15] i40e: Never let speed get\n\tset to 0 in get_settings", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "In ethtool, there is a possibility of speed getting set to 0\nif advertise is set to 0 (which it is when autoneg is disabled).\nWe never want this to happen as the firmware will actually attempt\nto set the speed to 0 sending link down, so add an extra check\nto make sure this doesn't happen.\n\nSigned-off-by: Catherine Sullivan <catherine.sullivan@intel.com>\nChange-ID: I62e0eeee2cbf043d8e6f5c9c9f0b92794e877f01\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 928bd5a..930369c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -666,6 +666,13 @@ static int i40e_set_settings(struct net_device *netdev,\n \t advertise & ADVERTISED_40000baseLR4_Full)\n \t\tconfig.link_speed |= I40E_LINK_SPEED_40GB;\n \n+\t/* If speed didn't get set, set it to what it currently is.\n+\t * This is needed because if advertise is 0 (as it is when autoneg\n+\t * is disabled) then speed won't get set.\n+\t */\n+\tif (!config.link_speed)\n+\t\tconfig.link_speed = abilities.link_speed;\n+\n \tif (change || (abilities.link_speed != config.link_speed)) {\n \t\t/* copy over the rest of the abilities */\n \t\tconfig.phy_type = abilities.phy_type;\n", "prefixes": [ "next", "S11", "10/15" ] }