Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/511027/?format=api
{ "id": 511027, "url": "http://patchwork.ozlabs.org/api/patches/511027/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1440616461-110869-8-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1440616461-110869-8-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-08-26T19:14:13", "name": "[next,S11,07/15] i40e: make i40e_init_pf_fcoe to void", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "af2918dce29bbe2d06aeef256db382c8a4339fe4", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1440616461-110869-8-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/511027/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/511027/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id C68E4140311\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 27 Aug 2015 05:13:51 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 25741A2D4B;\n\tWed, 26 Aug 2015 19:13:51 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id G6wxFksRurBB; Wed, 26 Aug 2015 19:13:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 79089A2D6D;\n\tWed, 26 Aug 2015 19:13:50 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 613831C1550\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 26 Aug 2015 19:13:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5C88694F5F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 26 Aug 2015 19:13:49 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GquyPT8vda+Z for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 26 Aug 2015 19:13:48 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E1F3C94F37\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 26 Aug 2015 19:13:48 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 26 Aug 2015 12:13:48 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby orsmga003.jf.intel.com with ESMTP; 26 Aug 2015 12:13:48 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,418,1437462000\"; d=\"scan'208\";a=\"632786429\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 26 Aug 2015 15:14:13 -0400", "Message-Id": "<1440616461-110869-8-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1440616461-110869-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1440616461-110869-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S11 07/15] i40e: make\n\ti40e_init_pf_fcoe to void", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\ni40e_init_pf_fcoe() didn't return anything except 0, it prints enough\nerror info already, and no driver logic depends on the return value,\nso this can be void.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nChange-ID: Ie6afad849857d87a7064c42c3cce14c74c2f29d8\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 2 +-\n drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 10 ++++------\n drivers/net/ethernet/intel/i40e/i40e_main.c | 8 ++------\n 3 files changed, 7 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 12c96da..5e546f9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -742,7 +742,7 @@ int i40e_fcoe_vsi_init(struct i40e_vsi *vsi, struct i40e_vsi_context *ctxt);\n u8 i40e_get_fcoe_tc_map(struct i40e_pf *pf);\n void i40e_fcoe_config_netdev(struct net_device *netdev, struct i40e_vsi *vsi);\n void i40e_fcoe_vsi_setup(struct i40e_pf *pf);\n-int i40e_init_pf_fcoe(struct i40e_pf *pf);\n+void i40e_init_pf_fcoe(struct i40e_pf *pf);\n int i40e_fcoe_setup_ddp_resources(struct i40e_vsi *vsi);\n void i40e_fcoe_free_ddp_resources(struct i40e_vsi *vsi);\n int i40e_fcoe_handle_offload(struct i40e_ring *rx_ring,\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c\nindex 5ea75dd..2398d9b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c\n@@ -272,10 +272,8 @@ out:\n /**\n * i40e_fcoe_sw_init - sets up the HW for FCoE\n * @pf: pointer to PF\n- *\n- * Returns 0 if FCoE is supported otherwise the error code\n **/\n-int i40e_init_pf_fcoe(struct i40e_pf *pf)\n+void i40e_init_pf_fcoe(struct i40e_pf *pf)\n {\n \tstruct i40e_hw *hw = &pf->hw;\n \tu32 val;\n@@ -287,13 +285,13 @@ int i40e_init_pf_fcoe(struct i40e_pf *pf)\n \n \tif (!pf->hw.func_caps.fcoe) {\n \t\tdev_info(&pf->pdev->dev, \"FCoE capability is disabled\\n\");\n-\t\treturn 0;\n+\t\treturn;\n \t}\n \n \tif (!pf->hw.func_caps.dcb) {\n \t\tdev_warn(&pf->pdev->dev,\n \t\t\t \"Hardware is not DCB capable not enabling FCoE.\\n\");\n-\t\treturn 0;\n+\t\treturn;\n \t}\n \n \t/* enable FCoE hash filter */\n@@ -326,7 +324,7 @@ int i40e_init_pf_fcoe(struct i40e_pf *pf)\n \twr32(hw, I40E_GLFCOE_RCTL, val);\n \n \tdev_info(&pf->pdev->dev, \"FCoE is supported.\\n\");\n-\treturn 0;\n+\treturn;\n }\n \n /**\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex bf181e9..f7da41b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -6426,9 +6426,7 @@ static void i40e_reset_and_rebuild(struct i40e_pf *pf, bool reinit)\n \t}\n #endif /* CONFIG_I40E_DCB */\n #ifdef I40E_FCOE\n-\tret = i40e_init_pf_fcoe(pf);\n-\tif (ret)\n-\t\tdev_info(&pf->pdev->dev, \"init_pf_fcoe failed: %d\\n\", ret);\n+\ti40e_init_pf_fcoe(pf);\n \n #endif\n \t/* do basic switch setup */\n@@ -7824,9 +7822,7 @@ static int i40e_sw_init(struct i40e_pf *pf)\n \t}\n \n #ifdef I40E_FCOE\n-\terr = i40e_init_pf_fcoe(pf);\n-\tif (err)\n-\t\tdev_info(&pf->pdev->dev, \"init_pf_fcoe failed: %d\\n\", err);\n+\ti40e_init_pf_fcoe(pf);\n \n #endif /* I40E_FCOE */\n #ifdef CONFIG_PCI_IOV\n", "prefixes": [ "next", "S11", "07/15" ] }